[GRASS5] [bug #844] (grass) cheated by r.contour

GRASS GRASS developer
1

this bug's URL: http://intevation.de/rt/webrt?serial_num=844
-------------------------------------------------------------------------

$ r.contour

OPTION: Name of an existing raster map
     key: input
required: YES

Enter the name of an existing raster file
Enter 'list' for a list of existing raster files
Hit RETURN to cancel request

topo

<topo>

OPTION: List of contour levels
     key: levels
required: NO
multiple: YES
enter option >

OPTION: Minimum contour level
     key: minlevel
required: NO <<<<<<<<<<<<<<<<<<<<<<see, it says NO
enter option >

OPTION: Maximum contour level
     key: maxlevel
required: NO
enter option >

OPTION: Increment between contour levels
     key: step
required: NO
enter option >

OPTION: Minimum number of points for a contour line (0 -> no limit)
     key: cut
default: 0
required: NO
enter option >

OPTION: Name of output vector file
     key: output
required: YES
enter option > contour

You have chosen:
  output=contour
Is this correct? (y/n) [y] y

FLAG: Set the following flag?
    Suppress progress report & min/max information?(y/n) [n]

FLAG: Set the following flag?
    Suppress single crossing error messages?(y/n) [n]
Reading data.
Percent complete: 100%
FPRange of data: min = 40.000000 max = 278.000000
ERROR: Minimum parameters not set. <<<<<<<<<<<<<<<<<but it said it wasn't required
Either a step or a list of levels must be specified
ERROR:
1grass$

--- Headers Follow ---

From neteler@itc.it Fri Nov 16 16:39:49 2001

Return-Path: <neteler@itc.it>
Delivered-To: grass-bugs@lists.intevation.de
Received: from omecihuatl.rz.uni-osnabrueck.de (omecihuatl.rz.Uni-Osnabrueck.DE [131.173.17.35])
  by lists.intevation.de (Postfix) with ESMTP id 0BA15139CC
  for <grass-bugs@intevation.de>; Fri, 16 Nov 2001 16:39:49 +0100 (CET)
Received: from camelot.itc.it (camelot.itc.it [195.223.171.5])
  by omecihuatl.rz.uni-osnabrueck.de (8.11.1/8.11.1) with ESMTP id fAGFdmf23959
  for <grass-bugs@intevation.de>; Fri, 16 Nov 2001 16:39:48 +0100
Received: from artemide.itc.it (artemide [10.0.10.10])
  by camelot.itc.it (8.11.3/8.11.3) with ESMTP id fAGFdld19390
  for <grass-bugs@intevation.de>; Fri, 16 Nov 2001 16:39:47 +0100 (MET)
Received: from thuille.itc.it. (thuille [10.40.0.110])
  by artemide.itc.it (8.11.3/8.11.3) with ESMTP id fAGFdiE19198
  for <grass-bugs@intevation.de>; Fri, 16 Nov 2001 16:39:45 +0100 (MET)
Received: (from neteler@localhost)
  by thuille.itc.it. (8.11.6/8.11.2) id fAGFdiv29631
  for grass-bugs@intevation.de; Fri, 16 Nov 2001 16:39:44 +0100
Resent-Message-Id: <200111161539.fAGFdiv29631@thuille.itc.it.>
Received: from camelot.itc.it (camelot [195.223.171.5])
  by artemide.itc.it (8.11.3/8.11.3) with ESMTP id fAGFMXE16802
  for <neteler@itc.it>; Fri, 16 Nov 2001 16:22:39 +0100 (MET)
Received: from localhost.localdomain (h137.s30.ts32.hinet.net [163.32.30.137])
  by camelot.itc.it (8.11.3/8.11.3) with ESMTP id fAGFMQd18917
  for <neteler@itc.it>; Fri, 16 Nov 2001 16:22:27 +0100 (MET)
Received: by localhost.localdomain (Postfix, from userid 501)
  id B407316DE; Fri, 16 Nov 2001 22:27:27 +0800 (CST)
To: Markus Neteler <neteler@itc.it>
Subject: cheated by r.contour
From: Dan Jacobson <jidanni@yam.com.tw>
Reply-To: jidanni@yahoo.com.tw
Date: Fri, 16 Nov 2001 22:27:26 +0800 01:00:00 +0000 (GMT)
Message-ID: <m2elmy23ld.fsf@Mdan.jacobson.tw>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Resent-From: neteler@itc.it
Resent-Date: Fri, 16 Nov 2001 16:39:44 +0100
Resent-To: grass-bugs@intevation.de

-------------------------------------------- Managed by Request Tracker

2

Request Tracker wrote:

$ r.contour

OPTION: Name of an existing raster map
     key: input
required: YES

Enter the name of an existing raster file
Enter 'list' for a list of existing raster files
Hit RETURN to cancel request
> topo
<topo>

OPTION: List of contour levels
     key: levels
required: NO
multiple: YES
enter option >

OPTION: Minimum contour level
     key: minlevel
required: NO <<<<<<<<<<<<<<<<<<<<<<see, it says NO
enter option >

Yes; but this isn't what it's complaining about.

OPTION: Maximum contour level
     key: maxlevel
required: NO
enter option >

OPTION: Increment between contour levels
     key: step
required: NO
enter option >

OPTION: Minimum number of points for a contour line (0 -> no limit)
     key: cut
default: 0
required: NO
enter option >

OPTION: Name of output vector file
     key: output
required: YES
enter option > contour

You have chosen:
  output=contour
Is this correct? (y/n) [y] y

FLAG: Set the following flag?
    Suppress progress report & min/max information?(y/n) [n]

FLAG: Set the following flag?
    Suppress single crossing error messages?(y/n) [n]
Reading data.
Percent complete: 100%
FPRange of data: min = 40.000000 max = 278.000000
ERROR: Minimum parameters not set. <<<<<<<<<<<<<<<<<but it said it wasn't required
Either a step or a list of levels must be specified

It isn't saying that the "minimum" parameter is required. It's saying
that you haven't provided enough parameters. Saying "Insufficent
parameters" may have been clearer.

How about:

  ERROR: neither "levels" nor "step" parameter specified.

?

--
Glynn Clements <glynn.clements@virgin.net>

3

Glynn Clements wrote:

Request Tracker wrote:

> $ r.contour
>
> OPTION: Name of an existing raster map
> key: input
> required: YES
>
> Enter the name of an existing raster file
> Enter 'list' for a list of existing raster files
> Hit RETURN to cancel request
> > topo
> <topo>
>
> OPTION: List of contour levels
> key: levels
> required: NO
> multiple: YES
> enter option >
>
> OPTION: Minimum contour level
> key: minlevel
> required: NO <<<<<<<<<<<<<<<<<<<<<<see, it says NO
> enter option >

Yes; but this isn't what it's complaining about.

> OPTION: Maximum contour level
> key: maxlevel
> required: NO
> enter option >
>
> OPTION: Increment between contour levels
> key: step
> required: NO
> enter option >
>
> OPTION: Minimum number of points for a contour line (0 -> no limit)
> key: cut
> default: 0
> required: NO
> enter option >
>
> OPTION: Name of output vector file
> key: output
> required: YES
> enter option > contour
>
> You have chosen:
> output=contour
> Is this correct? (y/n) [y] y
>
> FLAG: Set the following flag?
> Suppress progress report & min/max information?(y/n) [n]
>
> FLAG: Set the following flag?
> Suppress single crossing error messages?(y/n) [n]
> Reading data.
> Percent complete: 100%
> FPRange of data: min = 40.000000 max = 278.000000
> ERROR: Minimum parameters not set. <<<<<<<<<<<<<<<<<but it said it wasn't required
> Either a step or a list of levels must be specified

It isn't saying that the "minimum" parameter is required. It's saying
that you haven't provided enough parameters. Saying "Insufficent
parameters" may have been clearer.

How about:

        ERROR: neither "levels" nor "step" parameter specified.

Glynn, you could change the error message although that may still not satisfy
some users - in GRASS there are probably more programs with parameters like this
and it was assumed that user reads the manual (or at least thinks), so this isn't
really
a bug. The clean solution would be that if no parameters are given, but the name of
output
file is given the program gives warning that sufficient parameters were not set
and runs some default output, in this case
it can draw ten contours between minimum and max values.

But this really is not of great priority, unless it is an easy thing to do. It is not
too difficult
for any thinking person to figure out that he needs to give some info on which contours
to draw.

Helena

?

--
Glynn Clements <glynn.clements@virgin.net>
_______________________________________________
grass5 mailing list
grass5@grass.itc.it
http://grass.itc.it/mailman/listinfo/grass5