[GRASS5] Changes between 5.0.1 release and current CVS head

I've attached a summary of the differences between the current CVS
head and the 5.0.1 release.

I'll comment on it later (probably tomorrow).

--
Glynn Clements <glynn.clements@virgin.net>

(attachments)

grass-diff.txt (22 KB)

I've attached a summary of the differences between the current CVS
head and the 5.0.1 release.

I'll comment on it later (probably tomorrow).

My comments follow. I'd appreciate comments from the authors of any
changes marked "Probably" or "Don't know".

BTW, the script which I use for comparing versions has been added to
the CVS head as tools/diff.sh.

Of the more wide-ranging changes:

I'm recommending the inclusion of the libgis/libraster I18N; it's been
there long enough, and there's good reason to believe that it should
be totally harmless provided that --with-nls isn't used. OTOH, I'm not
recommending the startup/tcltkgrass I18N changes, because those can't
be disabled.

I'm not recommending the MINGW32 stuff generally, as it looks a bit
rough at present. OTOH, the unlink() -> remove() change is
straightforward enough.

The Infx -> Pg changes *really* should have waited until 5.1, IMHO. It
makes it almost impossible to tell whether anything substantial has
changed, so we would either have to commit the whole lot and hope for
the best, or leave it completely alone.

--
Glynn Clements <glynn.clements@virgin.net>

NEWS.html
README
SUBMITTING
binaryInstall.src
documents/README_cygwin.html
documents/cygwin_grass50bininstall.html
documents/cygwin_grass50compile.html
documents/debugging.txt
documents/release_rules.txt
html/tips_and_tricks.html
  Documentation changes

Probably.

configure
configure.in
  Remove TERMLIB
  Add $MATHLIB to PNG candidate dependencies
  Remove postgres[_fe].h checks
  Add -lstdc++ to GLU candidate dependencies

Yes.

src/include/config.h.in
  Remove HAVE_POSTGRES[_FE]_H
  Add HAVE_LIBPQ_FE_H

Yes.

src/CMD/head/head.in
  Remove $(TERMLIB)
  Remove $(XEXTRALIBS) from XDRLIB

Yes.

handheld/babyGRASS_compile.sh
handheld/babyGRASS_packagingsrc.sh
  Add more modules

Probably.

html/html/d.vect.pg.html
  -e

Don't know.

html/html/r.mapcalc.html
  ^ (exponentiation) operator
  y#, i# modifiers
  atan(x,y), double(x), not(x), rand(a,b)
  Handling of NULL values

Yes.

html/html/r.random.cells.html
html/html/r.random.surface.html
  Fix URLs

Probably.

html/html/r.watershed.html
  xrefs

Probably.

html/html/s.in.ascii.html
  HTML fix

Yes.

html/html/v.out.shape.html
  -v, -A
  HTML tidying

Probably.

html/html/xdriver.html
  XDRIVER_{WIDTH,HEIGHT} -> GRASS_{WIDTH,HEIGHT}

Yes.

html/index.html
html/searchhtml.html
  index2.html -> index.html

Don't know.

html/projections.html
  EPSG link

Probably.

locale/Gmakefile
  Add tcltkgrass, textintro targets

No.

locale/ru/LC_MESSAGES/d.rast.pg.po
locale/ru/LC_MESSAGES/d.site.pg.po
locale/ru/LC_MESSAGES/d.vect.pg.po
locale/ru/LC_MESSAGES/d.what.r.pg.po
locale/ru/LC_MESSAGES/d.what.s.pg.po
locale/ru/LC_MESSAGES/d.what.v.pg.po
locale/ru/LC_MESSAGES/g.column.pg.po
locale/ru/LC_MESSAGES/g.select.pg.po
locale/ru/LC_MESSAGES/g.stats.pg.po
locale/ru/LC_MESSAGES/g.table.pg.po
locale/ru/LC_MESSAGES/pg.in.dbf.po
locale/ru/LC_MESSAGES/v.reclass.pg.po
locale/ru/LC_MESSAGES/v.to.pg.po

Depends upon the corresponding program changes.

src.contrib/GMSL/NVIZ2.2/doconfigure
- src.contrib/GMSL/NVIZ2.2/src/query_postgr_dummy.c
- src.contrib/GMSL/NVIZ2.2/src/query_postgr_orig.c
  Remove query_postgr_{orig,dummy}.c

Don't know.

src.contrib/GMSL/NVIZ2.2/src/query_postgr.c
  Remove query_postgr_{orig,dummy}.c
  ???

Don't know.

src.contrib/GMSL/NVIZ2.2/scripts/fileBrowser.tcl
  Default to cwd instead of $HOME

No; use built-in "pwd" rather than "exec pwd".

src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
src.contrib/GMSL/NVIZ2.2/src/anim_support.c
src.contrib/GMSL/NVIZ2.2/src/change_view.c
src.contrib/GMSL/NVIZ2.2/src/getCat.c
src.contrib/GMSL/NVIZ2.2/src/init_commands.c
src.contrib/GMSL/NVIZ2.2/src/interface.h
src.contrib/GMSL/NVIZ2.2/src/position.c
  ???

Don't know.

src.contrib/GMSL/NVIZ2.2/src/Gmakefile
- src.contrib/GMSL/NVIZ2.2/src/buildInfxQry.c
- src.contrib/GMSL/NVIZ2.2/src/infx.h
- src.contrib/GMSL/NVIZ2.2/src/runInfxQry.c
+ src.contrib/GMSL/NVIZ2.2/src/buildPg.c
+ src.contrib/GMSL/NVIZ2.2/src/pg.h
+ src.contrib/GMSL/NVIZ2.2/src/runPg.c
  Infx -> Pg

Don't know.

+ src.contrib/GMSL/NVIZ2.2/src/README
  HOWTO - Adding new header files from tcl/tk

Probably.

+ src.contrib/GMSL/NVIZ2.2/src/tkInt8.4.h
+ src.contrib/GMSL/NVIZ2.2/src/tkIntDecls8.4.h
  Add Tk 8.4 support

Yes (togl.c was already updated in 5.0.1, but these files were missing).

src.contrib/GMSL/NVIZ2.2/src/togl.c
  Remove $Log$
  Add Tcl/Tk URL

Yes.

src.contrib/GMSL/g3d/src3d/general/g3.region/editcellhd3d.c
src.contrib/GMSL/g3d/src3d/raster/r3.mapcalc/mapcalc/xcoor.c
src.contrib/GMSL/g3d/src3d/raster/r3.mapcalc/mapcalc/xrowcol.c
src.contrib/GMSL/g3d/src3d/raster/r3.null/main.c
src.contrib/GMSL/g3d/src3d/raster/r3.out.ascii/main.c
src.contrib/GMSL/g3d/src3d/raster/r3.out.v5d/main.c
src.contrib/GMSL/g3d/src3d/raster/r3.out.v5d/v5d.h
src.contrib/GMSL/g3d/src3d/sites/s.vol.idw/main.c
src.contrib/GMSL/g3d/src3d/sites/s.vol.rst/user1.c
  ??? (AV)

Probably (g3d isn't built by default, so compatibility isn't an issue).

src.contrib/SCS/misc/m.futil/inter/Gmakefile
src.contrib/SCS/paint/Programs/color.map/inter/Gmakefile
src.contrib/SCS/paint/Programs/grey.map/inter/Gmakefile
src.contrib/SCS/paint/Programs/newp.map/inter/Gmakefile
src.contrib/SCS/raster/r.reclass.scs/inter/Gmakefile
src.contrib/SCS/vector/v.reclass/inter/Gmakefile
src/general/g.manual/inter/Gmakefile
src/general/manage/inter/Gmakefile
src/mapdev/v.extract/inter/Gmakefile
src/mapdev/v.out.dxf/backup/Gmakefile
src/paint/Programs/p.icons/Gmakefile
src/paint/Programs/p.map/inter/Gmakefile
src/ps.map/ps.map/inter/Gmakefile
src/raster/r.neighbors/inter/Gmakefile
src/raster/r.support/inter/Gmakefile
unused/general/g.manual/inter/Gmakefile
unused/sites/s.menu/driver/Gmakefile
unused/sites/s.menu/meta_report/Gmakefile
unused/sites/s.menu/site_reports/Gmakefile
unused/sites/s.menu/sites_in_cell/Gmakefile
unused/sites/s.menu/sites_to_cell/Gmakefile
  Remove $(TERMLIB)

Yes.

src.garden/answers/src.answers/raster/README
  Documentation changes

Probably.

src.garden/grass.hdf/hdf5/r.in.hdf/r.in.hdf.c
  Add GSFC/DAAC credit

Yes.

src.garden/grass.postgresql/Gmakefile
  Disable v.in.arc.pg

Don't know.

src.garden/grass.postgresql/README
  Documentation changes

Probably.

- src.garden/grass.postgresql/d.rast.pg/buildInfxQry.c
- src.garden/grass.postgresql/d.rast.pg/runInfxFile.c
- src.garden/grass.postgresql/d.site.pg/buildInfxQry.c
- src.garden/grass.postgresql/d.site.pg/runInfxFile.c
- src.garden/grass.postgresql/d.vect.pg/buildInfxQry.c
- src.garden/grass.postgresql/d.vect.pg/runInfxFile.c
- src.garden/grass.postgresql/d.what.r.pg/buildInfxQry.c
- src.garden/grass.postgresql/d.what.r.pg/runInfxQry.c
- src.garden/grass.postgresql/d.what.s.pg/buildInfxQry.c
- src.garden/grass.postgresql/d.what.s.pg/infx.h
- src.garden/grass.postgresql/d.what.s.pg/runInfxFile.c
- src.garden/grass.postgresql/d.what.v.pg/buildInfxQry.c
- src.garden/grass.postgresql/d.what.v.pg/runInfxQry.c
- src.garden/grass.postgresql/g.column.pg/infx.h
- src.garden/grass.postgresql/g.column.pg/infxColumn.c
- src.garden/grass.postgresql/g.stats.pg/infx.h
- src.garden/grass.postgresql/g.stats.pg/infxStats.c
- src.garden/grass.postgresql/g.table.pg/infxTable.c
- src.garden/grass.postgresql/v.reclass.pg/buildInfxQry.c
- src.garden/grass.postgresql/v.reclass.pg/runInfxFile.c
- src.garden/grass.postgresql/v.to.pg/buildInfxQry.c
- src.garden/grass.postgresql/v.to.pg/runInfxFile.c
+ src.garden/grass.postgresql/d.rast.pg/buildPg.c
+ src.garden/grass.postgresql/d.rast.pg/runPg.c
+ src.garden/grass.postgresql/d.site.pg/buildPg.c
+ src.garden/grass.postgresql/d.site.pg/runPg.c
+ src.garden/grass.postgresql/d.vect.pg/buildPg.c
+ src.garden/grass.postgresql/d.vect.pg/runPg.c
+ src.garden/grass.postgresql/d.what.r.pg/buildPg.c
+ src.garden/grass.postgresql/d.what.r.pg/runPg.c
+ src.garden/grass.postgresql/d.what.s.pg/buildPg.c
+ src.garden/grass.postgresql/d.what.s.pg/runPg.c
+ src.garden/grass.postgresql/d.what.v.pg/buildPg.c
+ src.garden/grass.postgresql/d.what.v.pg/runPg.c
+ src.garden/grass.postgresql/g.column.pg/pgColumn.c
+ src.garden/grass.postgresql/g.stats.pg/pgStats.c
+ src.garden/grass.postgresql/g.table.pg/pgTable.c
+ src.garden/grass.postgresql/v.reclass.pg/buildPg.c
+ src.garden/grass.postgresql/v.reclass.pg/runPg.c
+ src.garden/grass.postgresql/v.to.pg/buildPg.c
+ src.garden/grass.postgresql/v.to.pg/runPg.c
src.garden/grass.postgresql/d.rast.pg/Gmakefile
src.garden/grass.postgresql/d.site.pg/Gmakefile
src.garden/grass.postgresql/d.vect.pg/Gmakefile
src.garden/grass.postgresql/d.what.r.pg/Gmakefile
src.garden/grass.postgresql/d.what.s.pg/Gmakefile
src.garden/grass.postgresql/d.what.v.pg/Gmakefile
src.garden/grass.postgresql/g.column.pg/Gmakefile
src.garden/grass.postgresql/g.stats.pg/Gmakefile
src.garden/grass.postgresql/v.reclass.pg/Gmakefile
src.garden/grass.postgresql/v.to.pg/Gmakefile
  Infx -> Pg

No.

src.garden/grass.postgresql/g.table.pg/Gmakefile
  Infx -> Pg
  I18N

Don't know.

- src.garden/grass.postgresql/d.what.s.pg/graphics.h
- src.garden/grass.postgresql/d.what.s.pg/returns.c
+ src.garden/grass.postgresql/d.what.s.pg/what.h
- src.garden/grass.postgresql/g.column.pg/column.h
- src.garden/grass.postgresql/g.column.pg/delcr.c
- src.garden/grass.postgresql/g.stats.pg/stats.h

src.garden/grass.postgresql/d.rast.pg/dbrast.h
src.garden/grass.postgresql/d.rast.pg/getAllOpts.c
src.garden/grass.postgresql/d.rast.pg/getSopts.c
src.garden/grass.postgresql/d.rast.pg/main.c
src.garden/grass.postgresql/d.site.pg/dbsite.h
src.garden/grass.postgresql/d.site.pg/getAllOpts.c
src.garden/grass.postgresql/d.site.pg/getSopts.c
src.garden/grass.postgresql/d.site.pg/main.c
src.garden/grass.postgresql/d.site.pg/plotsite.c
src.garden/grass.postgresql/d.vect.pg/bsearch.c
src.garden/grass.postgresql/d.vect.pg/dbvect.h
src.garden/grass.postgresql/d.vect.pg/find.c
src.garden/grass.postgresql/d.vect.pg/getAllOpts.c
src.garden/grass.postgresql/d.vect.pg/getSopts.c
src.garden/grass.postgresql/d.vect.pg/main.c
src.garden/grass.postgresql/d.vect.pg/plotCat.c
src.garden/grass.postgresql/d.what.r.pg/getAllOpts.c
src.garden/grass.postgresql/d.what.r.pg/getCat.c
src.garden/grass.postgresql/d.what.r.pg/getSopts.c
src.garden/grass.postgresql/d.what.r.pg/main.c
src.garden/grass.postgresql/d.what.r.pg/opencell.c
src.garden/grass.postgresql/d.what.r.pg/what.h
src.garden/grass.postgresql/d.what.s.pg/getAllOpts.c
src.garden/grass.postgresql/d.what.s.pg/getArea.c
src.garden/grass.postgresql/d.what.s.pg/getSopts.c
src.garden/grass.postgresql/d.what.s.pg/main.c
src.garden/grass.postgresql/d.what.v.pg/getAllOpts.c
src.garden/grass.postgresql/d.what.v.pg/getCat.c
src.garden/grass.postgresql/d.what.v.pg/getSopts.c
src.garden/grass.postgresql/d.what.v.pg/main.c
src.garden/grass.postgresql/d.what.v.pg/openvect.c
src.garden/grass.postgresql/d.what.v.pg/what.h
src.garden/grass.postgresql/g.column.pg/main.c
src.garden/grass.postgresql/g.select.pg/getdbname.c
src.garden/grass.postgresql/g.select.pg/listdb.c
src.garden/grass.postgresql/g.select.pg/main.c
src.garden/grass.postgresql/g.stats.pg/main.c
src.garden/grass.postgresql/g.table.pg/main.c
src.garden/grass.postgresql/pg.in.dbf/main.c
src.garden/grass.postgresql/pg.in.dbf/pgdump.c
src.garden/grass.postgresql/tutorial/index.html
src.garden/grass.postgresql/v.in.arc.pg/pgdump.c
src.garden/grass.postgresql/v.reclass.pg/dbvect.h
src.garden/grass.postgresql/v.reclass.pg/getAllOpts.c
src.garden/grass.postgresql/v.reclass.pg/getSopts.c
src.garden/grass.postgresql/v.reclass.pg/main.c
src.garden/grass.postgresql/v.to.pg/bsearch.c
src.garden/grass.postgresql/v.to.pg/dbvect.h
src.garden/grass.postgresql/v.to.pg/find.c
src.garden/grass.postgresql/v.to.pg/getAllOpts.c
src.garden/grass.postgresql/v.to.pg/getSopts.c
src.garden/grass.postgresql/v.to.pg/main.c
src.garden/grass.postgresql/v.to.pg/plotCat.c
  Infx -> Pg
  Tidying
  ???

No.

src/CMD/VERSION
  5.0.1 -> 5.0.2-cvs

Change to 5.0.2 for release.

src/CMD/generic/POST_INSTALL.sh
  Improved error message in case of compilation errors

Probably.

src/CMD/generic/gmake.sh
  Allow C++ files (incomplete)

Don't know.

html/html/d.dm.html
src/display/d.dm/d.dm
  Add PNG button
  Fix loading of BWidget package

Don't know.

src/display/d.mon/cmd/main.c
src/display/d.mon/inter/Gmakefile
  Fix exit code
  Remove $(TERMLIB)

Yes.

html/html/d.text.freetype.html
+ src/display/d.text.freetype/vflib/
+ src/display/d.text.freetype/test.input
src/display/d.text.freetype/Gmakefile
src/display/d.text.freetype/freetypecap
src/display/d.text.freetype/main.c
  -rpsc, text=, align=, rotation=
  Command mode
  Add $(MATHLIB)
  Change freetypecap defaults

Probably (d.text.freetype is fairly new).

src/display/d.vect/cmd/main.c
src/display/d.vect/cmd/plot2.c
src/display/d.vect/cmd/plotCat.c
  ???

Don't know.

src/display/d.what.sites/local_proto.h
src/display/d.what.sites/main.c
src/display/d.what.sites/what.c
  ???

Don't know.

html/html/d.what.vect.html
src/display/d.what.vect/cmd/Gmakefile
src/display/d.what.vect/cmd/what.c
src/display/d.what.vect/cmd/what.h
+ src/display/d.what.vect/cmd/flash.c
  ???

Don't know.

src/display/devices/lib/command.c
  Rename eof -> eofile

Yes.

src/display/devices/windows/libW11/w32/xlib.c
  Fix XCreateImage() bytes_per_line == 0 bug (not committed)

Yes (now committed).

html/html/g.mapsets.html
src/general/g.mapsets/main_cmd.c
  addmapset=

Don't know.

src/general/g.region/cmd/printwindow.c
src/mapdev/v.in.gshhs/main.c
src/misc/m.ll2db/main.c
src/raster/r.sun/main.c
src/raster/r.sunmask/g_solposition.c
src/sites/s.datum.shift/main.c
  Don't call pj_zero_proj()

Don't know (related to generalised datum transformations?)

src/general/g.setproj/get_num.c
src/general/g.setproj/local_proto.h
src/general/g.setproj/main.c
  ???

Don't know.

src/general/init/Gmakefile
src/general/init/init.sh
+ src/general/init/license.txt
+ locale/ru/grass_intro.txt
+ locale/ru/license.txt
  I18N (license, grass_intro)

No.

src/general/init/chk_dbase.c
  MINGW32

No.

src/general/init/grass.src
  Trap signals

Don't know.

src/imagery/i.ortho.photo/menu/menu.c
  ???

Don't know.

src/imagery/i.ortho.photo/photo.rectify/write.c
  Error messages

No.

src/include/geo.h
  ???

Don't know.

src/include/gisdefs.h
  color_byg.c

Yes.

  G__getsome
  G_number_of_tokens

Don't know.

src/include/projects.h
  Generalised datum transformations

Don't know.

src/libes/dbmi/drivers/stubs/add_col.c
src/libes/dbmi/drivers/stubs/bindupdate.c
src/libes/dbmi/drivers/stubs/close_cursor.c
  Doxygen comments

Yes.

src/libes/g3d/g3dcache.c
src/libes/g3d/g3dclose.c
src/libes/g3d/g3drange.c
  unlink() -> remove()

Yes.

src/libes/g3d/g3dresample.c
src/libes/g3d/g3dwindow.c
  ??? (AV)

Don't know.

src/libes/gis/Gmakefile
+ src/libes/gis/color_byg.c
+ src/libes/gis/win32_pipes.c
  color_byg
  win32_pipes
  I18N

Yes.

src/libes/gis/datum.table
  ETRS89 comment
  Add "ire65" (Ireland 1965)

Probably.

src/libes/gis/ellipse.table
  Enable "sphere"

Yes.

src/libes/gis/flate.c
  Add zlib URL

Yes.

src/libes/gis/geo_init.c
  ???

Don't know.

src/libes/gis/get_ellipse.c
  Allow e2 (eccentricity-squared) to equal zero (sphere case)
  I18N

Yes.

src/libes/gis/state83
  3200: x_0: 0.6e+06 -> 0.60960122e+06

Probably.

src/libes/gis/token.c
  Add G_number_of_tokens()

Don't know.

src/libes/gis/closecell.c
src/libes/gis/env.c
src/libes/gis/fork.c
src/libes/gis/get_datum_name.c
src/libes/gis/gets.c
src/libes/gis/intr_char.c
src/libes/gis/list.c
src/libes/gis/mapset_msc.c
src/libes/gis/popen.c
src/libes/gis/remove.c
src/libes/gis/set_prior.c
src/libes/gis/system.c
src/libes/gis/unix_socks.c
src/libes/gis/user_config.c
src/libes/gis/whoami.c
  MINGW32

No.

  unlink() -> remove()

Yes (to the extent that it can be separated from the MINGW32 stuff)

  Conditionalise SIGQUIT handling

Sort of (should fix types).

  I18N

Yes.

src/libes/gis/G_dump.c
src/libes/gis/adj_cellhd.c
src/libes/gis/ask.c
src/libes/gis/ask_cell.c
src/libes/gis/auto_mask.c
src/libes/gis/cats.c
src/libes/gis/color_read.c
src/libes/gis/datum.c
src/libes/gis/done_msg.c
src/libes/gis/error.c
src/libes/gis/format.c
src/libes/gis/get_cellhd.c
src/libes/gis/get_datum.c
src/libes/gis/get_ell_name.c
src/libes/gis/get_projinfo.c
src/libes/gis/get_projname.c
src/libes/gis/get_row.c
src/libes/gis/get_window.c
src/libes/gis/gishelp.c
src/libes/gis/gisinit.c
src/libes/gis/histogram.c
src/libes/gis/history.c
src/libes/gis/home.c
src/libes/gis/legal_name.c
src/libes/gis/location.c
src/libes/gis/make_colr.c
src/libes/gis/mapset.c
src/libes/gis/mask_info.c
src/libes/gis/myname.c
src/libes/gis/null_val.c
src/libes/gis/opencell.c
src/libes/gis/parser.c
src/libes/gis/proj2.c
src/libes/gis/proj3.c
src/libes/gis/put_cellhd.c
src/libes/gis/put_row.c
src/libes/gis/put_title.c
src/libes/gis/quant_io.c
src/libes/gis/quant_rw.c
src/libes/gis/range.c
src/libes/gis/rd_cellhd.c
src/libes/gis/readsites.c
src/libes/gis/readsites_xyz.c
src/libes/gis/reclass.c
src/libes/gis/set_window.c
src/libes/gis/timestamp.c
src/libes/gis/view.c
+ locale/ru/LC_MESSAGES/libgis.po
  I18N
  Note: it's possible that some "real" changes were overlooked

Yes.

src/libes/imagery/ls_groups.c
  unlink() -> remove()

Yes.

src/libes/imagery/vask_group.c
  Increase field length 20 -> 30

Don't know.

src/libes/lock/lock.c
src/libes/lock/unlock.c
  MINGW32
  unlink() -> remove()

No.

src/libes/ogsf/GK2.c
src/libes/ogsf/GS2.c
src/libes/ogsf/gk.c
src/libes/ogsf/gpd.c
src/libes/ogsf/gsd_prim.c
src/libes/ogsf/local_proto.h
  ???

Don't know.

src/libes/proj/Gmakefile
src/libes/proj/do_proj.c
src/libes/proj/get_proj.c
- src/libes/proj/datum_shift.c
- src/libes/proj/do_proj_nad.c
  Generalised datum transformations

Don't know.

src/libes/proj/pj_datums.c
src/libes/proj/pj_ellps.c
  Add missing underscores

Don't know.

src/libes/raster/Gmakefile
src/libes/raster/io.c
src/libes/raster/new_io.c
src/libes/raster/parse_mon.c
+ locale/ru/LC_MESSAGES/libraster.po
  I18N

Yes.

  MINGW32
  unlink() -> remove()

No.

src/libes/vask/V_exit.c
src/libes/vask/V_init.c
  include config.h

Yes.

src/libes/vask/V_support.c
src/libes/vect32/Vlib/open1.c
src/libes/vect32/bin_digit/bin_digit.c
src/libes/vect32/georef/bin_point.c
src/libes/vect32/georef/bin_reg.c
src/libes/vect32/georef/set_key.c
src/libes/vect32_64/Vlib/open1.c
  MINGW32
  Conditionalise SIGQUIT handling
  unlink() -> remove()

No/Sort of/Yes (as above).

src/mapdev/v.digit/Gmakefile
src/mapdev/v.digit/ask_driver.c
src/mapdev/v.digit/backdrop.c
src/mapdev/v.digit/bad_areas.c
src/mapdev/v.digit/break.c
src/mapdev/v.digit/build_neat.c
src/mapdev/v.digit/coll_pts.c
src/mapdev/v.digit/color.c
src/mapdev/v.digit/compress.c
src/mapdev/v.digit/contour.c
src/mapdev/v.digit/customize.c
src/mapdev/v.digit/debug.c
src/mapdev/v.digit/dig_curses.c
src/mapdev/v.digit/dig_dev.c
src/mapdev/v.digit/digitize.c
src/mapdev/v.digit/digmain.c
src/mapdev/v.digit/duplicate.c
src/mapdev/v.digit/edit.c
src/mapdev/v.digit/eq.c
src/mapdev/v.digit/find_w_dig.c
src/mapdev/v.digit/find_w_mouse.c
src/mapdev/v.digit/get_point.c
src/mapdev/v.digit/graph_input.c
src/mapdev/v.digit/head_info.c
src/mapdev/v.digit/help.c
src/mapdev/v.digit/initialize.c
src/mapdev/v.digit/interact.c
src/mapdev/v.digit/intersect.c
src/mapdev/v.digit/label.c
src/mapdev/v.digit/label_mult.c
src/mapdev/v.digit/leave.c
src/mapdev/v.digit/list.c
src/mapdev/v.digit/main.c
src/mapdev/v.digit/map_ask.c
src/mapdev/v.digit/map_ask_new.c
src/mapdev/v.digit/map_coor_new.c
src/mapdev/v.digit/map_init_new.c
src/mapdev/v.digit/map_reg.c
src/mapdev/v.digit/map_residnew.c
src/mapdev/v.digit/map_scale.c
src/mapdev/v.digit/menus.c
src/mapdev/v.digit/mk_window.c
src/mapdev/v.digit/mouse_coll.c
src/mapdev/v.digit/mouse_yn.c
src/mapdev/v.digit/move_line.c
src/mapdev/v.digit/move_point.c
src/mapdev/v.digit/node_lines.c
src/mapdev/v.digit/overlay.c
src/mapdev/v.digit/read_cap.c
src/mapdev/v.digit/remove.c
src/mapdev/v.digit/remove_block.c
src/mapdev/v.digit/replot.c
src/mapdev/v.digit/reset_map.c
src/mapdev/v.digit/retype_line.c
src/mapdev/v.digit/scal_window.c
src/mapdev/v.digit/select_digit.c
src/mapdev/v.digit/set_thresh.c
src/mapdev/v.digit/set_window.c
src/mapdev/v.digit/slid_window.c
src/mapdev/v.digit/snap.c
src/mapdev/v.digit/spline.c
src/mapdev/v.digit/toolbox.c
src/mapdev/v.digit/where_am_i.c
src/mapdev/v.digit/window.c
src/mapdev/v.digit/window_rout.c
src/mapdev/v.digit/window_setup.c
src/mapdev/v.digit/withinthresh.c
+ locale/ru/LC_MESSAGES/v.digit.po
  I18N
  Note: it's possible that some "real" changes were overlooked

Probably.

src/mapdev/v.in.dgn/Gmakefile
src/mapdev/v.in.dgn/README
src/mapdev/v.in.dgn/main.c
  ???

Don't know.

src/mapdev/v.label/main.c
  Tidy

Yes.

html/html/m.in.e00.html
src/misc/m.in.e00/info.c
src/misc/m.in.e00/main.c
  list=
  ???

Don't know.

src/misc/m.proj/geo_func.c
src/misc/m.proj/local_proto.h
src/misc/m.proj/main.c
src/misc/m.proj/process.c
src/misc/m.proj2/geo_func.c
src/misc/m.proj2/input.c
src/misc/m.proj2/local_proto.h
src/misc/m.proj2/main.c
src/misc/m.proj2/process.c
  ???

Don't know.

html/html/ps.map.html
src/ps.map/ps.map/cmd/Gmakefile
src/ps.map/ps.map/cmd/colortable.h
src/ps.map/ps.map/cmd/ctablfile.c
src/ps.map/ps.map/cmd/eps.c
src/ps.map/ps.map/cmd/local_proto.h
src/ps.map/ps.map/cmd/ps_area.c
src/ps.map/ps.map/cmd/ps_map.c
src/ps.map/ps.map/cmd/read_cfg.c
src/ps.map/ps.map/cmd/vectfile.c
src/ps.map/ps.map/cmd/vector.h
+ src/ps.map/ps.map/cmd/ps_fclrtbl.c
  (colortable) height
  (vector) pat, pwidth, scale
  Support colour tables for FP maps

Probably.

html/html/r.colors.html
src/raster/r.colors/cmd/main.c
  color=byg

Yes.

src/raster/r.in.gdal/gbgetsymbol.c
src/raster/r.in.gdal/gdalbridge.c
  #ifndef USE_GDAL_H

Yes.

src/raster/r.in.gdal/gdalbridge.h
  GDALGetDriverShortName
  GDALGetDriverLongName
  GDALGetDatasetDriver

Probably.

src/raster/r.in.gdal/main.c
  Remove bogus parm.target->gisprompt setting

Yes.

  AVHRR

Probably.

src/raster/r.mapcalc3/evaluate.c
src/raster/r.mapcalc3/expression.c
src/raster/r.mapcalc3/expression.h
src/raster/r.mapcalc3/map.c
src/raster/r.mapcalc3/mapcalc.h
src/raster/r.mapcalc3/mapcalc.y
  Remove debug output
  Write expression to map history
  Distinguish functions from infix operators
  Change print_* (write to stream) to format_* (convert to string)
  Improve formatting
  Make to_{int,float,double} static (don't export)
  Add missing break statement to column_shift()
  Add missing semicolon to mapcalc.y (for recent versions of bison)

Yes.

html/html/r.neighbors.html
src/tcltkgrass/module/r.neighbors
src/raster/r.neighbors/cmd/Gmakefile
src/raster/r.neighbors/cmd/main.c
src/raster/r.neighbors/cmd/method.h
+ src/raster/r.neighbors/cmd/c_sum.c
  method=sum

Probably.

html/html/r.proj.html
html/html/s.proj.html
html/html/v.proj.html
src/tcltkgrass/module/v.proj
src/raster/r.proj/cmd/bordwalk.c
src/raster/r.proj/cmd/main.c
src/sites/s.proj/main.c
src/mapdev/v.proj/local_proto.h
src/mapdev/v.proj/main.c
  Generalised datum transformations

Don't know.

  Remove m.proj xref

Don't know.

  Fix v.proj tcltkgrass module

Yes.

src/raster/r.sunmask/main.c
  Write history

Probably.

src/raster/r.transect/cmd/main.c
  Fix r.transect invocation

Probably.

src/raster/r.weight/inter/gis_pars.y
  Add missing semicolons (for recent versions of bison)

Yes.

src/scripts/contrib/d.monsize/d.monsize
  XDRIVER_{WIDTH,HEIGHT} -> GRASS_{WIDTH,HEIGHT}

Yes.

src/scripts/contrib/d.rast.labels/d.rast.labels
src/scripts/contrib/i.tm.dehaze/i.tm.dehaze
src/scripts/contrib/r.fillnulls/r.fillnulls
src/scripts/contrib/s.in.atkisdgm/s.in.atkisdgm
src/scripts/contrib/s.in.atkisdgm/s.in.atkisktb
src/scripts/contrib/v.xfig/fig2grass
src/scripts/shells/slide.show.sh
  Remove "function" keyword (bash-ism)

Yes.

src/scripts/contrib/d.rast.leg/d.rast.leg
  ???

Don't know.

src/scripts/contrib/grassmirrorsmap/README
src/scripts/contrib/grassmirrorsmap/grass.sites.main
src/scripts/contrib/grassmirrorsmap/grass.sites.mirror
src/scripts/contrib/grassmirrorsmap/grass_sites.gif
src/scripts/contrib/grassmirrorsmap/grass_sites.htmlmap
src/scripts/contrib/grassmirrorsmap/grassmap.html
src/scripts/contrib/grassmirrorsmap/mkgrassmap.sh
  ???

Don't know.

src/scripts/contrib/i.image.mosaic/i.image.mosaic
  ???

Don't know.

src/scripts/contrib/r.to.pg/r.to.pg
  ???

Don't know.

src/scripts/contrib/r.univar/r.univar
  ???

Don't know.

src/sites/s.surf.rst/main.c
  Remove startup message
  I18N

Yes.

src/tcltkgrass/main/gis_set.tcl
src/tcltkgrass/tcltkgrass
+ locale/ru/tcltkgrass/
  I18N

No.

src/tcltkgrass/main/menu.tcl
  Add d.dm, s.cellstats, r.in.ascii
  Change v.proj description

Probably. BTW, shouldn't there be an interface to r.proj?

html/html/d.legend.html
src/tcltkgrass/module/d.legend
  -o, maxfontsize=

No. But the man page and module *should* reflect the program (d.legend
is now d.leg.thin).

src/tcltkgrass/todo/r.colortool/r.colortool
  Get location info from g.gisenv

Yes.

+ html/html/s.cellstats.html
+ src/sites/s.cellstats/
+ src/tcltkgrass/module/s.cellstats
  Added

+ html/html/s.kernel.html
+ src/sites/s.kernel/
  Added

+ src/raster/r.series/
  Added

+ src.contrib/DUKE/
  Added (r.terraflow)

+ tools/sql.sh
  Added

+ locale/README.koi
+ locale/templates/
  Added

+ src.contrib/GMSL/r.simwe/
  Added

+ src.nonGPL/
  Removed from release branch

Probably.

--
Glynn Clements <glynn.clements@virgin.net>

On Sun, Feb 02, 2003 at 09:13:32PM +0000, Glynn Clements wrote:

> src/general/g.setproj/get_num.c
> src/general/g.setproj/local_proto.h
> src/general/g.setproj/main.c
> ???

Don't know.

2002-08-27 19:19 eric

        * get_num.c, local_proto.h, main.c: Projection code cleanups: *
        changes to reflect changes in geo.h and geo_init.c * copy some
        globals from geo.h back here where they are used.

> src/include/geo.h
> ???

Don't know.

2002-08-27 19:12 eric

        * geo.h: Baby steps to cleaning up projection code: * move
        definition of global structs to geo_init.c * remove/comment
        several globals that shouldn't be here. * Add a couple function
        prototypes for geo_init.c

> src/libes/gis/geo_init.c
> ???

Don't know.

2002-11-10 14:46 eric

        * geo_init.c: Only ask for "south" in UPS. All else is
        predefined...

2002-08-27 19:17 eric

        * geo_init.c: Projection code clean up: * define a couple global
        structs here (rather than geo.h) * eliminate init_units() function
        by making UNITS table defined and intialiazed at compilation (as
        const struct). * make DESC table constant with initializing
        strings paired with corresponding #define symbol from geo.h for
        documentation. * rename functions with G_geo_ prefix to indicate
        gislib membership. * comment out unused variables/functions that
        don't belong in gislib.

Note that these changes were also reflected in some small changes to
[rsv].proj. And those functions have been further modified for the
changes to libproj support for datum transformations. Most of my
changes above aren't really significant changes in functionality, but
the changes need to be kept in sync with the few modules that are
impacted. Mostly I was trying to clean up the interface a little (it
seemed really wrong to me the way global variables were defined in
library units but used *only* by some modules).

--
echo ">gra.fcw@2ztr< eryyvZ .T pveR" | rot13 | reverse

> html/html/d.legend.html
> src/tcltkgrass/module/d.legend
> -o, maxfontsize=

No. But the man page and module *should* reflect the program

I'll get around to fixing these soon ..

(d.legend is now d.leg.thin).

is it? Not knowing the history, I'm a little confused.

from src/display/d.leg.thin/README [which I need to update as well]:
"this is d.legend (formerly d.leg.thin)."

and from src/display/d.legend/Attic/Gmakefile
"FILE REMOVED [...] replaced by d.leg.thin, which becomes d.legend"

so d.legend was replaced by d.leg.thin, which is labeled and runs as
d.legend if I've got that right.

src/display/d.leg.thin builds into d.legend anyway. As the html & tcl
files should match whatever the executable is named, and "d.legend"
seems to me to be a more suitable name for the executable..

I suppose all this is to reduce confusion between the new d.legend [aka
d.leg.thin] and the old [4.3?] d.legend which was a different program???

regards,
Hamish

On Sunday 02 February 2003 10:13 pm, Glynn Clements wrote:
ne.

html/html/d.dm.html
src/display/d.dm/d.dm
       Add PNG button
       Fix loading of BWidget package

Package number of BWidget is important, PNG should be harmless -> yes.

src/display/d.vect/cmd/main.c
src/display/d.vect/cmd/plot2.c
src/display/d.vect/cmd/plotCat.c
       ???

It was bugfix -> yes.

src/mapdev/v.in.dgn/Gmakefile
src/mapdev/v.in.dgn/README
src/mapdev/v.in.dgn/main.c
       ???

Requires dgnlib which is not located by configure -> no.

html/html/ps.map.html
src/ps.map/ps.map/cmd/Gmakefile
src/ps.map/ps.map/cmd/colortable.h
src/ps.map/ps.map/cmd/ctablfile.c
src/ps.map/ps.map/cmd/eps.c
src/ps.map/ps.map/cmd/local_proto.h
src/ps.map/ps.map/cmd/ps_area.c
src/ps.map/ps.map/cmd/ps_map.c
src/ps.map/ps.map/cmd/read_cfg.c
src/ps.map/ps.map/cmd/vectfile.c
src/ps.map/ps.map/cmd/vector.h
+ src/ps.map/ps.map/cmd/ps_fclrtbl.c
       (colortable) height
       (vector) pat, pwidth, scale
       Support colour tables for FP maps

New features which should not break old options -> yes.

On Mon, Feb 03, 2003 at 05:26:08PM +1300, H. Bowman wrote:

> > html/html/d.legend.html
> > src/tcltkgrass/module/d.legend
> > -o, maxfontsize=
>
> No. But the man page and module *should* reflect the program

I'll get around to fixing these soon ..

> (d.legend is now d.leg.thin).

is it? Not knowing the history, I'm a little confused.

from src/display/d.leg.thin/README [which I need to update as well]:
"this is d.legend (formerly d.leg.thin)."

and from src/display/d.legend/Attic/Gmakefile
"FILE REMOVED [...] replaced by d.leg.thin, which becomes d.legend"

so d.legend was replaced by d.leg.thin, which is labeled and runs as
d.legend if I've got that right.

src/display/d.leg.thin builds into d.legend anyway. As the html & tcl
files should match whatever the executable is named, and "d.legend"
seems to me to be a more suitable name for the executable..

I suppose all this is to reduce confusion between the new d.legend [aka
d.leg.thin] and the old [4.3?] d.legend which was a different program???

Once upon a time there were d.legend *and* d.leg.thin (a try for a better
implementation of d.legend). Then I merged both, in fact I merged a few good
pieces of d.legend into d.leg.thin and renamed it in Gmakefile to d.legend
(to avoid user's confusion as a d.leg.thin without d.legend didn't make
sense).
That's why d.legend continued to live in src/display/d.leg.thin (but
in the Gmakefile it is called d.legend).

Yes, a bit confusing. But today only the directory name is confusing.

Hope this clarifies it. In 5.1 we should store it into
display/d.legend

Markus

On Sun, Feb 02, 2003 at 09:13:32PM +0000, Glynn Clements wrote:
[...]

> NEWS.html
> README
> SUBMITTING
> binaryInstall.src
> documents/README_cygwin.html
> documents/cygwin_grass50bininstall.html
> documents/cygwin_grass50compile.html
> documents/debugging.txt
> documents/release_rules.txt
> html/tips_and_tricks.html
> Documentation changes

Probably.

Yes - useful and important updates.

> handheld/babyGRASS_compile.sh
> handheld/babyGRASS_packagingsrc.sh
> Add more modules

Probably.

Yes - nothing dangerous.

> html/html/r.random.cells.html
> html/html/r.random.surface.html
> Fix URLs

Probably.

Yes.

> html/html/r.watershed.html
> xrefs

Probably.

Yes.

> html/html/v.out.shape.html
> -v, -A
> HTML tidying

Probably.

Yes.

> html/index.html
> html/searchhtml.html
> index2.html -> index.html

Don't know.

Yes (index2.html doesn't exist any more on the web)

> html/projections.html
> EPSG link

Probably.

Yes (useful)

> src.contrib/GMSL/NVIZ2.2/doconfigure
> - src.contrib/GMSL/NVIZ2.2/src/query_postgr_dummy.c
> - src.contrib/GMSL/NVIZ2.2/src/query_postgr_orig.c
> Remove query_postgr_{orig,dummy}.c

Don't know.

> src.contrib/GMSL/NVIZ2.2/src/query_postgr.c
> Remove query_postgr_{orig,dummy}.c
> ???

Don't know.

AFAIK this simplifies the PG dependency.
Didn't cause problems here so far.

> src.contrib/GMSL/NVIZ2.2/scripts/fileBrowser.tcl
> Default to cwd instead of $HOME

No; use built-in "pwd" rather than "exec pwd".

Should the suggestion be uploaded?

> src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
> src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
> src.contrib/GMSL/NVIZ2.2/src/anim_support.c
> src.contrib/GMSL/NVIZ2.2/src/change_view.c
> src.contrib/GMSL/NVIZ2.2/src/getCat.c
> src.contrib/GMSL/NVIZ2.2/src/init_commands.c
> src.contrib/GMSL/NVIZ2.2/src/interface.h
> src.contrib/GMSL/NVIZ2.2/src/position.c
> ???

Don't know.

Mostly IRIX fixes from Paul, I think.

> + src.contrib/GMSL/NVIZ2.2/src/README
> HOWTO - Adding new header files from tcl/tk

Probably.

Yes.

> + src.contrib/GMSL/NVIZ2.2/src/tkInt8.4.h
> + src.contrib/GMSL/NVIZ2.2/src/tkIntDecls8.4.h
> Add Tk 8.4 support

Yes (togl.c was already updated in 5.0.1, but these files were missing).

Yes.
  

> src.contrib/GMSL/g3d/src3d/general/g3.region/editcellhd3d.c
> src.contrib/GMSL/g3d/src3d/raster/r3.mapcalc/mapcalc/xcoor.c
> src.contrib/GMSL/g3d/src3d/raster/r3.mapcalc/mapcalc/xrowcol.c
> src.contrib/GMSL/g3d/src3d/raster/r3.null/main.c
> src.contrib/GMSL/g3d/src3d/raster/r3.out.ascii/main.c
> src.contrib/GMSL/g3d/src3d/raster/r3.out.v5d/main.c
> src.contrib/GMSL/g3d/src3d/raster/r3.out.v5d/v5d.h
> src.contrib/GMSL/g3d/src3d/sites/s.vol.idw/main.c
> src.contrib/GMSL/g3d/src3d/sites/s.vol.rst/user1.c
> ??? (AV)

Probably (g3d isn't built by default, so compatibility isn't an issue).

Yes. Only then we can move reasonably forward with G3D (when spreading the
     improvements)

> src.garden/answers/src.answers/raster/README
> Documentation changes

Probably.

Yes.

> src.garden/grass.postgresql/Gmakefile
> Disable v.in.arc.pg

Don't know.

Yes. v.in.arc.pg should not be used, instead
     v.in.shape + pg.in.dbf

> src.garden/grass.postgresql/README
> Documentation changes

Probably.

Yes, reflecting above change.

> src/CMD/VERSION
> 5.0.1 -> 5.0.2-cvs

Change to 5.0.2 for release.

Right.

> src/CMD/generic/POST_INSTALL.sh
> Improved error message in case of compilation errors

Probably.

Yes (just cosmetics). Works well.

> src/CMD/generic/gmake.sh
> Allow C++ files (incomplete)

Don't know.

Wasn't the logic fixed recently?

> html/html/d.text.freetype.html
> + src/display/d.text.freetype/vflib/
> + src/display/d.text.freetype/test.input
> src/display/d.text.freetype/Gmakefile
> src/display/d.text.freetype/freetypecap
> src/display/d.text.freetype/main.c
> -rpsc, text=, align=, rotation=
> Command mode
> Add $(MATHLIB)
> Change freetypecap defaults

Probably (d.text.freetype is fairly new).

IMHO yes.

> src/display/d.vect/cmd/main.c
> src/display/d.vect/cmd/plot2.c
> src/display/d.vect/cmd/plotCat.c
> ???

Don't know.

2002-07-22 15:18 markus

        * src/display/d.vect/cmd/plotCat.c: added missing stdlib.h for atoi

2002-07-17 13:14 radim

        * src/display/d.vect/cmd/: main.c, plot2.c, plotCat.c: fix small
        areas on level1 not plotted

yes.

> src/display/d.what.sites/local_proto.h
> src/display/d.what.sites/main.c
> src/display/d.what.sites/what.c
> ???

Don't know.

This is the flashing sites when selecting a site.
Don't know.

> html/html/d.what.vect.html
> src/display/d.what.vect/cmd/Gmakefile
> src/display/d.what.vect/cmd/what.c
> src/display/d.what.vect/cmd/what.h
> + src/display/d.what.vect/cmd/flash.c
> ???

Don't know.

This is the flashing polygon/line when selecting a vector.
Don't know.

> html/html/g.mapsets.html
> src/general/g.mapsets/main_cmd.c
> addmapset=

Don't know.

Yes, useful & tested.

> src/general/g.region/cmd/printwindow.c
> src/mapdev/v.in.gshhs/main.c
> src/misc/m.ll2db/main.c
> src/raster/r.sun/main.c
> src/raster/r.sunmask/g_solposition.c
> src/sites/s.datum.shift/main.c
> Don't call pj_zero_proj()

Don't know (related to generalised datum transformations?)

related to generalised datum transformations.
What do you think, Paul?

> src/general/init/grass.src
> Trap signals

Don't know.

I have added this to avoid that GRASS continues when the user
hits CTRL-C while defining a new location. I never liked that
GRASS continues and generates a broken new location, when
I try to stop the create-location procedure.

So, IMHO yes.

> src/imagery/i.ortho.photo/menu/menu.c
> ???

Don't know.

This was a try to avoid i.ortho.photo startup crashes.
Better now than before. Not dangerous.

So, IMHO yes.

> src/imagery/i.ortho.photo/photo.rectify/write.c
> Error messages

No.

2002-09-24 14:57 markus

        * src/imagery/i.ortho.photo/photo.rectify/write.c: changed write
        error to strerror(errno) as suggested by Glynn

Is this dangerous? Of yes, it should be also reverted in HEAD.

> src/include/geo.h
> ???

Don't know.

> src/include/gisdefs.h
> color_byg.c

Yes.

> G__getsome
> G_number_of_tokens

Don't know.

G_number_of_tokens is needed by g.mapsets add= and is just a shift
of a function into the library.
G_number_of_tokens(): Yes.

G__getsome: ? no idea

> src/libes/g3d/g3dresample.c
> src/libes/g3d/g3dwindow.c
> ??? (AV)

Don't know.

Yes, when we accept the other G3D changes. I vote for yes.

> src/libes/gis/ellipse.table
> Enable "sphere"

Yes.

Note that "sphere" doesn't seem to work (will have to retry).

> src/libes/gis/geo_init.c
> ???

Don't know.

2002-11-10 23:46 eric

        * src/libes/gis/geo_init.c: Only ask for "south" in UPS. All else
        is predefined...

Eric (maybe already answered in another mail)?

> src/libes/gis/state83
> 3200: x_0: 0.6e+06 -> 0.60960122e+06

Probably.

Eric (maybe already answered in another mail)?

> src/libes/gis/token.c
> Add G_number_of_tokens()

Don't know.

Yes, see above.

> src/libes/imagery/vask_group.c
> Increase field length 20 -> 30

Don't know.

Allow for longer group names. No problems so far.

> src/libes/ogsf/GK2.c
> src/libes/ogsf/GS2.c
> src/libes/ogsf/gk.c
> src/libes/ogsf/gpd.c
> src/libes/ogsf/gsd_prim.c
> src/libes/ogsf/local_proto.h
> ???

Don't know.

2002-11-02 17:39 markus

        * src/libes/ogsf/: GK2.c, GS2.c, gk.c, gpd.c, gsd_prim.c,
        local_proto.h:
        Date: Fri, 18 Oct 2002 12:27:02 -0300 From: Bob Covill
        <bcovill@tekmap.ns.ca> Subject: NVIZ update

The changes are running well here for quite a while.
New fixes/improvements are arriving soon from Bob.

If I am not the only one working with NVIZ from HEAD,
I would say: yes.

> html/html/m.in.e00.html
> src/misc/m.in.e00/info.c
> src/misc/m.in.e00/main.c
> list=
> ???

Don't know.

2002-07-19 22:51 roger

        * src/misc/m.in.e00/: info.c, main.c: Added the list= parameter and
        corrected a format that was invalid for large INFO tables

Don't know as well.

> src/misc/m.proj/geo_func.c
> src/misc/m.proj/local_proto.h
> src/misc/m.proj/main.c
> src/misc/m.proj/process.c
> src/misc/m.proj2/geo_func.c
> src/misc/m.proj2/input.c
> src/misc/m.proj2/local_proto.h
> src/misc/m.proj2/main.c
> src/misc/m.proj2/process.c
> ???

Don't know.

m.proj might be completely taken off if datum transformation is accepted.

m.proj2 fixes are from Eric and Paul.

> src/raster/r.in.gdal/gdalbridge.h
> GDALGetDriverShortName
> GDALGetDriverLongName
> GDALGetDatasetDriver

Probably.

2002-10-07 22:13 glynn

        * src/raster/r.in.gdal/gdalbridge.h: Add declarations for
        GDALGetDriver{Short,Long}Name, GDALGetDatasetDriver [fix submitted
        by Paul Kelly]

IMHO yes.

> src/raster/r.in.gdal/main.c
> Remove bogus parm.target->gisprompt setting

Yes.

> AVHRR

Probably.

Yes.

> html/html/r.neighbors.html
> src/tcltkgrass/module/r.neighbors
> src/raster/r.neighbors/cmd/Gmakefile
> src/raster/r.neighbors/cmd/main.c
> src/raster/r.neighbors/cmd/method.h
> + src/raster/r.neighbors/cmd/c_sum.c
> method=sum

Probably.

Yes (harmless).

> html/html/r.proj.html
> html/html/s.proj.html
> html/html/v.proj.html
> src/tcltkgrass/module/v.proj
> src/raster/r.proj/cmd/bordwalk.c
> src/raster/r.proj/cmd/main.c
> src/sites/s.proj/main.c
> src/mapdev/v.proj/local_proto.h
> src/mapdev/v.proj/main.c
> Generalised datum transformations

Don't know.

Paul

> src/raster/r.sunmask/main.c
> Write history

Probably.

2002-09-24 14:53 markus

        * src/raster/r.sunmask/main.c: added history write functions. But
        long lines are still truncated, we should improve the library
        function

Yes (better than nothing), useful get stored the sun position parameters.

> src/raster/r.transect/cmd/main.c
> Fix r.transect invocation

Probably.

2002-09-24 14:44 markus

        * src/raster/r.transect/cmd/main.c: fixed wrong r.profile call,
        should have gone into 5.0.0

yes.

> src/scripts/contrib/d.rast.leg/d.rast.leg
> ???

Don't know.

Cosmetics to this script.
Yes.

> src/scripts/contrib/grassmirrorsmap/README
> src/scripts/contrib/grassmirrorsmap/grass.sites.main
> src/scripts/contrib/grassmirrorsmap/grass.sites.mirror
> src/scripts/contrib/grassmirrorsmap/grass_sites.gif
> src/scripts/contrib/grassmirrorsmap/grass_sites.htmlmap
> src/scripts/contrib/grassmirrorsmap/grassmap.html
> src/scripts/contrib/grassmirrorsmap/mkgrassmap.sh
> ???

Don't know.

Yes, new mirror sites added.

> src/scripts/contrib/i.image.mosaic/i.image.mosaic
> ???

Don't know.

2002-09-24 14:43 markus

        * src/scripts/contrib/i.image.mosaic/i.image.mosaic: some fixes for
        2 maps composites, needs to be done for 3 and 4 maps - see top of
        file

Yes (better than nothing)

> src/scripts/contrib/r.to.pg/r.to.pg
> ???

Don't know.

2002-10-30 09:51 markus

        * src/scripts/contrib/r.to.pg/r.to.pg: removed the word 'function'
        everywhere (to make scripts cygwin compliant)

2002-08-02 16:59 markus

        * src/scripts/contrib/r.to.pg/r.to.pg: Otto Dassau: cats/ID support
        added

Yes, useful.

> src/scripts/contrib/r.univar/r.univar
> ???

Don't know.

2002-10-30 09:51 markus

        * src/scripts/contrib/r.univar/r.univar: removed the word
        'function' everywhere (to make scripts cygwin compliant)

Yes.

2002-10-23 12:06 markus

        * src/scripts/contrib/r.univar/r.univar: added median, 1st and 3rd
        quartile

No. It slows heavily down the script, so should be discussed first.
In any case a C implementation were much (!) better (maybe based on
s.univar).

> src/tcltkgrass/main/menu.tcl
> Add d.dm, s.cellstats, r.in.ascii
> Change v.proj description

Probably. BTW, shouldn't there be an interface to r.proj?

Yes. Have added interface to r.proj and s.proj now.

> + html/html/s.cellstats.html
> + src/sites/s.cellstats/
> + src/tcltkgrass/module/s.cellstats
> Added
>
> + html/html/s.kernel.html
> + src/sites/s.kernel/
> Added
>
> + src/raster/r.series/
> Added
>
> + src.contrib/DUKE/
> Added (r.terraflow)
>
> + tools/sql.sh
> Added
>
> + locale/README.koi
> + locale/templates/
> Added

All yes.

> + src.contrib/GMSL/r.simwe/
> Added

No (not yet). The authors want to finalize it first.

> + src.nonGPL/
> Removed from release branch
>

Yes.

Markus

On Mon, 3 Feb 2003, Markus Neteler wrote:

On Sun, Feb 02, 2003 at 09:13:32PM +0000, Glynn Clements wrote:
[...]

...

> > src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
> > src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
> > src.contrib/GMSL/NVIZ2.2/src/anim_support.c
> > src.contrib/GMSL/NVIZ2.2/src/change_view.c
> > src.contrib/GMSL/NVIZ2.2/src/getCat.c
> > src.contrib/GMSL/NVIZ2.2/src/init_commands.c
> > src.contrib/GMSL/NVIZ2.2/src/interface.h
> > src.contrib/GMSL/NVIZ2.2/src/position.c
> > ???
>
> Don't know.

Mostly IRIX fixes from Paul, I think.

For some of the files yes that would be the most recent change, but the
bugs I fixed had only been introduced recently so there were other changes by
other people behind those.

> > src/general/g.region/cmd/printwindow.c
> > src/mapdev/v.in.gshhs/main.c
> > src/misc/m.ll2db/main.c
> > src/raster/r.sun/main.c
> > src/raster/r.sunmask/g_solposition.c
> > src/sites/s.datum.shift/main.c
> > Don't call pj_zero_proj()
>
> Don't know (related to generalised datum transformations?)

related to generalised datum transformations.
What do you think, Paul?

Not tested enough yet. These are the modules that use proj but don't need
to do datum transformations. Need further changes in light of Bob's
testing.

I have added this to avoid that GRASS continues when the user
hits CTRL-C while defining a new location. I never liked that
GRASS continues and generates a broken new location, when
I try to stop the create-location procedure.

So, IMHO yes.

But what if someone only wants to start GRASS so they can read the man
pages or use g.help? Or use another command that creates a location, like
r.in.gdal?

> > src/libes/gis/ellipse.table
> > Enable "sphere"
>
> Yes.

Note that "sphere" doesn't seem to work (will have to retry).

What do you mean in particular? I could keep this in mind while I'm
looking over the projection functions, not promising anything though :slight_smile:

> > src/misc/m.proj/geo_func.c
> > src/misc/m.proj/local_proto.h
> > src/misc/m.proj/main.c
> > src/misc/m.proj/process.c
> > src/misc/m.proj2/geo_func.c
> > src/misc/m.proj2/input.c
> > src/misc/m.proj2/local_proto.h
> > src/misc/m.proj2/main.c
> > src/misc/m.proj2/process.c
> > ???
>
> Don't know.

m.proj might be completely taken off if datum transformation is accepted.

m.proj2 fixes are from Eric and Paul.

I didn't change anything in m.proj2 except delete the line from the TODO
file that said a datum is silently ignored.

2002-10-07 22:13 glynn

        * src/raster/r.in.gdal/gdalbridge.h: Add declarations for
        GDALGetDriver{Short,Long}Name, GDALGetDatasetDriver [fix submitted
        by Paul Kelly]

IMHO yes.

This probably should have been on the release branch already.
r.in.gdal doesn't compile on IRIX otherwise.

> > html/html/r.proj.html
> > html/html/s.proj.html
> > html/html/v.proj.html
> > src/tcltkgrass/module/v.proj
> > src/raster/r.proj/cmd/bordwalk.c
> > src/raster/r.proj/cmd/main.c
> > src/sites/s.proj/main.c
> > src/mapdev/v.proj/local_proto.h
> > src/mapdev/v.proj/main.c
> > Generalised datum transformations
>
> Don't know.

Paul

Well [rsv].proj seem to work fairly well but we still need to test a bit
more the other programs that use the proj library (see above). And there
will be further improvements. So if the aim of this is creating a new
ultra-stable release branch none of this should go in. But then it won't
really get tested.

I really like the idea of making releases from HEAD, and if someone
reports a bug we can fix it and tell them to get the next CVS snapshot.
But having stable releases is a good motivation for people to build
binaries for obscure platforms.

Paul

On Mon, Feb 03, 2003 at 05:01:20PM +0000, Paul Kelly wrote:

On Mon, 3 Feb 2003, Markus Neteler wrote:
> On Sun, Feb 02, 2003 at 09:13:32PM +0000, Glynn Clements wrote:

[...]

> I have added this to avoid that GRASS continues when the user
> hits CTRL-C while defining a new location. I never liked that
> GRASS continues and generates a broken new location, when
> I try to stop the create-location procedure.
>
> So, IMHO yes.
>
But what if someone only wants to start GRASS so they can read the man
pages or use g.help? Or use another command that creates a location, like
r.in.gdal?

Maybe my answer was not clear. I was talking about the (rare?) case
that someone hits CTRL-C while generating a new location interactively.
The old behaviour was to leave the coordinate-definition screen and
just enter GRASS (with totally useless PROJ_* files and DEFAULT_WIND
files). As the user (like me) hit CTRL-C, he may want to break the procedure
and leave GRASS.
Now, the create-location procedure is really interrupted if someone hits
CTRL-C.

Hope this explains the idea of the minimal change.

> > > src/libes/gis/ellipse.table
> > > Enable "sphere"
> >
> > Yes.
>
> Note that "sphere" doesn't seem to work (will have to retry).
>

What do you mean in particular? I could keep this in mind while I'm
looking over the projection functions, not promising anything though :slight_smile:

I tried to find a difference when projecting to WGS84 and sphere, there
was none. Maybe I made a mistake, but I didn't try your latest changes
on this problem.

Markus

I have mistakenly emailed this just to Glynn, but some comments from
others would be useful
so I am re-sending it to the list.

Helena

Glynn Clements wrote:

> My comments follow. I'd appreciate comments from the authors of any
> changes marked "Probably" or "Don't know".

> src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
> src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
> src.contrib/GMSL/NVIZ2.2/src/anim_support.c
> src.contrib/GMSL/NVIZ2.2/src/change_view.c
> src.contrib/GMSL/NVIZ2.2/src/getCat.c
> src.contrib/GMSL/NVIZ2.2/src/init_commands.c
> src.contrib/GMSL/NVIZ2.2/src/interface.h
> src.contrib/GMSL/NVIZ2.2/src/position.c
> ???
>>Don't know.

> src/libes/ogsf/GK2.c
> src/libes/ogsf/GS2.c
> src/libes/ogsf/gk.c
> src/libes/ogsf/gpd.c
> src/libes/ogsf/gsd_prim.c
> src/libes/ogsf/local_proto.h
> ???
>>Don't know.

I assume that the above are Bob's improvements and they need some
testing.
We will try this week but getting more people to try it would help.
I have put a copy of Bob's message at the end - testing keyframe
animations may be harder for those who haven't done it before
but testing the large site files is easy and it makes a big difference
if you have million points (e.g. from LIDAR) and want to zoom into
a small place. So if these work they should be included.

> src.contrib/GMSL/g3d/src3d/general/g3.region/editcellhd3d.c
> src.contrib/GMSL/g3d/src3d/raster/r3.mapcalc/mapcalc/xcoor.c
> src.contrib/GMSL/g3d/src3d/raster/r3.mapcalc/mapcalc/xrowcol.c
> src.contrib/GMSL/g3d/src3d/raster/r3.null/main.c
> src.contrib/GMSL/g3d/src3d/raster/r3.out.ascii/main.c
> src.contrib/GMSL/g3d/src3d/raster/r3.out.v5d/main.c
> src.contrib/GMSL/g3d/src3d/raster/r3.out.v5d/v5d.h
> src.contrib/GMSL/g3d/src3d/sites/s.vol.idw/main.c
> src.contrib/GMSL/g3d/src3d/sites/s.vol.rst/user1.c
> ??? (AV)

>>Probably (g3d isn't built by default, so compatibility isn't an issue).

> src/libes/g3d/g3dresample.c
> src/libes/g3d/g3dwindow.c
> ??? (AV)

>>Don't know.

These are probably important fixes by Alfonso Vitti so they should be
included - Alfonso, John Harrop, Jaro, and whoever had a chance to work
with it can
you comment on it?

> + src.contrib/DUKE/
> Added (r.terraflow)
>
> + src.contrib/GMSL/r.simwe/
> Added

>>Probably.

these are new modules - they work but they are being further developed
and could benefit from testing. So they can be included but I suggest
that they are in the same category as the g3d stuff - not being built
by defualt.

Helena

-------------------------------------------------------------------------------
Bob's message:

Hello,

Markus has applied some of my recent NVIZ changes to CVS. These changes
include:

1. Ability to save and load key frame animations.

2. Changes to the DIR[XYZ] keyframe mask to use the center of view in
this field. Now both the eye and center of view can be changed in an
animation.

3. Changes to the "Run and Save" key frame menu to allow user supplied
frame starting numbers. This will allow users to do animations in
sections and start one where the other left off (for example at frame
no. 1051). The numbers are also formatted to 4 digits to allow
compatibility with the gimp animation tool. Note that the "off-screen"
option is disabled in this menu (see below).

4. Accelerated drawing of sites by skipping sites outside of the current
viewport. This routine can be applied at a later date to vectors and
rasters.

5. Changed near and far clip defaults to allow closer and farther views
respectively without being clipped.

6. Added a new display canvas for interactively moving the center of
view (similar to "look here"). This and the eye position canvas are
activated by radiobuttons. The canvases include call-backs to get and
set the canvas cursor to match the respective
position.

7. The code for off-screen rendering is also included, but commented
out. The off-screen rendering draws to off-screen pbuffers, thus
allowing rendering to be done undisturbed by screen savers, other
windows, etc. This routine is still fairly new and requires a bit more
work. For those wishing to try the off-screen rendering use a compile
flag #define OS_RENDER to build the ogsf library and nvwish. The version
is compatible with GLX v.1.3, earlier versions will probably not work.
To enable off-screen rendering use "Noff_screen 1". When finished use
"Noff_screen 0" to destroy the pbuffer visual. Note that the togl window
should be minimized before calling Noff_screen 1. This ensures that the
pbuffer remains the currently selected visual.

If you have any question, comments or problems with the above please let
me know.

Also, for those interested I have got a good portion of the 3dview stuff
working in nviz. This is the saving and loading of 3d views. If anyone
is interested in testing what I have so far, please let me know.

Markus Neteler wrote:

> > html/index.html
> > html/searchhtml.html
> > index2.html -> index.html
>
> Don't know.

Yes (index2.html doesn't exist any more on the web)

If the URLs are meant to refer to the GRASS website, they should be
absolute URLs. Bear in mind that these files are installed into
$GISBASE/documents; relative URLs should only be used when the target
is also in $GISBASE/documents.

I think that I was getting confused with the following (from
html/index.html):

  <a href="../nviz/index.html">nviz visualization tool tutorial</A>

This URL is wrong for a local copy of index.html (".." doesn't make
any sense from the top-level directory); it should be:

  <a href="nviz/index.html">nviz visualization tool tutorial</A>

If the GRASS website is layed out differently, then the file should be
pre-processed for use on the web site.

> > src.contrib/GMSL/NVIZ2.2/doconfigure
> > - src.contrib/GMSL/NVIZ2.2/src/query_postgr_dummy.c
> > - src.contrib/GMSL/NVIZ2.2/src/query_postgr_orig.c
> > Remove query_postgr_{orig,dummy}.c
>
> Don't know.
>
> > src.contrib/GMSL/NVIZ2.2/src/query_postgr.c
> > Remove query_postgr_{orig,dummy}.c
> > ???
>
> Don't know.

AFAIK this simplifies the PG dependency.
Didn't cause problems here so far.

The doconfigure simplification is good; however, there appear to be
some other changes which I'm unsure about.

> > src.contrib/GMSL/NVIZ2.2/scripts/fileBrowser.tcl
> > Default to cwd instead of $HOME
>
> No; use built-in "pwd" rather than "exec pwd".

Should the suggestion be uploaded?

I think so.

> > src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
> > src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
> > src.contrib/GMSL/NVIZ2.2/src/anim_support.c
> > src.contrib/GMSL/NVIZ2.2/src/change_view.c
> > src.contrib/GMSL/NVIZ2.2/src/getCat.c
> > src.contrib/GMSL/NVIZ2.2/src/init_commands.c
> > src.contrib/GMSL/NVIZ2.2/src/interface.h
> > src.contrib/GMSL/NVIZ2.2/src/position.c
> > ???
>
> Don't know.

Mostly IRIX fixes from Paul, I think.

I think that most of this (along with the ogsf changes) was a
substantial update from Bob Covill.

> > src/CMD/generic/gmake.sh
> > Allow C++ files (incomplete)
>
> Don't know.

Wasn't the logic fixed recently?

It was "fixed" so as to be harmless (the first attempt broke the case
when the .c file was generated, e.g. by lex/yacc). However, it's far
from correct: C++ files should use $(CXX) instead of $(CC), and
$(CXXFLAGS) instead of $(CFLAGS). This would require changes to
several other files (configure[.in], head.in).

See my previous message:

  From: Glynn Clements <glynn.clements@virgin.net>
  Subject: Re: [GRASS5] C++ compilation
  Date: Thu, 23 Jan 2003 21:43:40 +0000
  Message-ID: <15920.25100.848724.42087@cerise.nosuchdomain.co.uk>

> > src/general/g.region/cmd/printwindow.c
> > src/mapdev/v.in.gshhs/main.c
> > src/misc/m.ll2db/main.c
> > src/raster/r.sun/main.c
> > src/raster/r.sunmask/g_solposition.c
> > src/sites/s.datum.shift/main.c
> > Don't call pj_zero_proj()
>
> Don't know (related to generalised datum transformations?)

related to generalised datum transformations.
What do you think, Paul?

Paul says not yet, so no.

> > src/general/init/grass.src
> > Trap signals
>
> Don't know.

I have added this to avoid that GRASS continues when the user
hits CTRL-C while defining a new location. I never liked that
GRASS continues and generates a broken new location, when
I try to stop the create-location procedure.

So, IMHO yes.

Doesn't this belong in Init.sh, then? That's where the code in
question is.

> > src/imagery/i.ortho.photo/photo.rectify/write.c
> > Error messages
>
> No.

2002-09-24 14:57 markus

        * src/imagery/i.ortho.photo/photo.rectify/write.c: changed write
        error to strerror(errno) as suggested by Glynn

Is this dangerous? Of yes, it should be also reverted in HEAD.

Two issues: Regarding the first message, I don't know how portable
strerror() is; older BSDs don't have it.

Regarding the second, the message is over 80 characters; also, you
could reasonably argue for adding the same message to every module
which writes files (i.e. most modules), which is really an argument
for putting it lower down. Also, permissions definitely aren't an
issue, as they are checked upon open and not upon write.

> > G__getsome
> > G_number_of_tokens
>
> Don't know.

G_number_of_tokens is needed by g.mapsets add= and is just a shift
of a function into the library.
G_number_of_tokens(): Yes.

OK.

> > src/libes/gis/ellipse.table
> > Enable "sphere"
>
> Yes.

Note that "sphere" doesn't seem to work (will have to retry).

Please do.

> > src/libes/imagery/vask_group.c
> > Increase field length 20 -> 30
>
> Don't know.

Allow for longer group names. No problems so far.

OK, then yes.

--
Glynn Clements <glynn.clements@virgin.net>

Glynn Clements wrote:

> src.contrib/GMSL/NVIZ2.2/scripts/fileBrowser.tcl
> Default to cwd instead of $HOME

No; use built-in "pwd" rather than "exec pwd".

Yes we can do this (see below).

> src.contrib/GMSL/NVIZ2.2/scripts/panel_kanimator.tcl
> src.contrib/GMSL/NVIZ2.2/scripts/panel_main.tcl
> src.contrib/GMSL/NVIZ2.2/src/anim_support.c
> src.contrib/GMSL/NVIZ2.2/src/change_view.c
> src.contrib/GMSL/NVIZ2.2/src/getCat.c
> src.contrib/GMSL/NVIZ2.2/src/init_commands.c
> src.contrib/GMSL/NVIZ2.2/src/interface.h
> src.contrib/GMSL/NVIZ2.2/src/position.c
> ???

Don't know.

> src/libes/ogsf/GK2.c
> src/libes/ogsf/GS2.c
> src/libes/ogsf/gk.c
> src/libes/ogsf/gpd.c
> src/libes/ogsf/gsd_prim.c
> src/libes/ogsf/local_proto.h
> ???

Don't know.

The above changes (GMSL & ogsf) are probably what Markus applied for me
(exception of getCat.c) to implement accelerated surface and sights
drawing, enhanced animation tools, etc. Markus is currently checking a
"cleaned up" version of these, before applying I will fix the
fileBrowser.tcl as noted above.

--
Bob Covill

Tekmap Consulting
P.O. Box 2016
Fall River, N.S.
B2T 1K6
Canada

E-Mail: bcovill@tekmap.ns.ca
Phone: 902-860-1496
Fax: 902-860-1498

Paul Kelly wrote:

> 2002-10-07 22:13 glynn
>
> * src/raster/r.in.gdal/gdalbridge.h: Add declarations for
> GDALGetDriver{Short,Long}Name, GDALGetDatasetDriver [fix submitted
> by Paul Kelly]
>
> IMHO yes.

This probably should have been on the release branch already.
r.in.gdal doesn't compile on IRIX otherwise.

AFAICT, this part is tied to the changes which I labelled "AVHRR" for
src/raster/r.in.gdal/main.c. Both sets of changes have to be made
together, otherwise it won't compile on anything (unless you use
--with-gdal).

The IRIX-specific problem was due to:

  #if defined(__unix__)

This has since been changed to:

  #if defined(__unix) || defined(__unix__)

This change made it into 5.0.0.

I'll leave the projection stuff out for now.

--
Glynn Clements <glynn.clements@virgin.net>

Markus Neteler wrote:

> > > > src/libes/gis/ellipse.table
> > > > Enable "sphere"
> > >
> > > Yes.
> >
> > Note that "sphere" doesn't seem to work (will have to retry).
> >
>
> What do you mean in particular? I could keep this in mind while I'm
> looking over the projection functions, not promising anything though :slight_smile:

I tried to find a difference when projecting to WGS84 and sphere, there
was none. Maybe I made a mistake, but I didn't try your latest changes
on this problem.

This sounds as if the ellipsoid is simply being ignored, rather than a
problem specific to "sphere".

The most likely problem with a sphere is a division by zero if
something tries to divide by either the eccentricity or flattening.

--
Glynn Clements <glynn.clements@virgin.net>

On Mon, 3 Feb 2003 14:44:12 +0100
"Markus Neteler" <neteler@itc.it> wrote:

> > src/scripts/contrib/d.rast.leg/d.rast.leg
> > ???
>
> Don't know.

Cosmetics to this script.
Yes.

actually, probably not. It's broken for non-FP rasters right now due to the -o flag (which never made it out of HEAD) becoming -n, but it seems to have some related logic problems as well.

I wasn't aware this script existed until now, but will see what I can whip up.

Hamish

On Mon, Feb 03, 2003 at 08:17:28PM +0000, Glynn Clements wrote:

> 2002-09-24 14:57 markus
>
> * src/imagery/i.ortho.photo/photo.rectify/write.c: changed write
> error to strerror(errno) as suggested by Glynn
>
> Is this dangerous? Of yes, it should be also reverted in HEAD.

Two issues: Regarding the first message, I don't know how portable
strerror() is; older BSDs don't have it.

strerror has been around for some time: documented in K&R 2 (1988) and
is ANSI C. If it becomes an issue, add a macro.

#if !defined(HAS_STRERROR)
#define strerror(e) "??!??'??>"
#endif

Okay, maybe no trigraphs... |^}

--
echo ">gra.fcw@2ztr< eryyvZ .T pveR" | rot13 | reverse

On Mon, Feb 03, 2003 at 08:17:28PM +0000, Glynn Clements wrote:

Markus Neteler wrote:

> > > html/index.html
> > > html/searchhtml.html
> > > index2.html -> index.html
> >
> > Don't know.
>
> Yes (index2.html doesn't exist any more on the web)

If the URLs are meant to refer to the GRASS website, they should be
absolute URLs. Bear in mind that these files are installed into
$GISBASE/documents; relative URLs should only be used when the target
is also in $GISBASE/documents.

I think that I was getting confused with the following (from
html/index.html):

  <a href="../nviz/index.html">nviz visualization tool tutorial</A>

This URL is wrong for a local copy of index.html (".." doesn't make
any sense from the top-level directory); it should be:

  <a href="nviz/index.html">nviz visualization tool tutorial</A>

If the GRASS website is layed out differently, then the file should be
pre-processed for use on the web site.

I agree that the current file organization is a bit messy.
If someone updates the docs as desired/proposed, I'll fix the cronjobs
on grass.itc.it subsequently.

> > > src/CMD/generic/gmake.sh
> > > Allow C++ files (incomplete)
> >
> > Don't know.
>
> Wasn't the logic fixed recently?

It was "fixed" so as to be harmless (the first attempt broke the case
when the .c file was generated, e.g. by lex/yacc). However, it's far
from correct: C++ files should use $(CXX) instead of $(CC), and
$(CXXFLAGS) instead of $(CFLAGS). This would require changes to
several other files (configure[.in], head.in).

See my previous message:

  From: Glynn Clements <glynn.clements@virgin.net>
  Subject: Re: [GRASS5] C++ compilation
  Date: Thu, 23 Jan 2003 21:43:40 +0000
  Message-ID: <15920.25100.848724.42087@cerise.nosuchdomain.co.uk>

Ok, but if harmless we could upload it to enable people to compile
r.terraflow.

> > > src/general/init/grass.src
> > > Trap signals
> >
> > Don't know.
>
> I have added this to avoid that GRASS continues when the user
> hits CTRL-C while defining a new location. I never liked that
> GRASS continues and generates a broken new location, when
> I try to stop the create-location procedure.
>
> So, IMHO yes.

Doesn't this belong in Init.sh, then? That's where the code in
question is.

Maybe. But it already works. So probably we should add is additionally
to Init.sh?

The line in question is:

trap "echo 'User break!' ; exit" 2 3 9 15

> > > src/imagery/i.ortho.photo/photo.rectify/write.c
> > > Error messages
> >
> > No.
>
> 2002-09-24 14:57 markus
>
> * src/imagery/i.ortho.photo/photo.rectify/write.c: changed write
> error to strerror(errno) as suggested by Glynn
>
> Is this dangerous? Of yes, it should be also reverted in HEAD.

Two issues: Regarding the first message, I don't know how portable
strerror() is; older BSDs don't have it.

Regarding the second, the message is over 80 characters; also, you
could reasonably argue for adding the same message to every module
which writes files (i.e. most modules), which is really an argument
for putting it lower down. Also, permissions definitely aren't an
issue, as they are checked upon open and not upon write.

Ok, sounds as if it should be reverted.

> > > src/libes/gis/ellipse.table
> > > Enable "sphere"
> >
> > Yes.
>
> Note that "sphere" doesn't seem to work (will have to retry).

Please do.

Will do.

Markus

Markus Neteler wrote:

> > > > src/general/init/grass.src
> > > > Trap signals
> > >
> > > Don't know.
> >
> > I have added this to avoid that GRASS continues when the user
> > hits CTRL-C while defining a new location. I never liked that
> > GRASS continues and generates a broken new location, when
> > I try to stop the create-location procedure.
> >
> > So, IMHO yes.
>
> Doesn't this belong in Init.sh, then? That's where the code in
> question is.

Maybe. But it already works. So probably we should add is additionally
to Init.sh?

Actually, I can't see how this is meant to work. A "trap" command only
affects the signal handling of the shell itself; signal handlers are
reset when spawning a child process.

BTW, bash seems to have some "magic" in the way that it handles
terminal signals. When you press (by default) Ctrl-C, the terminal
driver sends SIGINT to all processes in the foreground process group
(this will consist of grass5, Init.sh, and anything called from
Init.sh). If a child process traps the signal and returns normally,
bash ignores the signal; OTOH, if the child process dies on the
signal, bash allows the signal to be processed (i.e. calling the
handler specified by "trap", or dying if no handler was installed).

OTOH, ash doesn't do this, and it's quite possible that other shells
won't. The way in which bash behaves isn't necessarily a good
indicator of how Bourne shells behave generally.

More generally, the grass5 script should probably be reduced to just:

  #!/bin/sh
  GISBASE=/opt/grass5
  export GISBASE
  exec "$GISBASE/etc/Init.sh" "$@"

with everything else moved to Init.sh. This would allow for invoking
grass5 with an argument which contains spaces (this won't work at
present, due to the way in which Init.sh is invoked). It also uses one
less process.

There's also the issue that, even if Init.sh handles set_data being
killed, set_data will still leave a broken location behind. That can't
be fixed in Init.sh; it would have to be fixed in set_data.

--
Glynn Clements <glynn.clements@virgin.net>

An updated version is attached. This reflects the situation after the
recent sync; that consisted of whole-file changes, i.e. new files, or
files which were replaced by the version from the CVS head.

The remaining differences correspond to cases where one or more of the
following apply:

1. The author advised against inclusion.

2. I advised against inclusion.

3. The significance of the change isn't immediately obvious, and
   nobody specifically recommended inclusion.

4. There are multiple changes to a single file, and at least one of
   the changes is subject to 1-3 above.

5. The change was made since the merge.

Some of these may yet make it into 5.0.2, mostly depending upon
someone being willing to advocate inclusion.

--
Glynn Clements <glynn.clements@virgin.net>

(attachments)

grass-diff.txt (11.4 KB)

On Wed, Feb 12, 2003 at 10:41:23AM +0000, Glynn Clements wrote:
Content-Description: message body and .signature

An updated version is attached. This reflects the situation after the
recent sync; that consisted of whole-file changes, i.e. new files, or
files which were replaced by the version from the CVS head.

Thanks for your efforts, Glynn!

[...]

- html/html/v.rm.dangles.html
  Removed

html/vector.html
  Remove v.rm.dangles xref

The both above may go into 5.0.2. It simply fixes the problem
that the man page was not written earlier.

html/html/d.vect.pg.html
  -e

html/html/r.fillnulls.html
html/html/r.flow.html
html/html/r.flowmd.html
html/html/s.surf.rst.html
html/html/s.vol.rst.html
html/html/v.surf.rst.html
  Change URLs (NCSU -> UIUC)

The old server is dead. That's why the updated urls should
reach 5.0.2.

html/html/r.out.ascii.html
  -M -> -s
  ASCII -> binary
  input -> inout
  ??? this doesn't appear to make sense, or agree with the source code

In my HEAD version I have
r.out.ascii help

Description:
Converts a raster map layer into an ASCII text file.

Usage:
r.out.ascii [-hsMi] input=name [output=name] [dp=value] [width=value]
   [null=name]

Flags:
  -h Suppress printing of header information
  -s Write SURFER (Golden Software) ASCII grid
  -M Write MODFLOW (USGS) ASCII array
  -i Force output of integer values

Parameters:
   input Name of an existing raster map
  output Name of an output ASCII grid map (use out=- for stdout)
      dp Number of significant digits (floating point only)
   width Number of values printed before wrapping a line
    null String to represent null cell (GRASS grid only)
           default: *

And
html/html/r.out.ascii.html
reflects this (since some days) [another reason to use G_usage_html()].

html/index.html
html/searchhtml.html
  index2.html -> index.html

Why not? The page index2.html doesn't exist any more.

[...]

src/tcltkgrass/module/v.proj
  Fix v.proj tcltkgrass module

I vote for yes.

src/mapdev/v.in.dgn/Gmakefile
src/mapdev/v.in.dgn/README
src/mapdev/v.in.dgn/main.c
  ???

This was requested a few times on the user list, maybe we can
add it.

html/html/m.in.e00.html
src/misc/m.in.e00/info.c
src/misc/m.in.e00/main.c
  list=
  ???

...Roger Miller, if I recall correctly.

src/scripts/contrib/r.univar/r.univar
  ???

I vote for no.

html/html/d.legend.html
src/tcltkgrass/module/d.legend
  -o, maxfontsize=

Being author of -o, maxfontsize=, I vote for eliminating them.
The module is in hands of Hamish Bowman now.
So: yes.

[...]

Markus