[GRASS5] GRASS 5.0.0stable to be released soonish

[neteler]

Hi developers,

since all release critical bugs are fixed, we should release
GRASS 5.0.0stable now.

For that we can use the existing pre4 branch. Maybe Glynn could
check if any important change was not submitted to (post-)pre4
branch?

Let's go ahead, we had a long testing phase for pre4 and discovered
only a few (fixed) bugs.

Markus

[Bernhard_Reiter]

On Wed, Jun 05, 2002 at 03:57:53PM +0200, Markus Neteler wrote:

since all release critical bugs are fixed, we should release
GRASS 5.0.0stable now.

The plan is to do this around the 13th, which is about one
month after we have released pre4.

Thus yes, we should start preparing the 5.0.0 release.
(no need to add "stable" as a prefix.)

For that we can use the existing pre4 branch. Maybe Glynn could
check if any important change was not submitted to (post-)pre4
branch?

If we have changes, we could make a pre5 from this release branch
and then rerelease this a few weeks later.

Let's go ahead, we had a long testing phase for pre4 and discovered
only a few (fixed) bugs.

Okay, if you think that this is the case
as a release assistant I'm agreeing with you and think that
5.0.0 would be fine somewhere next week.

  Bernhard

[Glynn_Clements]

Markus Neteler wrote:

since all release critical bugs are fixed, we should release
GRASS 5.0.0stable now.

Are we sure that all of the PROJ issues are now fixed?

--
Glynn Clements <glynn.clements@virgin.net>

[neteler]

On Wed, Jun 05, 2002 at 08:09:03PM +0200, Bernhard Reiter wrote:

On Wed, Jun 05, 2002 at 03:57:53PM +0200, Markus Neteler wrote:
> since all release critical bugs are fixed, we should release
> GRASS 5.0.0stable now.

The plan is to do this around the 13th, which is about one
month after we have released pre4.

Thus yes, we should start preparing the 5.0.0 release.
(no need to add "stable" as a prefix.)

> For that we can use the existing pre4 branch. Maybe Glynn could
> check if any important change was not submitted to (post-)pre4
> branch?

If we have changes, we could make a pre5 from this release branch
and then rerelease this a few weeks later.

However, we have to take care not to run into a never-ending story here.
It will never be bug-free, so one day (very soon) it must be the final
5.0.0 release. Radim needs urgently help for 5.1 (and many of you do not
want to miss the new features already implemented).

> Let's go ahead, we had a long testing phase for pre4 and discovered
> only a few (fixed) bugs.

Okay, if you think that this is the case
as a release assistant I'm agreeing with you and think that
5.0.0 would be fine somewhere next week.

  Bernhard

Markus

[neteler]

On Wed, Jun 05, 2002 at 07:11:51PM +0100, Glynn Clements wrote:

Markus Neteler wrote:

> since all release critical bugs are fixed, we should release
> GRASS 5.0.0stable now.

Are we sure that all of the PROJ issues are now fixed?

So far I have tested many hours (and posted a lot). I kindly invite
others to test the current HEAD. To me it looks functional again.

Markus

[Morten_Hulden1]

On Thu, 6 Jun 2002, Markus Neteler wrote:

On Wed, Jun 05, 2002 at 07:11:51PM +0100, Glynn Clements wrote:
>
> Markus Neteler wrote:
>
> > since all release critical bugs are fixed, we should release
> > GRASS 5.0.0stable now.
>
> Are we sure that all of the PROJ issues are now fixed?

So far I have tested many hours (and posted a lot). I kindly invite
others to test the current HEAD. To me it looks functional again.

The r.proj version I got from the CVS has a lot of anonymous changes since
last time I looked (april_11_release). Basically the bordwalk.c calls have
beeen disabled, which nullifies almost all of the changes made in August
2000. The whole input map will now be loaded into memory, region
sensitivity is no longer there etc

Comments at the beginning of main.c are now misleading, most of the
improvements from Aug 2000 are gone ...

Morten Hulden

[Glynn_Clements]

Markus Neteler wrote:

since all release critical bugs are fixed, we should release
GRASS 5.0.0stable now.

For that we can use the existing pre4 branch. Maybe Glynn could
check if any important change was not submitted to (post-)pre4
branch?

OK, I'll look into it. However, 257 files differ between pre4 and the
head, so it may take a while to check everything.

--
Glynn Clements <glynn.clements@virgin.net>

[Glynn_Clements]

Glynn Clements wrote:

> since all release critical bugs are fixed, we should release
> GRASS 5.0.0stable now.
>
> For that we can use the existing pre4 branch. Maybe Glynn could
> check if any important change was not submitted to (post-)pre4
> branch?

OK, I'll look into it. However, 257 files differ between pre4 and the
head, so it may take a while to check everything.

Fortunately, many of them correspond to bulk changes.

The following is a brief summary of the differences between pre4 and
the current state of the head. Files or changes which are preceded by
an asterisk have already been committed to the release branch.

For the remaining changes, I would appreciate opinions as to which
should be included in the next release. I'll submit my opinions in a
follow-up.

Also, if any fundamental changes are to be included (e.g. the libgis
I18N), we should consider labelling the next release as "pre5" rather
than "final".

--
Glynn Clements <glynn.clements@virgin.net>

Added directories

locale/ru/tcltkgrass
src/display/d.text.freetype/vflib

Added Files

locale/ru/LC_MESSAGES/libgis.po
  libgis I18N

locale/ru/grass_intro.txt
locale/ru/license.txt
src/general/init/license.txt
  Init.sh I18N

src/libes/proj/PJ_krovak.c
src/libes/proj/PJ_krovakgis.c
  krovak[gis] addition

src/display/d.text.freetype/test.input
  d.text.freetype command mode

Changed Files

AUTHORS
  re-format long lines

NEWS.html
  updated

documents/debugging.txt
  comment re: -W[error-]implicit-function-declaration
  add section 6: Debugging with 'core' file

documents/release_rules.txt
  updated

handheld/babyGRASS_compile.sh
handheld/babyGRASS_packagingsrc.sh
  add g.mapsets

SUBMITTING
  header ordering

Makefile.in
  handling of "locale" subdirectory

configure
configure.in
  readline
  Darwin iconv check
  Darwin PostgreSQL (-lssl -lcrypto)

* documents/cygwin_grass50bininstall.html
  sunrpc library

html/Gmakefile
  [ -> test
  mkdir -> mkdir -p

html/html/d.his.html
  -n flag

* html/html/d.rast.pg.html
* html/html/d.site.pg.html
* html/html/d.what.r.pg.html
* html/html/d.what.s.pg.html
* html/html/d.what.v.pg.html
* html/html/g.column.pg.html
* html/html/g.select.pg.html
* html/html/g.stats.pg.html
* html/html/g.table.pg.html
* html/html/pg.in.dbf.html
  koi8-r -> iso-8859-1

html/html/d.vect.pg.html
* koi8-r -> iso-8859-1
  -e flag

* html/html/v.reclass.pg.html
  koi8-r -> iso-8859-1
  fix postgresql.org URL

* html/html/v.to.pg.html
  koi8-r -> iso-8859-1
  -p flag
  PostGIS
  change xrefs

html/html/d.text.freetype.html
  -rpsc flags
  align=, rotation=
  Command mode

html/html/dcorrelate.sh.html
  mention "scattergram"

html/html/i.rectify.html
  comment regarding write errors

html/html/i.in.erdas.html
  r.in.gdal xref
  authors

* html/html/m.datum.shift.html
html/html/s.in.garmin.sh.html
  change xrefs

html/html/pngdriver.html
  default background is black

html/html/r.his.html
  -n flag

* html/html/r.runoff.html
  G-language -> GRASS raster command

html/html/s.in.ascii.html
  Time as String Attributes

* html/html/s.vol.rst.html
  references

html/html/s.what.html
  Add mailto: link

html/html/v.in.garmin.sh.html
* gps -> GPS
  change xrefs

html/html/v.in.shape.html
  -d flag

html/index.html
* update search URL
  update mailto: link

html/projections.html
  add URLs

html/raster.html
  remove xrefs

* html/searchhtml.html
  update search URL

html/tips_and_tricks.html
  Add comment re: .cshrc

locale/Gmakefile
  process all locales, not $LANG
  add tcltkgrass, textintro targets

locale/ru/LC_MESSAGES/d.vect.pg.po
locale/ru/LC_MESSAGES/v.to.pg.po

mk/Makefile.in
  add "locale" subdirectory to "dirs" target
  generate more complex "gmake5" script

mk/mid.mk
mk/mid.mk.shlib
  add LOCALE definition

mk/mkmakefiles
  optional directory argument

src.contrib/GMSL/SG3d/README
src.contrib/GMSL/sg4d/README
  mention Ygl

src.garden/grass.hdf/hdf5/r.in.hdf/README
  mention HDF-EOS

src.garden/grass.hdf/hdf5/r.in.hdf/r.in.hdf.c
  ???

src.garden/grass.postgresql/d.vect.pg/dbvect.h
src.garden/grass.postgresql/d.vect.pg/getAllOpts.c
src.garden/grass.postgresql/d.vect.pg/getSopts.c
src.garden/grass.postgresql/d.vect.pg/main.c
src.garden/grass.postgresql/d.vect.pg/runInfxFile.c
  -e (extract) flag

src.garden/grass.postgresql/v.to.pg/dbvect.h
src.garden/grass.postgresql/v.to.pg/getAllOpts.c
src.garden/grass.postgresql/v.to.pg/getSopts.c
src.garden/grass.postgresql/v.to.pg/main.c
src.garden/grass.postgresql/v.to.pg/plotCat.c
src.garden/grass.postgresql/v.to.pg/runInfxFile.c
  -p (postgis) flag

* src/CMD/generic/GISGEN.sh
  "locale" subdirectory

src/CMD/generic/make.mid
  define LOCALE (currently unused)

src/CMD/head/head.in
  readline variables

src/display/d.3d/Dmain.c
src/display/d.3d/check_opt.c
src/display/d.3d/command.c
src/display/d.area/main.c
src/display/d.area/screenpoly.c
src/display/d.barscale/cmd/main.c
src/display/d.barscale/cmd/mouse.c
src/display/d.colormode/cmd/main.c
src/display/d.colors/get_info.c
src/display/d.colortable/cmd/main.c
src/display/d.db/main.c
src/display/d.extend/cmd/main.c
src/display/d.font/cmd/main.c
src/display/d.frame/cmd/create.c
src/display/d.frame/cmd/dumper.c
src/display/d.frame/cmd/select.c
src/display/d.geodesic/cmd/main.c
src/display/d.graph/cmd/allocation.c
src/display/d.graph/cmd/main.c
src/display/d.grid/cmd/main.c
src/display/d.histogram/cmd/get_stats.c
src/display/d.icons/cmd/main.c
src/display/d.label/cmd/main.c
src/display/d.leg.thin/main.c
src/display/d.mapgraph/cmd/main.c
src/display/d.menu/cmd/main.c
src/display/d.mon/pgms/release.c
src/display/d.mon/pgms/start.c
src/display/d.mon/pgms/stop.c
src/display/d.mouse/main.c
src/display/d.pan/main.c
src/display/d.points/cmd/main.c
src/display/d.profile/What.c
src/display/d.profile/main.c
src/display/d.rast/cmd/display.c
src/display/d.rast/cmd/main.c
src/display/d.rhumbline/cmd/main.c
src/display/d.sites.qual/cmd/main.c
src/display/d.sites/cmd/main.c
src/display/d.title/cmd/main.c
src/display/d.vect.labels/main.c
src/display/d.vect/cmd/main.c
src/display/d.what.db/main.c
src/display/d.what.vect/cmd/attr.c
src/display/d.what.vect/cmd/main.c
src/display/d.where/cmd/main.c
src/display/d.zoom/cmd/main.c
src/general/g.gisenv/main.c
src/general/g.help/main.c
src/general/g.help/menu.c
src/general/g.manual/cmd/main.c
src/general/g.manual/inter/main.c
src/general/g.mapsets/dsply_path.c
src/general/g.mapsets/main_cmd.c
src/general/g.parser/main.c
src/general/g.region/cmd/main.c
src/general/g.region/cmd/printwindow.c
src/general/g.region/cmd/zoom.c
src/general/g.region/inter/main.c
src/general/g.setproj/main.c
src/general/init/lock.c
src/general/manage/cmd/copy.c
src/general/manage/cmd/rename.c
src/general/manage/lib/read_list.c
src/libes/dbmi/lib/dbmscap.c
* src/raster/r.sun/main.c
  various tidying:
    include necessary headers
    remove unused variables
    error handling changes
    use $GRASS_PAGER instead of $PAGER
    remove $Log$

src/display/d.his/cmd/main.c
src/raster/r.his/cmd/main.c
  -n flag

src/display/d.text.freetype/Gmakefile
src/display/d.text.freetype/freetypecap
src/display/d.text.freetype/main.c
  add align=, rotation= options
  command mode

src/display/devices/PNGdriver/Graph_Set.c
  Fix GRASS_BACKGROUNDCOLOR processing

src/display/devices/PNGdriver/README
  default background is black

src/display/devices/XDRIVER/XDRIVER24/Graph_Set.c
  add "GRASS" to monitor title (tcltkgrass bug workaround)

src/general/init/Gmakefile
  generate $GISBASE/etc/license
  link $GISBASE/etc/lock against libgis

src/general/init/init.sh
* add "savehist" setting to .cshrc
  i18n
  licence notice moved to separate file

* src/imagery/i.points/ask_mag.c
* src/imagery/i.points3/inter/graph_askmag.c
* src/imagery/i.vpoints/ask_mag.c
  add R_flush()

* src/imagery/i.vpoints/cell.c
* src/imagery/i.vpoints/colors.c
src/imagery/i.vpoints/debug.c
* src/imagery/i.vpoints/drawcell.c
* src/imagery/i.vpoints/drawvect.c
* src/imagery/i.vpoints/driver.c
src/imagery/i.vpoints/globals.h
src/imagery/i.vpoints/main.c
src/imagery/i.vpoints/zoom_box.c
  various changes

src/include/config.h.in
  HAVE_READLINE_READLINE_H

src/include/geo.h
src/libes/gis/geo_init.c
src/libes/gis/projections
src/libes/proj/Gmakefile
src/libes/proj/pj_list.h
  krovak[gis] added

src/libes/edit/edit_cellhd.c
  fix rounding of negative values

src/libes/gis/datum.table
src/libes/proj/pj_datums.c
  Hermannskogel added

src/libes/gis/env.c
  check for empty string in set_env()
  I18N

src/libes/gis/reclass.c
  disable reclassed_to warning
  I18N

src/libes/gis/Gmakefile
src/libes/gis/G_dump.c
src/libes/gis/adj_cellhd.c
src/libes/gis/ask.c
src/libes/gis/ask_cell.c
src/libes/gis/auto_mask.c
src/libes/gis/cats.c
src/libes/gis/closecell.c
src/libes/gis/color_read.c
src/libes/gis/datum.c
src/libes/gis/done_msg.c
src/libes/gis/error.c
src/libes/gis/format.c
src/libes/gis/get_cellhd.c
src/libes/gis/get_datum.c
src/libes/gis/get_datum_name.c
src/libes/gis/get_ell_name.c
src/libes/gis/get_ellipse.c
src/libes/gis/get_projinfo.c
src/libes/gis/get_projname.c
src/libes/gis/get_row.c
src/libes/gis/get_window.c
src/libes/gis/gishelp.c
src/libes/gis/gisinit.c
src/libes/gis/histogram.c
src/libes/gis/history.c
src/libes/gis/home.c
src/libes/gis/legal_name.c
src/libes/gis/list.c
src/libes/gis/location.c
src/libes/gis/make_colr.c
src/libes/gis/mapset.c
src/libes/gis/mapset_msc.c
src/libes/gis/mask_info.c
src/libes/gis/myname.c
src/libes/gis/null_val.c
src/libes/gis/opencell.c
src/libes/gis/parser.c
src/libes/gis/proj2.c
src/libes/gis/proj3.c
src/libes/gis/put_cellhd.c
src/libes/gis/put_row.c
src/libes/gis/put_title.c
src/libes/gis/quant_io.c
src/libes/gis/quant_rw.c
src/libes/gis/range.c
src/libes/gis/rd_cellhd.c
src/libes/gis/readsites.c
src/libes/gis/readsites_xyz.c
src/libes/gis/set_window.c
src/libes/gis/system.c
src/libes/gis/timestamp.c
src/libes/gis/view.c
  I18N

* src/libes/proj/datum_shift.c
  check for no datum specified

src/libes/proj/geod.c
  re-order headers to deal with geodesic.h issues

* src/mapdev/v.in.shape/main.c
  -d flag
  error handling

* src/mapdev/v.mkgrid/mkgrid_cmd.c
  fix key_desc field of "box=" option

src/mapdev/v.proj/Gmakefile
* src/mapdev/v.proj/main.c
* src/sites/s.proj/main.c
  datum/ellipse fixes

src/raster/r.in.gdal/main.c
  convert ellipsoid name to lower case (bug #1047)

src/raster/r.mapcalc3/Gmakefile
src/raster/r.mapcalc3/mapcalc.l
  readline support
  fix bug with quoted map names

src/raster/r.mapcalc3/evaluate.c
src/raster/r.mapcalc3/map.c
src/raster/r.mapcalc3/mapcalc.h
  copy cats/colr/hist

src/raster/r.mapcalc3/main.c
  allow expression to be split into multiple arguments

src/raster/r.mapcalc3/xexp.c
  allow two-argument form

src/raster/r.proj/cmd/bordwalk.c
  ignore invalid points

src/raster/r.proj/cmd/main.c
src/raster/r.proj/cmd/r.proj.h
* datum/ellipse fixes
  tidy
  add -n (nocrop) flag
  move "menu" array from r.proj.h to main.c

* src/raster/r.tiff/r.out.tiff.c
  fix allocation bug

* src/scripts/contrib/d.rast.rescale/d.rast.rescale
  add "help" option
  fix r.stats invocation (-z -> -n)

src/scripts/contrib/grassmirrorsmap/grass.sites.mirror
  add Canada, Venezuela

src/scripts/contrib/grassmirrorsmap/grass_sites.gif
src/scripts/contrib/grassmirrorsmap/grass_sites.htmlmap
src/scripts/contrib/grassmirrorsmap/grassmap.html
  updated

src/scripts/contrib/grassmirrorsmap/list_countries.sh
  add g.gisenv call

src/scripts/contrib/grassmirrorsmap/mkgrassmap.sh
  add more colors

src/scripts/contrib/r.univar/r.univar
  /bin/bash -> /bin/sh
  change Markus' email address

src/sites/s.in.mif/Gmakefile
  fix lex invocation

src/tcltkgrass/main/gis_set.tcl
src/tcltkgrass/tcltkgrass
  I18N

* src/tcltkgrass/module/d.his
  -n switch

src/tcltkgrass/module/d.zoom
  more options

Bogus Diffs

src/libes/gis/sites.c
src.contrib/GMSL/NVIZ2.2/src/togl.c

[Glynn_Clements]

Glynn Clements wrote:

For the remaining changes, I would appreciate opinions as to which
should be included in the next release. I'll submit my opinions in a
follow-up.

I recommend including these:

Makefile.in
  handling of "locale" subdirectory

configure
configure.in
  Darwin iconv check
  Darwin PostgreSQL (-lssl -lcrypto)

html/html/pngdriver.html
  default background is black

src/display/devices/PNGdriver/README
  default background is black

locale/Gmakefile
  process all locales, not $LANG

mk/Makefile.in
  add "locale" subdirectory to "dirs" target

src/display/devices/PNGdriver/Graph_Set.c
  Fix GRASS_BACKGROUNDCOLOR processing

src/display/devices/XDRIVER/XDRIVER24/Graph_Set.c
  add "GRASS" to monitor title (tcltkgrass bug workaround)

src/libes/edit/edit_cellhd.c
  fix rounding of negative values

src/libes/gis/env.c
  check for empty string in set_env()

src/libes/proj/geod.c
  re-order headers to deal with geodesic.h issues

src/raster/r.in.gdal/main.c
  convert ellipsoid name to lower case (bug #1047)

src/raster/r.mapcalc3/Gmakefile
src/raster/r.mapcalc3/mapcalc.l
  fix bug with quoted map names

src/raster/r.mapcalc3/main.c
  allow expression to be split into multiple arguments

src/raster/r.mapcalc3/xexp.c
  allow two-argument form

src/raster/r.proj/cmd/bordwalk.c
  ignore invalid points

src/raster/r.proj/cmd/main.c
src/raster/r.proj/cmd/r.proj.h
  tidy
  add -n (nocrop) flag
  move "menu" array from r.proj.h to main.c

src/sites/s.in.mif/Gmakefile
  fix lex invocation

These are harmless, so may as well be included:

mk/Makefile.in
  generate more complex "gmake5" script

mk/mid.mk
mk/mid.mk.shlib
  add LOCALE definition

mk/mkmakefiles
  optional directory argument

These are worth considering:

configure
configure.in
  readline

src/CMD/head/head.in
  readline variables

src/include/config.h.in
  HAVE_READLINE_READLINE_H

src/raster/r.mapcalc3/Gmakefile
src/raster/r.mapcalc3/mapcalc.l
  readline support

src/raster/r.mapcalc3/evaluate.c
src/raster/r.mapcalc3/map.c
src/raster/r.mapcalc3/mapcalc.h
  copy cats/colr/hist

src/libes/gis/reclass.c
  disable reclassed_to warning

--
Glynn Clements <glynn.clements@virgin.net>

[Bernhard_Reiter]

On Sat, Jun 08, 2002 at 08:47:52PM +0100, Glynn Clements wrote:

> > since all release critical bugs are fixed, we should release
> > GRASS 5.0.0stable now.
> >
> > For that we can use the existing pre4 branch. Maybe Glynn could
> > check if any important change was not submitted to (post-)pre4
> > branch?
>
> OK, I'll look into it. However, 257 files differ between pre4 and the
> head, so it may take a while to check everything.

Fortunately, many of them correspond to bulk changes.

We will not include them.
I strongly advise against merging now.

We should run checks for the release branch code and then release it
as 5.0.0 or pre5.

Also, if any fundamental changes are to be included (e.g. the libgis
I18N), we should consider labelling the next release as "pre5" rather
than "final".

No fundamental changes. Only critical bug fixes.
And everybody should have committed them already to the release branch.

[neteler]

On Sat, Jun 08, 2002 at 10:12:37PM +0100, Glynn Clements wrote:

Glynn Clements wrote:

> For the remaining changes, I would appreciate opinions as to which
> should be included in the next release. I'll submit my opinions in a
> follow-up.

I recommend including these:

> Makefile.in
> handling of "locale" subdirectory

yes - important fix.

> configure
> configure.in
> Darwin iconv check
> Darwin PostgreSQL (-lssl -lcrypto)

yes, as needed for Darwin MACOSX.

> html/html/pngdriver.html
> default background is black

ok

> src/display/devices/PNGdriver/README
> default background is black

ok

> locale/Gmakefile
> process all locales, not $LANG

ok

> mk/Makefile.in
> add "locale" subdirectory to "dirs" target

important fix

> src/display/devices/PNGdriver/Graph_Set.c
> Fix GRASS_BACKGROUNDCOLOR processing

> src/display/devices/XDRIVER/XDRIVER24/Graph_Set.c
> add "GRASS" to monitor title (tcltkgrass bug workaround)

no idea above upper two. If you recommend, why not.

> src/libes/edit/edit_cellhd.c
> fix rounding of negative values

ok

> src/libes/gis/env.c
> check for empty string in set_env()

important

> src/libes/proj/geod.c
> re-order headers to deal with geodesic.h issues

ok (for Darwin and friends)

> src/raster/r.in.gdal/main.c
> convert ellipsoid name to lower case (bug #1047)

ok

> src/raster/r.mapcalc3/Gmakefile
> src/raster/r.mapcalc3/mapcalc.l
> fix bug with quoted map names

ok

> src/raster/r.mapcalc3/main.c
> allow expression to be split into multiple arguments

ok

> src/raster/r.mapcalc3/xexp.c
> allow two-argument form

ok

> src/raster/r.proj/cmd/bordwalk.c
> ignore invalid points

no idea - is the bordwalk issue clarified now? Morten?

> src/raster/r.proj/cmd/main.c
> src/raster/r.proj/cmd/r.proj.h
> tidy
> add -n (nocrop) flag
> move "menu" array from r.proj.h to main.c

no idea - is the bordwalk issue clarified now? Morten?

> src/sites/s.in.mif/Gmakefile
> fix lex invocation

ok

These are harmless, so may as well be included:

> mk/Makefile.in
> generate more complex "gmake5" script

> mk/mid.mk
> mk/mid.mk.shlib
> add LOCALE definition

> mk/mkmakefiles
> optional directory argument

all ok

These are worth considering:

> configure
> configure.in
> readline

> src/CMD/head/head.in
> readline variables

> src/include/config.h.in
> HAVE_READLINE_READLINE_H

> src/raster/r.mapcalc3/Gmakefile
> src/raster/r.mapcalc3/mapcalc.l
> readline support

should be quite harmless as it is 1 optional
function only (have tested o.k)

> src/raster/r.mapcalc3/evaluate.c
> src/raster/r.mapcalc3/map.c
> src/raster/r.mapcalc3/mapcalc.h
> copy cats/colr/hist

please yes.

> src/libes/gis/reclass.c
> disable reclassed_to warning

also yes.

Thanks for the investigation, Glynn!

Markus

[neteler]

On Tue, Jun 11, 2002 at 03:31:06PM +0200, Bernhard Reiter wrote:

On Sat, Jun 08, 2002 at 08:47:52PM +0100, Glynn Clements wrote:
>
> > > since all release critical bugs are fixed, we should release
> > > GRASS 5.0.0stable now.
> > >
> > > For that we can use the existing pre4 branch. Maybe Glynn could
> > > check if any important change was not submitted to (post-)pre4
> > > branch?
> >
> > OK, I'll look into it. However, 257 files differ between pre4 and the
> > head, so it may take a while to check everything.
>
> Fortunately, many of them correspond to bulk changes.

We will not include them.
I strongly advise against merging now.

Did you really read the mail of Glynn? There are several important
fixes mentioned. GRASS cannot even installed without at least the
Makefile fix etc.

We should run checks for the release branch code and then release it
as 5.0.0 or pre5.

> Also, if any fundamental changes are to be included (e.g. the libgis
> I18N), we should consider labelling the next release as "pre5" rather
> than "final".

No fundamental changes. Only critical bug fixes.
And everybody should have committed them already to the release branch.

.. which didn't happen...

Also a bugfix from David for v.in.shape is in the queue (he wrote to
me personally since he is currently no subscriber).

Markus

[Glynn_Clements]

Markus Neteler wrote:

> > For the remaining changes, I would appreciate opinions as to which
> > should be included in the next release. I'll submit my opinions in a
> > follow-up.
>
> I recommend including these:

Note: the absence of a change from that list doesn't mean that I'm
advising against including it; it means that I would like input as to
whether or not the change should be included in the next release.

I really need comments on the changes which are on the original list
but not on my "approved" list.

--
Glynn Clements <glynn.clements@virgin.net>

[Bernhard_Reiter]

On Tue, Jun 11, 2002 at 04:38:03PM +0200, Markus Neteler wrote:

There are several important
fixes mentioned. GRASS cannot even installed without at least the
Makefile fix etc.

We should make these of course.

> No fundamental changes. Only critical bug fixes.
> And everybody should have committed them already to the release branch.

.. which didn't happen...

AFAIK mostly Glynn postponed the checkin of his code changes.
Most of the other changes does not seem to be release critical.

Also a bugfix from David for v.in.shape is in the queue (he wrote to
me personally since he is currently no subscriber).

It may be too late for 5.0.0 then...
or is it release critical?

We should be as close to 5.0.0pre4 as we can,
because this was tested a lot.
Any change we make might introduce other bugs.

[neteler]

On Sat, Jun 08, 2002 at 08:47:52PM +0100, Glynn Clements wrote:

Glynn Clements wrote:

> > since all release critical bugs are fixed, we should release
> > GRASS 5.0.0stable now.
> >
> > For that we can use the existing pre4 branch. Maybe Glynn could
> > check if any important change was not submitted to (post-)pre4
> > branch?
>
> OK, I'll look into it. However, 257 files differ between pre4 and the
> head, so it may take a while to check everything.

Fortunately, many of them correspond to bulk changes.

The following is a brief summary of the differences between pre4 and
the current state of the head. Files or changes which are preceded by
an asterisk have already been committed to the release branch.

For the remaining changes, I would appreciate opinions as to which
should be included in the next release. I'll submit my opinions in a
follow-up.

Also, if any fundamental changes are to be included (e.g. the libgis
I18N), we should consider labelling the next release as "pre5" rather
than "final".

--
Glynn Clements <glynn.clements@virgin.net>

Added directories

locale/ru/tcltkgrass
src/display/d.text.freetype/vflib

no recommendation here

Added Files

locale/ru/LC_MESSAGES/libgis.po
  libgis I18N

locale/ru/grass_intro.txt
locale/ru/license.txt
src/general/init/license.txt
  Init.sh I18N

no recommendation here

src/libes/proj/PJ_krovak.c
src/libes/proj/PJ_krovakgis.c
  krovak[gis] addition

This is pretty safe. It should appear in PROJ4 soon (hi Frank).
Of course it can also be skipped.

src/display/d.text.freetype/test.input
  d.text.freetype command mode

no idea

Changed Files

AUTHORS
  re-format long lines

yes

NEWS.html
  updated

yes

documents/debugging.txt
  comment re: -W[error-]implicit-function-declaration
  add section 6: Debugging with 'core' file

yes

documents/release_rules.txt
  updated

yes

handheld/babyGRASS_compile.sh
handheld/babyGRASS_packagingsrc.sh
  add g.mapsets

yes

SUBMITTING
  header ordering

yes

Makefile.in
  handling of "locale" subdirectory

yes, very important

configure
configure.in
  readline
  Darwin iconv check
  Darwin PostgreSQL (-lssl -lcrypto)

yes

* documents/cygwin_grass50bininstall.html
  sunrpc library

yes

html/Gmakefile
  [ -> test
  mkdir -> mkdir -p

yes, needed

html/html/d.his.html
  -n flag

yes (it restores the former functionality)

* html/html/d.rast.pg.html
* html/html/d.site.pg.html
* html/html/d.what.r.pg.html
* html/html/d.what.s.pg.html
* html/html/d.what.v.pg.html
* html/html/g.column.pg.html
* html/html/g.select.pg.html
* html/html/g.stats.pg.html
* html/html/g.table.pg.html
* html/html/pg.in.dbf.html
  koi8-r -> iso-8859-1

yes

html/html/d.vect.pg.html
* koi8-r -> iso-8859-1

yes

  -e flag

depends

* html/html/v.reclass.pg.html
  koi8-r -> iso-8859-1

yes

  fix postgresql.org URL

depends

* html/html/v.to.pg.html
  koi8-r -> iso-8859-1

yes

  -p flag
  PostGIS

depends

  change xrefs

yes

html/html/d.text.freetype.html
  -rpsc flags
  align=, rotation=
  Command mode

no idea

html/html/dcorrelate.sh.html
  mention "scattergram"

yes

html/html/i.rectify.html
  comment regarding write errors

yes

html/html/i.in.erdas.html
  r.in.gdal xref
  authors

yes

* html/html/m.datum.shift.html
html/html/s.in.garmin.sh.html
  change xrefs

yes

html/html/pngdriver.html
  default background is black

yes

html/html/r.his.html
  -n flag

yes, restored former functionality

* html/html/r.runoff.html
  G-language -> GRASS raster command

yes

html/html/s.in.ascii.html
  Time as String Attributes

yes

* html/html/s.vol.rst.html
  references

yes

html/html/s.what.html
  Add mailto: link

yes

html/html/v.in.garmin.sh.html
* gps -> GPS
  change xrefs

yes

html/html/v.in.shape.html
  -d flag

yes, restored former functionality accidentally removed by last submission

html/index.html
* update search URL
  update mailto: link

yes

html/projections.html
  add URLs

yes

html/raster.html
  remove xrefs

yes

* html/searchhtml.html
  update search URL

yes

html/tips_and_tricks.html
  Add comment re: .cshrc

yes

locale/Gmakefile
  process all locales, not $LANG

yes

  add tcltkgrass, textintro targets

depends

locale/ru/LC_MESSAGES/d.vect.pg.po
locale/ru/LC_MESSAGES/v.to.pg.po

depends

mk/Makefile.in
  add "locale" subdirectory to "dirs" target
  generate more complex "gmake5" script

yes

mk/mid.mk
mk/mid.mk.shlib
  add LOCALE definition

yes/depends ?

mk/mkmakefiles
  optional directory argument

yes

src.contrib/GMSL/SG3d/README
src.contrib/GMSL/sg4d/README
  mention Ygl

yes

src.garden/grass.hdf/hdf5/r.in.hdf/README
  mention HDF-EOS

yes

src.garden/grass.hdf/hdf5/r.in.hdf/r.in.hdf.c

yes (it's not compiled by default).
The program now supports ASTER, MODIS (not yet 2Q) without
geocoding. More work needed.

src.garden/grass.postgresql/d.vect.pg/dbvect.h
src.garden/grass.postgresql/d.vect.pg/getAllOpts.c
src.garden/grass.postgresql/d.vect.pg/getSopts.c
src.garden/grass.postgresql/d.vect.pg/main.c
src.garden/grass.postgresql/d.vect.pg/runInfxFile.c
  -e (extract) flag

no idea

src.garden/grass.postgresql/v.to.pg/dbvect.h
src.garden/grass.postgresql/v.to.pg/getAllOpts.c
src.garden/grass.postgresql/v.to.pg/getSopts.c
src.garden/grass.postgresql/v.to.pg/main.c
src.garden/grass.postgresql/v.to.pg/plotCat.c
src.garden/grass.postgresql/v.to.pg/runInfxFile.c
  -p (postgis) flag

no idea

* src/CMD/generic/GISGEN.sh
  "locale" subdirectory

depends

src/CMD/generic/make.mid
  define LOCALE (currently unused)

depends

src/CMD/head/head.in
  readline variables

yes, don't see a problem (tested)

src/display/d.3d/Dmain.c
src/display/d.3d/check_opt.c
src/display/d.3d/command.c
src/display/d.area/main.c
src/display/d.area/screenpoly.c
src/display/d.barscale/cmd/main.c
src/display/d.barscale/cmd/mouse.c
src/display/d.colormode/cmd/main.c
src/display/d.colors/get_info.c
src/display/d.colortable/cmd/main.c
src/display/d.db/main.c
src/display/d.extend/cmd/main.c
src/display/d.font/cmd/main.c
src/display/d.frame/cmd/create.c
src/display/d.frame/cmd/dumper.c
src/display/d.frame/cmd/select.c
src/display/d.geodesic/cmd/main.c
src/display/d.graph/cmd/allocation.c
src/display/d.graph/cmd/main.c
src/display/d.grid/cmd/main.c
src/display/d.histogram/cmd/get_stats.c
src/display/d.icons/cmd/main.c
src/display/d.label/cmd/main.c
src/display/d.leg.thin/main.c
src/display/d.mapgraph/cmd/main.c
src/display/d.menu/cmd/main.c
src/display/d.mon/pgms/release.c
src/display/d.mon/pgms/start.c
src/display/d.mon/pgms/stop.c
src/display/d.mouse/main.c
src/display/d.pan/main.c
src/display/d.points/cmd/main.c
src/display/d.profile/What.c
src/display/d.profile/main.c
src/display/d.rast/cmd/display.c
src/display/d.rast/cmd/main.c
src/display/d.rhumbline/cmd/main.c
src/display/d.sites.qual/cmd/main.c
src/display/d.sites/cmd/main.c
src/display/d.title/cmd/main.c
src/display/d.vect.labels/main.c
src/display/d.vect/cmd/main.c
src/display/d.what.db/main.c
src/display/d.what.vect/cmd/attr.c
src/display/d.what.vect/cmd/main.c
src/display/d.where/cmd/main.c
src/display/d.zoom/cmd/main.c
src/general/g.gisenv/main.c
src/general/g.help/main.c
src/general/g.help/menu.c
src/general/g.manual/cmd/main.c
src/general/g.manual/inter/main.c
src/general/g.mapsets/dsply_path.c
src/general/g.mapsets/main_cmd.c
src/general/g.parser/main.c
src/general/g.region/cmd/main.c
src/general/g.region/cmd/printwindow.c
src/general/g.region/cmd/zoom.c
src/general/g.region/inter/main.c
src/general/g.setproj/main.c
src/general/init/lock.c
src/general/manage/cmd/copy.c
src/general/manage/cmd/rename.c
src/general/manage/lib/read_list.c
src/libes/dbmi/lib/dbmscap.c
* src/raster/r.sun/main.c
  various tidying:
    include necessary headers
    remove unused variables
    error handling changes
    use $GRASS_PAGER instead of $PAGER
    remove $Log$

yes

src/display/d.his/cmd/main.c
src/raster/r.his/cmd/main.c
  -n flag

yes, restored original functionality, otherwise NULL problems

src/display/d.text.freetype/Gmakefile
src/display/d.text.freetype/freetypecap
src/display/d.text.freetype/main.c
  add align=, rotation= options
  command mode

no idea: new feature

src/display/devices/PNGdriver/Graph_Set.c
  Fix GRASS_BACKGROUNDCOLOR processing

seems to be needed?

src/display/devices/PNGdriver/README
  default background is black

yes if above

src/display/devices/XDRIVER/XDRIVER24/Graph_Set.c
  add "GRASS" to monitor title (tcltkgrass bug workaround)

seems to be needed?

src/general/init/Gmakefile
  generate $GISBASE/etc/license
  link $GISBASE/etc/lock against libgis

yes

src/general/init/init.sh
* add "savehist" setting to .cshrc

yes (trivial fix)

  i18n

no idea

  licence notice moved to separate file

mhh, if it helps

* src/imagery/i.points/ask_mag.c
* src/imagery/i.points3/inter/graph_askmag.c
* src/imagery/i.vpoints/ask_mag.c
  add R_flush()

yes, needed

* src/imagery/i.vpoints/cell.c
* src/imagery/i.vpoints/colors.c
src/imagery/i.vpoints/debug.c
* src/imagery/i.vpoints/drawcell.c
* src/imagery/i.vpoints/drawvect.c
* src/imagery/i.vpoints/driver.c
src/imagery/i.vpoints/globals.h
src/imagery/i.vpoints/main.c
src/imagery/i.vpoints/zoom_box.c
  various changes

not changes but bugfixes. Now usable, before broken

src/include/config.h.in
  HAVE_READLINE_READLINE_H

yes, don't see a problem

src/include/geo.h
src/libes/gis/geo_init.c
src/libes/gis/projections
src/libes/proj/Gmakefile
src/libes/proj/pj_list.h
  krovak[gis] added

harmless, see above

src/libes/edit/edit_cellhd.c
  fix rounding of negative values

yes

src/libes/gis/datum.table
src/libes/proj/pj_datums.c
  Hermannskogel added

yes if krovak added

src/libes/gis/env.c
  check for empty string in set_env()

yes

  I18N

no idea

src/libes/gis/reclass.c
  disable reclassed_to warning

yes

  I18N

no idea

src/libes/gis/Gmakefile
src/libes/gis/G_dump.c
src/libes/gis/adj_cellhd.c
src/libes/gis/ask.c
src/libes/gis/ask_cell.c
src/libes/gis/auto_mask.c
src/libes/gis/cats.c
src/libes/gis/closecell.c
src/libes/gis/color_read.c
src/libes/gis/datum.c
src/libes/gis/done_msg.c
src/libes/gis/error.c
src/libes/gis/format.c
src/libes/gis/get_cellhd.c
src/libes/gis/get_datum.c
src/libes/gis/get_datum_name.c
src/libes/gis/get_ell_name.c
src/libes/gis/get_ellipse.c
src/libes/gis/get_projinfo.c
src/libes/gis/get_projname.c
src/libes/gis/get_row.c
src/libes/gis/get_window.c
src/libes/gis/gishelp.c
src/libes/gis/gisinit.c
src/libes/gis/histogram.c
src/libes/gis/history.c
src/libes/gis/home.c
src/libes/gis/legal_name.c
src/libes/gis/list.c
src/libes/gis/location.c
src/libes/gis/make_colr.c
src/libes/gis/mapset.c
src/libes/gis/mapset_msc.c
src/libes/gis/mask_info.c
src/libes/gis/myname.c
src/libes/gis/null_val.c
src/libes/gis/opencell.c
src/libes/gis/parser.c
src/libes/gis/proj2.c
src/libes/gis/proj3.c
src/libes/gis/put_cellhd.c
src/libes/gis/put_row.c
src/libes/gis/put_title.c
src/libes/gis/quant_io.c
src/libes/gis/quant_rw.c
src/libes/gis/range.c
src/libes/gis/rd_cellhd.c
src/libes/gis/readsites.c
src/libes/gis/readsites_xyz.c
src/libes/gis/set_window.c
src/libes/gis/system.c
src/libes/gis/timestamp.c
src/libes/gis/view.c
  I18N

no idea

* src/libes/proj/datum_shift.c
  check for no datum specified

yes

src/libes/proj/geod.c
  re-order headers to deal with geodesic.h issues

yes (Darwin)

* src/mapdev/v.in.shape/main.c
  -d flag
  error handling

yes, restores former flag accidentally deleted

* src/mapdev/v.mkgrid/mkgrid_cmd.c
  fix key_desc field of "box=" option

yes (was typo)

src/mapdev/v.proj/Gmakefile
* src/mapdev/v.proj/main.c
* src/sites/s.proj/main.c
  datum/ellipse fixes

I suggest that then also m.proj[2] must be updated to
avoid inconsistencies

src/raster/r.in.gdal/main.c
  convert ellipsoid name to lower case (bug #1047)

yes

src/raster/r.mapcalc3/Gmakefile
src/raster/r.mapcalc3/mapcalc.l
  readline support
  fix bug with quoted map names

yes

src/raster/r.mapcalc3/evaluate.c
src/raster/r.mapcalc3/map.c
src/raster/r.mapcalc3/mapcalc.h
  copy cats/colr/hist

yes (harmless, restores functionality of old r.mapcalc with fix)

src/raster/r.mapcalc3/main.c
  allow expression to be split into multiple arguments

yes

src/raster/r.mapcalc3/xexp.c
  allow two-argument form

yes

src/raster/r.proj/cmd/bordwalk.c
  ignore invalid points

no idea (Morten?)

src/raster/r.proj/cmd/main.c
src/raster/r.proj/cmd/r.proj.h
* datum/ellipse fixes

I suggest that then also m.proj[2] must be updated to
avoid inconsistencies

  tidy
  add -n (nocrop) flag
  move "menu" array from r.proj.h to main.c

maybe yes?

* src/raster/r.tiff/r.out.tiff.c
  fix allocation bug

yes

* src/scripts/contrib/d.rast.rescale/d.rast.rescale
  add "help" option
  fix r.stats invocation (-z -> -n)

yes

src/scripts/contrib/grassmirrorsmap/grass.sites.mirror
  add Canada, Venezuela

yes

src/scripts/contrib/grassmirrorsmap/grass_sites.gif
src/scripts/contrib/grassmirrorsmap/grass_sites.htmlmap
src/scripts/contrib/grassmirrorsmap/grassmap.html
  updated

yes

src/scripts/contrib/grassmirrorsmap/list_countries.sh
  add g.gisenv call

yes

src/scripts/contrib/grassmirrorsmap/mkgrassmap.sh
  add more colors

yes

src/scripts/contrib/r.univar/r.univar
  /bin/bash -> /bin/sh
  change Markus' email address

yes

src/sites/s.in.mif/Gmakefile
  fix lex invocation

yes

src/tcltkgrass/main/gis_set.tcl
src/tcltkgrass/tcltkgrass
  I18N

no idea

* src/tcltkgrass/module/d.his
  -n switch

yes

src/tcltkgrass/module/d.zoom
  more options

yes (otherwise not consistent)

Bogus Diffs

src/libes/gis/sites.c
src.contrib/GMSL/NVIZ2.2/src/togl.c

What means Bogus here?

Thanks for this comparison, Glynn!

So far my comments.

Markus

[neteler]

On Tue, Jun 11, 2002 at 05:28:52PM +0200, Bernhard Reiter wrote:

On Tue, Jun 11, 2002 at 04:38:03PM +0200, Markus Neteler wrote:

> There are several important
> fixes mentioned. GRASS cannot even installed without at least the
> Makefile fix etc.

We should make these of course.

> > No fundamental changes. Only critical bug fixes.
> > And everybody should have committed them already to the release branch.
>
> .. which didn't happen...

AFAIK mostly Glynn postponed the checkin of his code changes.
Most of the other changes does not seem to be release critical.

... see my other mail...

> Also a bugfix from David for v.in.shape is in the queue (he wrote to
> me personally since he is currently no subscriber).

It may be too late for 5.0.0 then...
or is it release critical?

I don't know, he wasn't very detailed.

We should be as close to 5.0.0pre4 as we can,
because this was tested a lot.

That's why we have to fix more than above Makefile.in. Otherwise
several modules either won't work or behave different from pre3
(flags etc). See the other mail.

Any change we make might introduce other bugs.

That's a point especially for I18N and the PG modules.

Markus

[Morten_Hulden1]

On Tue, 11 Jun 2002, Markus Neteler wrote:

On Sat, Jun 08, 2002 at 10:12:37PM +0100, Glynn Clements wrote:
>
> Glynn Clements wrote:
>
> > For the remaining changes, I would appreciate opinions as to which
> > should be included in the next release. I'll submit my opinions in a
> > follow-up.
>
> I recommend including these:
>

...

> > src/raster/r.proj/cmd/bordwalk.c
> > ignore invalid points

no idea - is the bordwalk issue clarified now? Morten?

Ignoring invalid points is a separate issue from the bordwalk() topic. It
can happen in any PROJ routine. For raster projections I think it's OK to
ignore invalid points in bordwalk(), and set cells to NULL if we hit them
in the main() (even if this may result in NULL holes in the map, but it's
better than aborting r.proj completely).

> > src/raster/r.proj/cmd/main.c
> > src/raster/r.proj/cmd/r.proj.h
> > tidy
> > add -n (nocrop) flag
> > move "menu" array from r.proj.h to main.c

no idea - is the bordwalk issue clarified now? Morten?

My view is:

  -the new flag -n (nocrop) should inhibit both of the two calls to
bordwalk() from main. without -n, both calls to boardwalk() should be
enabled.
  -r.proj should honour current region settings, not
unconditionally project into default region.

Morten Hulden

[Glynn_Clements]

libgis/Init.sh I18N:

I suggest no for final, but maybe if we decide to do a pre5. The problem
is that, however trivial the changes might appear, if something does go
wrong, the whole of GRASS may be completely unusable.

> src/libes/proj/PJ_krovak.c
> src/libes/proj/PJ_krovakgis.c
> krovak[gis] addition

This is pretty safe. It should appear in PROJ4 soon (hi Frank).
Of course it can also be skipped.

I can't see any way in which this can break anything.

> html/Gmakefile
> [ -> test
> mkdir -> mkdir -p

yes, needed

The autoconf docs specifically warn against using "mkdir -p", as it
isn't supported on all platforms. However, GRASS already relies upon
it in a number of places.

> fix postgresql.org URL

depends

On what? The actual change is:

-This program requires the <a href="www.postgresql.org">PostgreSQL</a> database
+This program requires the <a href="http://www.postgresql.org">PostgreSQL</a> database

Although, it should really be:

  http://www.postgresql.org/

URLs which refer to directories (i.e. an implicit "index.html") should
always have a trailing slash. Otherwise, the HTTP server has to reply
with a redirect (301/302) response rather than the actual file. This
is so that relative URLs work correctly.

However, I suspect that the browser will fix this automatically in the
case of a "top level" URL such as the above.

> html/html/d.text.freetype.html
> -rpsc flags
> align=, rotation=
> Command mode

no idea

> src/display/d.text.freetype/Gmakefile
> src/display/d.text.freetype/freetypecap
> src/display/d.text.freetype/main.c
> add align=, rotation= options
> command mode

no idea: new feature

These are enhancements rather than bug fixes. However, d.text.freetype
is relatively new, so backward compatibility isn't really an issue yet.

> mk/mid.mk
> mk/mid.mk.shlib
> add LOCALE definition
yes/depends ?

> src/CMD/generic/make.mid
> define LOCALE (currently unused)

These aren't used by anything presently, so it doesn't really matter
either way.

> * src/CMD/generic/GISGEN.sh
> "locale" subdirectory

depends

This is a definite yes. This was the primary cause of the "make install"
problem in pre5.

[long list of files snipped]

> various tidying:
> include necessary headers
> remove unused variables
> error handling changes
> use $GRASS_PAGER instead of $PAGER
> remove $Log$

yes

Then the next version should be labelled "pre5".

> src/display/devices/PNGdriver/Graph_Set.c
> Fix GRASS_BACKGROUNDCOLOR processing

seems to be needed?

Yes.

> src/display/devices/PNGdriver/README
> default background is black
yes if above

Yes regardless; the default background *is* black, but the documentation
said it was white. This just fixes the documentation to match the actual
behaviour.

> src/display/devices/XDRIVER/XDRIVER24/Graph_Set.c
> add "GRASS" to monitor title (tcltkgrass bug workaround)

seems to be needed?

The tcltkgrass "stop all X monitors" option relies upon the XDRIVER
window title containing the string "GRASS". The tcltkgrass code is an
ugly hack, which should ultimately be fixed; but this should suffice for
now.

> src/general/init/Gmakefile
> generate $GISBASE/etc/license
> link $GISBASE/etc/lock against libgis

yes

The first of these is part of the Init.sh I18N.

The second of these relates to the error handling changes. etc/lock now
uses G_fatal_error(), so it has to be linked against libgis.

However, I have no idea how this interacts with the fact that etc/lock
is run during GRASS initialisation. etc/lock doesn't call G_gisinit()
(which may not even work at that point); I don't know whether that
presents a problem for the use of G_fatal_error().

> src/general/init/init.sh
> * add "savehist" setting to .cshrc
yes (trivial fix)

> i18n
no idea

> licence notice moved to separate file

mhh, if it helps

Part of Init.sh I18N. The idea is that the licence and introductory
message are read from separate (localised) files.

> src/mapdev/v.proj/Gmakefile
> * src/mapdev/v.proj/main.c
> * src/sites/s.proj/main.c
> datum/ellipse fixes

I suggest that then also m.proj[2] must be updated to
avoid inconsistencies

OK; I'll look into it.

> src/raster/r.proj/cmd/bordwalk.c
> ignore invalid points

no idea (Morten?)

This part is definitely recommended.

> src/raster/r.proj/cmd/main.c
> src/raster/r.proj/cmd/r.proj.h
> * datum/ellipse fixes
I suggest that then also m.proj[2] must be updated to
avoid inconsistencies

> tidy
> add -n (nocrop) flag
> move "menu" array from r.proj.h to main.c

maybe yes?

I'm fairly sure about the "-n" switch, but we should probably re-enable
the other call to bordwalk(), also on that switch. But:

1. This needs to be tested, preferably with a wide variety of
projections

2. We need to consider whether cropping should be on or off by default;
enabling cropping saves memory, but could result in the output being
incomplete.

3. At some point, we should consider how to handle latitudinal wrapping.

> src/tcltkgrass/main/gis_set.tcl
> src/tcltkgrass/tcltkgrass
> I18N

no idea

This could still do with some more work (e.g. checking LC_MESSAGES,
LC_ALL). Not as critical as libgis or Init.sh, but still fairly
important to get right.

> Bogus Diffs
> ===========
>
> src/libes/gis/sites.c
> src.contrib/GMSL/NVIZ2.2/src/togl.c

What means Bogus here?

It means that these files only differ due to the comments inserted by
$Log$, so they aren't really different.

Summary: even if we omit any changes which are enhancements rather than
bug fixes, there are still enough changes that we should seriously
consider releasing a pre5 version for testing.

--
Glynn Clements <glynn.clements@virgin.net>

[Glynn_Clements]

I've merged most of the recent changes into the release branch. A
summary of the outstanding differences follows.

The outstanding differences fall into two categories:

1. Substantial changes to individual modules; for these, I'd just like
confirmation that the result is stable enough for inclusion in the
pre5 release.

2. I18N-related changes to key components (GRASS startup, libgis,
tcltkgrass). For these, I would really like confirmation that building
without NLS (i.e. no "--with-nls" option) has been tested by as many
people as possible.

If any portability issues (e.g. assumptions regarding bash, GNU make,
Tcl/Tk version, head.<arch> settings etc) have slipped in, the result
could be completely unusable for some users.

I'm not concerned about it breaking if --with-nls is used; this *will*
fail on systems where dgettext() etc are in libintl rather than in
libc (e.g. Cygwin).

--

[Lines beginning with "+" indicate added files or directories; the
rest are changed files.]

tcltkgrass I18N (alex)
+ locale/ru/tcltkgrass/
  locale/Gmakefile
  src/tcltkgrass/tcltkgrass
  src/tcltkgrass/main/gis_set.tcl

libgis I18N (alex)
+ locale/ru/LC_MESSAGES/libgis.po
  src/libes/gis/Gmakefile
  src/libes/gis/*.c

Startup I18N (alex)
+ locale/ru/grass_intro.txt
+ locale/ru/license.txt
+ src/general/init/license.txt
  locale/Gmakefile
  src/general/init/Gmakefile
  src/general/init/init.sh

d.text.freetype update (cho): alignment, rotation, command mode
+ src/display/d.text.freetype/vflib/
+ src/display/d.text.freetype/test.input
  html/html/d.text.freetype.html
  src/display/d.text.freetype/Gmakefile
  src/display/d.text.freetype/freetypecap
  src/display/d.text.freetype/main.c

d.vect.pg update (alex): -e flag [*]
  html/html/d.vect.pg.html
  locale/ru/LC_MESSAGES/d.vect.pg.po
  src.garden/grass.postgresql/d.vect.pg/dbvect.h
  src.garden/grass.postgresql/d.vect.pg/getAllOpts.c
  src.garden/grass.postgresql/d.vect.pg/getSopts.c
  src.garden/grass.postgresql/d.vect.pg/main.c
  src.garden/grass.postgresql/d.vect.pg/runInfxFile.c

v.to.pg update (alex): -p flag (PostGIS)
  locale/ru/LC_MESSAGES/v.to.pg.po
  src.garden/grass.postgresql/v.to.pg/dbvect.h
  src.garden/grass.postgresql/v.to.pg/getAllOpts.c
  src.garden/grass.postgresql/v.to.pg/getSopts.c
  src.garden/grass.postgresql/v.to.pg/main.c
  src.garden/grass.postgresql/v.to.pg/plotCat.c
  src.garden/grass.postgresql/v.to.pg/runInfxFile.c

v.in.shape update (david)
  html/html/v.in.shape.html
  src/tcltkgrass/module/v.in.shape
  src/mapdev/v.in.shape/basename.c
  src/mapdev/v.in.shape/lines.c
  src/mapdev/v.in.shape/main.c
  src/mapdev/v.in.shape/polygon.c
  src/mapdev/v.in.shape/vmap_import.c

[*] html/html/d.vect.pg.html has already been updated on the release
branch, but the actual code changes haven't been committed yet.

--
Glynn Clements <glynn.clements@virgin.net>

[Bernhard_Reiter]

On Mon, Jun 17, 2002 at 02:19:45AM +0100, Glynn Clements wrote:

I've merged most of the recent changes into the release branch.

Okay. So be it.
I would have preferred to just release it as 5.0.0 with
the critical bug fixes only.
Important now is to get 5.0.0pre5 out of the door
as we are within the schedule.

1. Substantial changes to individual modules; for these, I'd just like
confirmation that the result is stable enough for inclusion in the
pre5 release.

If you did not have this information, it is most likely that this
were not important bug fixes. Thus default should be to leave it out.

2. I18N-related changes to key components (GRASS startup, libgis,
tcltkgrass). For these, I would really like confirmation that building
without NLS (i.e. no "--with-nls" option) has been tested by as many
people as possible.

In my view: Not an important bug fix, leave it out.

Again this is just my opinion.
I hope that Markus will manage to bring a pre5 out soon.