[GRASS5] New thematic mapper for GRASS 6

On Wed, May 11, 2005 at 12:17:37PM -0700, Michael Barton wrote:

I'm glad it works. Let me know if you discover that I DO need to add this
patch.

As I already said, awk uses LOCALE settings, which can be confusing for the
people, who are working with national locales...

I send you two patches (for v.univar.sh and d.vect.thematic), both of them set
the env. variable LC_NUMERIC to "C", so awk will work properly independed of
what locale is set on the computer, where the script is run

If you could tweak d.legend to include vectors it would be GREAT. I could
include a button to draw a legend in the script.

Michael

Well, I was thinking about to write a new module... But the longer I thing
about it, the more thing I, that d.vect.leg & d.vect.thematic should be one
module in C with the flag -l (show legend).

OR color values used by d.vect.thematic should be saved in GRASS database...,
why do raster files have their $MAPSET/colr/file and vector files do not
(historical reasons, I know)? It
would be the simplest way of how to solve it...

new or modifed modules musted be written:

v.colors (based on d.vect.thematic)
d.vect (should take the color frome the colorfile)
d.legend -v (should make the legend)

Jachym
--
Jachym Cepicky
e-mail: jachym.cepicky@centrum.cz
URL: http://les-ejk.cz
GPG: http://www.fle.czu.cz/~jachym/gnupg_public_key/

(attachments)

v.univar.sh.patch (99 Bytes)
d.vect.thematic.patch (103 Bytes)

Hi,

On Èt, 12 kvì 2005, Jachym Cepicky wrote:

OR color values used by d.vect.thematic should be saved in GRASS database...,
why do raster files have their $MAPSET/colr/file and vector files do not
(historical reasons, I know)? It
would be the simplest way of how to solve it...

I am not sure about it, I see colors as attributes ... so I think color values
should be stored in attribute table instead of new file in GRASS database ...
Am I wrong?

Maybe to add a new flag to d.vect.thematic (-s print sql) to store grassrgb?

d.vect.thematic -s | db.execute

Martin

--
Martin Landa <landa@gama.fsv.cvut.cz> * http://gama.fsv.cvut.cz/~landa *
CTU Prague, Faculty of Civil Engineering, Czech Republic

hi
On Thu, May 12, 2005 at 11:39:20AM +0200, Martin Landa wrote:

Maybe to add a new flag to d.vect.thematic (-s print sql) to store grassrgb?

d.vect.thematic -s | db.execute

Martin

I added the -u flag, which serves for updating the color values to database. it also
looks, if there is any GRASSRGB column in the table..

unfortunatly d.vect.thematic (without -u flag) seems to be faster, than
d.vect -a

d.vect.thematic could be renamed to v.thematic... or even v.colors :slight_smile: ?

Jachym

--
Jachym Cepicky
e-mail: jachym.cepicky@centrum.cz
URL: http://les-ejk.cz
GPG: http://www.fle.czu.cz/~jachym/gnupg_public_key/

(attachments)

d.vect.thematic.patch (9.76 KB)

On Thu, May 12, 2005 14:47, Jachym Cepicky said:

hi
On Thu, May 12, 2005 at 11:39:20AM +0200, Martin Landa wrote:

Maybe to add a new flag to d.vect.thematic (-s print sql) to store grassrgb?

d.vect.thematic -s | db.execute

Martin

I added the -u flag, which serves for updating the color values to database.
it also
looks, if there is any GRASSRGB column in the table..

Great ! But watch out: I think the patch is not against the latest version of
the code which fixes the bug of a possible missing value in the first
category...

d.vect.thematic could be renamed to v.thematic... or even v.colors :slight_smile: ?

I think d.vect.thematic is better as the module is clearly a display module.

Moritz

hallo
On Thu, May 12, 2005 at 04:21:51PM +0200, Moritz Lennert wrote:

Great ! But watch out: I think the patch is not against the latest version of
the code which fixes the bug of a possible missing value in the first
category...

sorry,

now I patched the file against patched d.vect.thematic from Martin Landa

>
> d.vect.thematic could be renamed to v.thematic... or even v.colors :slight_smile: ?

I think d.vect.thematic is better as the module is clearly a display module.
Moritz

well, now it is display & update module

Jáchym
--
Jachym Cepicky
e-mail: jachym.cepicky@centrum.cz
URL: http://les-ejk.cz
GPG: http://www.fle.czu.cz/~jachym/gnupg_public_key/

(attachments)

d.vect.thematic.patch (10.1 KB)

Please supply patches in the unified context format:

diff -u

see point ~ 25 in the SUBMITTING file.

I've got an alias set up in my .bashrc so this happens automatically:

alias diff='diff -u'

or if you use cvs to make diffs, create .cvsrc:
-z3
diff -u
update -dP

Then patches are quickly & safely applied with the 'patch' command, e.g.:

patch -p0 < patch.diff

thanks,
Hamish