[GRASS5] [PATCH] v.what: doesn't substract isles'areas

GRASS GRASS developer
1

Hello,

The subject says it all. d.what.vect and v.what were not in sync, d.what.vect
was correctly substracting the areas of the islands, when v.what was not.

The patch is simply derived from d.what.vect.

--
Thierry Laronde (Alceste) <tlaronde@polynum.org>
Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C

(attachments)

patch-src::src::mapdev::v.what::cmd::what.c (1.45 KB)

2

On Sunday 31 August 2003 23:18, Thierry Laronde wrote:

Hello,

The subject says it all. d.what.vect and v.what were not in sync,
d.what.vect was correctly substracting the areas of the islands, when
v.what was not.

The patch is simply derived from d.what.vect.

I have commited to cvs.

Ra

3

On Mon, Sep 08, 2003 at 12:02:51PM +0200, Radim Blazek wrote:

On Sunday 31 August 2003 23:18, Thierry Laronde wrote:
> Hello,
>
> The subject says it all. d.what.vect and v.what were not in sync,
> d.what.vect was correctly substracting the areas of the islands, when
> v.what was not.
>
> The patch is simply derived from d.what.vect.

I have commited to cvs.

Should this go into the release_branch?
Yes, first someone should test the updated v.what in Lat/Long, UTM etc.

But keeping the bug in 5.0.3 I don't like too much...

Markus

4

On Mon, Sep 08, 2003 at 04:23:49PM +0200, Markus Neteler wrote:

On Mon, Sep 08, 2003 at 12:02:51PM +0200, Radim Blazek wrote:
> On Sunday 31 August 2003 23:18, Thierry Laronde wrote:
> > Hello,
> >
> > The subject says it all. d.what.vect and v.what were not in sync,
> > d.what.vect was correctly substracting the areas of the islands, when
> > v.what was not.
> >
> > The patch is simply derived from d.what.vect.
>
> I have commited to cvs.

Should this go into the release_branch?
Yes, first someone should test the updated v.what in Lat/Long, UTM etc.

But keeping the bug in 5.0.3 I don't like too much...

Agreed.

For the tests, I think that G_begin_polygon_area_calculations() handles all
the conversions? [This is not humor, merely a question since I have only made
a quick comparison/search to fix this bug that was critical, at least for
what I was doing at the moment :wink: I'm only scratching the surface of GRASS
and there may be subtleties that I have missed].

+ /*
+ inititalizations needed to do area calculations for
+ grid cells, based on the current window "projection" field.
+ */
+ G_begin_polygon_area_calculations();

Cheers,

--
Thierry Laronde (Alceste) <tlaronde@polynum.org>
Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C