[GRASS5] Re: [GRASS-CVS] frankw: grass/src/raster/r.in.gdal main.c,1.13,1.13.2.1

GRASS GRASS developer
,
1

On Fri, May 17, 2002 at 03:37:06PM +0200, grass@intevation.de wrote:

Author: frankw

Update of /grassrepository/grass/src/raster/r.in.gdal
In directory doto:/tmp/cvs-serv7101

Modified Files:
      Tag: releasebranch_26_april_2002_5_0_0
  main.c
Log Message:
convert ellps value to lower case per RT bug 1047

Is this really release critical bug?
IMO it looks more like it should be only into HEAD.

+ /* All the ellipsoid keys in GRASS are lower case. Eventually we
+ may need to remove this hack. See bug 1047 in RT bug tracker. */
+ if( G_strcasecmp(pszToken,"ellps") == 0 )
+ G_tolcase( pszValue );

2

On Fri, May 17, 2002 at 03:53:04PM +0200, Bernhard Reiter wrote:

On Fri, May 17, 2002 at 03:37:06PM +0200, grass@intevation.de wrote:
> Author: frankw
>
> Update of /grassrepository/grass/src/raster/r.in.gdal
> In directory doto:/tmp/cvs-serv7101
>
> Modified Files:
> Tag: releasebranch_26_april_2002_5_0_0
> main.c
> Log Message:
> convert ellps value to lower case per RT bug 1047

Is this really release critical bug?
IMO it looks more like it should be only into HEAD.

> + /* All the ellipsoid keys in GRASS are lower case. Eventually we
> + may need to remove this hack. See bug 1047 in RT bug tracker. */
> + if( G_strcasecmp(pszToken,"ellps") == 0 )
> + G_tolcase( pszValue );

This fix should be both in HEAD and releasebranch_26_april_2002_5_0_0.

Markus

3

On Fri, May 17, 2002 at 03:58:06PM +0200, Markus Neteler wrote:

> > Update of /grassrepository/grass/src/raster/r.in.gdal
> > In directory doto:/tmp/cvs-serv7101
> >
> > Modified Files:
> > Tag: releasebranch_26_april_2002_5_0_0
> > main.c
> > Log Message:
> > convert ellps value to lower case per RT bug 1047

This fix should be both in HEAD and releasebranch_26_april_2002_5_0_0.

Frank, can you also commit the fix to HEAD?
Thanks.

4

Markus Neteler wrote:

This fix should be both in HEAD and releasebranch_26_april_2002_5_0_0.

Now that pre4 has been released, all fixes should go into HEAD. That
will make it easier to merge such changes for pre5.

--
Glynn Clements <glynn.clements@virgin.net>

5

On Fri, May 17, 2002 at 04:30:10PM +0100, Glynn Clements wrote:

Markus Neteler wrote:

> This fix should be both in HEAD and releasebranch_26_april_2002_5_0_0.

Now that pre4 has been released, all fixes should go into HEAD. That
will make it easier to merge such changes for pre5.

No, this is not our strategy.
We want a _tested_ release. Pre4 is a release candidat.
Unless some serious reasons come up,
there will be no pre5, but a 5.0.0 of that branch.

Please only fix release critical bugs!
And fix them on both the release branch and HEAD.

Glynn: You also had one fix which only went into the release branch, please
also merge it into the HEAD.

6

Bernhard Reiter wrote:

No, this is not our strategy.
We want a _tested_ release. Pre4 is a release candidat.
Unless some serious reasons come up,
there will be no pre5, but a 5.0.0 of that branch.

Please only fix release critical bugs!
And fix them on both the release branch and HEAD.

Bernhard,

I assume you mean only fix release critical bugs in the release branch, right?
Non critical bugs can still be fixed in the HEAD for 5.0.x point releases
right?

I have removed by patch from the release branch, and successfully applied it
to the head.

Best regards,

--
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up | Frank Warmerdam, warmerdam@pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush | Geospatial Programmer for Rent

7

On Fri, May 17, 2002 at 03:10:31PM -0400, Frank Warmerdam wrote:

Bernhard Reiter wrote:
>No, this is not our strategy.
>We want a _tested_ release. Pre4 is a release candidat.
>Unless some serious reasons come up,
>there will be no pre5, but a 5.0.0 of that branch.
>
>Please only fix release critical bugs!
>And fix them on both the release branch and HEAD.

Bernhard,

I assume you mean only fix release critical bugs in the release branch,
right?

Yes.

Non critical bugs can still be fixed in the HEAD for 5.0.x point releases
right?

Correct.

I have removed by patch from the release branch, and successfully applied it
to the head.

Thanks!