[pgrouting-dev] pgr_minCostMaxFlow

hi all

There are this functions created by a GSoC student:
pgr_minCostMaxFlow (gives the details)

pgr_minCostMaxFlow_Cost (only gives the cost)
They will be experimental on version 3.0 of pgRouting

This family exists from some time

https://docs.pgrouting.org/dev/en/flow-family.html

The student created a special family so this family of function I will remove

https://docs.pgrouting.org/dev/en/costFlow-family.html
And the 2 functions will be on the flow-family

I am just concerned about the names
pgr_minCostMaxFlow VS pgr_maxFlowMinCost

pgr_minCostMaxFlow_Cost
VS

pgr_minCostMaxFlowCost (On our Cost functions we dont use an underscore)
VS

pgr_maxFlowMinCostCost
VS

pgr_maxFlowMinCostValue (it returns only one number)
VS
pgr_maxFlow with an additional parameter

pgr_maxFlow(edges_sql, source,  target, min_cost)

where min_cost is of type boolean and the default is false
Note that for this case the “experimental function” would be pgr_maxFlow when the

min_cost := true"

I will start moving the functions to the Flow Family, but I would like your opinions on the names. Even that they are experimental and can change name afterwards, I would prefer to have them with their possible definitive name for 3.0 release.

Please give me your opinions

Vicky

Georepublic UG (haftungsbeschränkt)
Salzmannstraße 44, 
81739 München, Germany

Vicky Vergara
Operations Research

eMail: vicky@[georepublic.de](http://georepublic.de)
Web: [https://georepublic.info](https://georepublic.info)

Tel: +49 (089) 4161 7698-1
Fax: +49 (089) 4161 7698-9

Commercial register: Amtsgericht München, HRB 181428
CEO: Daniel Kastl

pgr_maxFlow with an additional parameter

pgr_maxFlow(edges_sql, source,  target, min_cost)

where min_cost is of type boolean and the default is false
Note that for this case the “experimental function” would be pgr_maxFlow when the

min_cost := true"

Somehow I find the short name better because less confusing.
Putting everything into the function name makes it a bit less obvious, that it’s mainly a “maxFlow” function.

Not sure, if there are arguments against making min_cost a function parameter.
Since the functions were experimental I would not worry about name changes.

Daniel

···

Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: https://georepublic.info