I would like release core-geonetwork 4.4.7 and 4.2.12 on Match 18th or 19th.
Q: Does this date work for everyone?
Q: Do you have any pull requests that need attention prior to release?
Please reply to this thread to coordinate…
I am aware of a few pull requests wishing to make the cut:
No objection from my part, but I’d really like https://github.com/geonetwork/core-geonetwork/pull/8644 in before this release. Thanks!
Thanks, I will watch that PR for changes.
Heard from @josegar74 - transfix translations need to be collected (and back ported to 4.2.x also).
The above are merged and ready to release; I will resume the release process on Monday.
A few missing translations noted, A small number of missing French translations · Issue #8711 · geonetwork/core-geonetwork · GitHub, if there are native French speakers available.
Thanks for your patience everyone.
Hi,
I will look into this early afternoon.
Jody, this PR should be merged before the release otherwise any build job will also build the Datahub plugin, which is going to have a huge impact: https://github.com/geonetwork/core-geonetwork/pull/8702
Thanks I had look, and made a PR with your commit and the results of testing and feedback: Do not build datahub by default by jodygarnett · Pull Request #8714 · geonetwork/core-geonetwork · GitHub
Going to pass this back to you across the timezone divide.
Inviting developers to double check the release artifacts before general announcement: GeoNetwork - Geographic Metadata Catalog - Browse /GeoNetwork_opensource/v4.4.7 at SourceForge.net
This includes the war:
And includes plugins:
Thanks!
Some notes:
@jahow I have run into trouble testing the new datahub plugin – it is empty!
If you are available to troubleshoot please reply.
Thus far I have confirmed that the release-build.sh is calls plugins/datahub-integration/pom.xml correctly.
Building myself locally - also now results in an empty zip and this was working last week.
Update: This was a build order trouble; jar being packaged before datahub copied into position. Building the second time worked which is why it was not caught during earlier testing.
Hi,
I think I know the problem, will make a PR with the fix soon.
Hi,
I tested the 4.4.7 release using the docker image, as well as the datahub plugin.
Observations:
It looks like the content of the release isn’t right maybe? Can someone else take a look?
Thanks!
- the datahub plugin is not empty anymore
That is correct, I checked out the tag and built twice.
The pom.xml has a build order issue where creates the jar before copying the datahub files into position. On the second build they are already in place - and thus the datahub plugin is not empty anymore.
- the interface of GeoNetwork does not seem to contain the changes from 4.4.7: no new settings for the datahub plugin, the application banner does not show up, and the keys I translated in French are still untranslated
Here is the 4.4.7 tag: Commits · geonetwork/core-geonetwork · GitHub
I see various commits in this history describing the datahub plugin, can you check that it contains the commits you expect?
adjust datahub-integration plugin for -Drelease activiation
Do not build the Datahub plugin unless -Pdatahub-integration is specified
datahub plugin configuration and style (#8695)
datahubs per sub-portal (#8644) · geonetwork/core-geonetwork@6c00343 · GitHub
As with the datahub plugin could this be a build issue? I was making use of release-build.sh which looks correct to me:
# Build the new release
mvn clean install -DskipTests -ntp -Pwar -Pwro4j-prebuild-cache
## plugins
(cd datastorages && mvn clean install -DskipTests -ntp -Drelease)
mvn clean install -DskipTests -ntp -Drelease -pl plugins/datahub-integration
@jahow I built the tag locally to confirm the commits are present:
application-banner:This seems okay?
update: Downloading geonetwork.war from source forge, and running in tomcat 9.0.102 shows the same result.
@jahow in the future can you take careful notes when testing and share what steps you are performing? Especially when working across timezones I do not have the ability to quickly respond and ask how your configuration is setup.
I am not sure why you did see the new functionality. Do you need to clear any caches or could it be connecting to another service you have running locally?
I have the following for Admin Console > Status > Version Information
aside: It would be nice if the plugins also reported their version information here
Testing datahub integration:
Downloading [gn-datahub-integration-4.4.7-0.zip](https://sourceforge.net/projects/geonetwork/files/GeoNetwork_opensource/v4.4.7/gn-datahub-integration-4.4.7-0.zip/download)
Following instructions here.
Simply unzip the gn-plugin-datahub-integration archive and copy its content in the
WEB-INF/libfolder of your GeoNetwork installation.
These instructions are outdated, as the bundle has README.html, jars in libs folder etc…
Following instructions in README.html
Copy the
libfolder jar files into to{GEONETWORK_DIR}/WEB-INF/libfolder.
shutdown.sh
cd webapps/geonetwork/WEB-INF/lib
cp ~/Downloads/gn-datahub-integration-4.4.7-0/lib/*.jar .
startup.sh
Following instructions to configure
It appears to be here just fine:
The datahub UI appears (and includes the banner which is nice)
Hi Jody,
Sorry for not giving more precise instructions. I didn’t have much time and was hoping that someone else could do a double-check, but I should have taken more care in raising the issue.
I tried again with the 4.4.7 docker image (pulling it fresh, apparently it changed?) and everything is fine.
Thank you so much for the communication and instructions on the Users ML!
Cheers,
Olivia
It is all good, releasing is a team activity.
And yes since I collected screen shots I thought it would be nice to share a “demo” with the user list.
General feedback for the team:
