[GeoNetwork-devel] Building Geonetwork from snapshot fails

Hi!
I am trying to build a clean install, using
mvn clean install
However, it fails every time with numerous errors in testing.
(too many to report here, but I can if it would help.
Is this usual, or to be expected?
Only this works.
mvn install -o -DskipTests

but I am worried that this will produce an unstable release.
Please advise.

Regards, Mats.E

···

GisKraft, Geodatakonsult

Mats Elfström, Marsvinsholms stationsväg 80, 271 93 Ystad, Sweden
tel: +46 70 595 39 35 / www.giskraft.se

Hello Mats,

On Tue, Apr 13, 2021 at 1:44 PM Mats Elfström <mats.elfstrom@anonymised.com> wrote:

Hi!
I am trying to build a clean install, using
mvn clean install
However, it fails every time with numerous errors in testing.
(too many to report here, but I can if it would help.
Is this usual, or to be expected?
Only this works.
mvn install -o -DskipTests

but I am worried that this will produce an unstable release.
Please advise.

please provide a bit more information about what/how are you building:

  • GeoNetwork version
  • Git branch / commit you have checked out
  • Commands you have run to clone/checkout the code
  • Command you have run to build GeoNetwork
  • Output of the commands failing.


Vriendelijke groeten / Kind regards,

Juan Luis Rodríguez.


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.

Mats:

I spent some time in october/november fixing the test cases that were failing on macOS and I have been careful to ensure that building works since. I note I am just working on 3.12.x until its contents are synchronized with main.

What branch are you building?

I note my most common ways of failing to build:

  • not grabbing the submodules, on initial checkout or when switching branches :stuck_out_tongue:
  • accidentally using java 11 :stuck_out_tongue:
  • not running “cd web; mvn clean:clean@anonymised.com” to remove the gn database and various caches

Keep an eye on software_development for tips and tricks, and I have some more incoming.


Jody Garnett

On Tue, 13 Apr 2021 at 04:44, Mats Elfström <mats.elfstrom@anonymised.com> wrote:

Hi!
I am trying to build a clean install, using
mvn clean install
However, it fails every time with numerous errors in testing.
(too many to report here, but I can if it would help.
Is this usual, or to be expected?
Only this works.
mvn install -o -DskipTests

but I am worried that this will produce an unstable release.
Please advise.

Regards, Mats.E

GisKraft, Geodatakonsult

Mats Elfström, Marsvinsholms stationsväg 80, 271 93 Ystad, Sweden
tel: +46 70 595 39 35 / www.giskraft.se

Virusfritt. www.avast.com

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hi Jody!
Thank you for your attention.
Please bear with me, I am a rookie here and had made a mistake.
I was working in an outdated GitHub fork. Because I thought that fetching origin would keep my fork updated against master/main.
So I threw everything out and started from scratch. Now I am working in a local clone of Main, and GN 4 compiles without problems, including my new and improved language files (plus some ui language related corrections). I am happy so far.
But now I need to figure out a way to add my work to the next release of GN.

Hälsning / Regards
Mats.E

Skickat från min / Sent from my iPad, Ursäkta att jag är kortfattad / Excuse my brevity.

22 apr. 2021 kl. 01:21 skrev Jody Garnett jody.garnett@anonymised.com:

Mats:

I spent some time in october/november fixing the test cases that were failing on macOS and I have been careful to ensure that building works since. I note I am just working on 3.12.x until its contents are synchronized with main.

What branch are you building?

I note my most common ways of failing to build:

  • not grabbing the submodules, on initial checkout or when switching branches :stuck_out_tongue:
  • accidentally using java 11 :stuck_out_tongue:
  • not running “cd web; mvn clean:clean@anonymised.com” to remove the gn database and various caches

Keep an eye on software_development for tips and tricks, and I have some more incoming.


Jody Garnett

On Tue, 13 Apr 2021 at 04:44, Mats Elfström <mats.elfstrom@anonymised.com> wrote:

Hi!
I am trying to build a clean install, using
mvn clean install
However, it fails every time with numerous errors in testing.
(too many to report here, but I can if it would help.
Is this usual, or to be expected?
Only this works.
mvn install -o -DskipTests

but I am worried that this will produce an unstable release.
Please advise.

Regards, Mats.E

GisKraft, Geodatakonsult

Mats Elfström, Marsvinsholms stationsväg 80, 271 93 Ystad, Sweden
tel: +46 70 595 39 35 / www.giskraft.se

Virusfritt. www.avast.com

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hello Mats,
thanks for contributing your changes to the project. Please take a look at https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md.
If the changes in languages are in the language JSON files they need to be imported in Transifex so we can keep them for the next releases.

···


Vriendelijke groeten / Kind regards,

Juan Luis Rodríguez.


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.

Checking back in Mats, did you figure out how to add your work in the the next release of geonetwork?

Let me check for a PR, looks like you got a contribution in: https://github.com/geonetwork/core-geonetwork/pull/5459

···


Jody Garnett