Dear PSC,
Groovy formatter is unused in GeoNetwork. As far as we know, It is also not used anymore in any projects. This is a proposal to remove it https://github.com/geonetwork/core-geonetwork/pull/7346
Looking forward to your vote.
Francois
+1 for me.
We use a very old version of groovy-all library, so unless someone commits to maintaining it, I think it should be removed.
Regards,
Jose García
|
|
|
Jose Garcia E-mail: jose.garcia@anonymised.com |
|
Veenderweg 13 6721 WD Bennekom The Netherlands Tel: +31318416664 |
|
|
---- On Wed, 27 Sep 2023 08:39:45 +0200 Francois Prunayre fx.prunayre@anonymised.com wrote —
Dear PSC,
Groovy formatter is unused in GeoNetwork. As far as we know, It is also not used anymore in any projects. This is a proposal to remove it https://github.com/geonetwork/core-geonetwork/pull/7346
Looking forward to your vote.
Francois
Hi All,
I don’t really know what groovy is or was used for though I recall seeing files relating to it in various schema plugins. It might be a silly question, but how would I know whether it’s actually being used or not?
Thanks
Jo
···
Jo Cook
Data Discovery Lead, Astun Technology
t:+44 7930 524 155 | twitter:@archaeogeek | mastodon:@archaeogeek@anonymised.com.
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009
Hi Jo, Groovy formatter ids are
- full_view (iso19139, iso19110, dublin-core),
- partial_view (only iso19139)
- xml_view
- hierarchy_view
To know if they are used, check the record view configuration in
https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/src/main/resources/catalog/js/CatController.js#L677-L704
By default, GeoNetwork is using the default AngularJS view and the XSL advanced view (xsl-view).
Cheers.
Francois
···
Jo Cook
Data Discovery Lead, Astun Technology
t:+44 7930 524 155 | twitter:@archaeogeek | mastodon:@archaeogeek@anonymised.com.
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009
Hi Jo
https://apps.titellus.net/geonetwork/srv/api/records/f6f8998d-d993-413d-a1be-9d007dda6385/formatters/full_view doesn’t work in GN 4 (error 400), tested with other metadata and other servers, the same error.
https://apps.titellus.net/geonetwork/srv/api/records/f6f8998d-d993-413d-a1be-9d007dda6385/formatters/xml_view similar to the XML formatter, apparently should display syntax highlight, but seem not working.
It was used time ago in a project as indicated by Francois, but it’s not used anymore.
Although the idea could be good, experiences trying to use it, were not that good: https://github.com/geonetwork/core-geonetwork/issues/1350
Regards,
Jose García
|
|
|
Jose Garcia E-mail: jose.garcia@anonymised.com |
|
Veenderweg 13 6721 WD Bennekom The Netherlands Tel: +31318416664 |
|
|
---- On Wed, 27 Sep 2023 12:07:20 +0200 Francois Prunayre fx.prunayre@anonymised.com wrote —
Hi Jo, Groovy formatter ids are
full_view (iso19139, iso19110, dublin-core),
partial_view (only iso19139)
xml_view
hierarchy_view
See
To know if they are used, check the record view configuration in
By default, GeoNetwork is using the default AngularJS view and the XSL advanced view (xsl-view).
Cheers.
Francois
Le mer. 27 sept. 2023 à 11:54, Jo Cook <jocook@anonymised.com> a écrit :
Hi All,
I don’t really know what groovy is or was used for though I recall seeing files relating to it in various schema plugins. It might be a silly question, but how would I know whether it’s actually being used or not?
Thanks
Jo
On Wed, Sep 27, 2023 at 8:09 AM Jose Garcia <jose.garcia@anonymised.com> wrote:
+1 for me.
We use a very old version of groovy-all library, so unless someone commits to maintaining it, I think it should be removed.
Regards,
Jose García
Jose Garcia
E-mail: jose.garcia@anonymised.com37…
Veenderweg 13
6721 WD Bennekom
The Netherlands
Tel: +31318416664
---- On Wed, 27 Sep 2023 08:39:45 +0200 Francois Prunayre <fx.prunayre@anonymised.com> wrote —
Dear PSC,
Groovy formatter is unused in GeoNetwork. As far as we know, It is also not used anymore in any projects. This is a proposal to remove it https://github.com/geonetwork/core-geonetwork/pull/7346
Looking forward to your vote.
Francois–
Jo Cook
Data Discovery Lead, Astun Technology
t:+44 7930 524 155 | twitter:@archaeogeek | mastodon:@archaeogeek@anonymised.comPlease note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009
–
Book a call with one of us
Sign up to our mailing list for any updates
iShare - enterprise geographic intelligence platform
GeoServer, PostGIS and QGIS training
Open Source SupportAstun Technology Ltd t:+44 1372 744 009 contact us online
web: astuntechnology.com twitter:@astuntech
Company registration no. 5410695. Registered in England and Wales. Registered office: Penrose House, 67 Hightown Road, Banbury, OX16 9BE VAT no. 864201149.
+1 from me, Francois - it was a good idea, but I think it was an overly cryptic implementation!
···
From: Jose Garcia jose.garcia@anonymised.com
Sent: 27 September 2023 17:09
To: Francois Prunayre fx.prunayre@anonymised.com
Cc: Jeroen Ticheler Jeroen.Ticheler@anonymised.com; Pigot, Simon (Environment, Hobart) Simon.Pigot@anonymised.com; Jo Cook <jocook@anonymised.com1036…>; Emanuele Tajariol e.tajariol@anonymised.com; Florent Gravin florent.gravin@anonymised.com; Paul van Genuchten genuchten@anonymised.com; Devel geonetwork-devel@lists.sourceforge.net geonetwork-devel@lists.sourceforge.net
Subject: Re: CFV / Groovy formatter removal
+1 for me.
We use a very old version of groovy-all library, so unless someone commits to maintaining it, I think it should be removed.
Regards,
Jose García
|
|
|
Jose Garcia E-mail: jose.garcia@anonymised.com |
|
Veenderweg 13 6721 WD Bennekom The Netherlands Tel: +31318416664 |
|
|
---- On Wed, 27 Sep 2023 08:39:45 +0200 Francois Prunayre fx.prunayre@anonymised.com wrote —
Dear PSC,
Groovy formatter is unused in GeoNetwork. As far as we know, It is also not used anymore in any projects. This is a proposal to remove it https://github.com/geonetwork/core-geonetwork/pull/7346
Looking forward to your vote.
Francois
+1 from me
---- On Wed, 27 Sep 2023 08:39:45 +0200 Francois Prunayre fx.prunayre@anonymised.com wrote —
Dear PSC,
Groovy formatter is unused in GeoNetwork. As far as we know, It is also not used anymore in any projects. This is a proposal to remove it https://github.com/geonetwork/core-geonetwork/pull/7346
Looking forward to your vote.
Francois
Hi all,
This work, pushed by Jesse, was really impressive. It was a great step to more sustainable, maintainable, and testable code, which is unfortunately not the case with all those XSL transformations.
Nevertheless, when Jesse left, this part of the code hadn’t been adopted by other code developers. I regret it but I understand it.
As this code is not maintained, I understand the desire to remove it. However, I was secretly hoping that one day some people would push energy to revive it.
So I vote 0 for my part.
Cheers !
···
Hi All,
Thanks for the background and explanation- I don’t think it impacts on any of the metadata profiles that we maintain so I am happy to vote +1 for removing it.
It would be helpful if we could have some documentation on what code, if anything, can be removed from the metaprofiles in light of this.
All the best
Jo
···
Jo Cook
Data Discovery Lead, Astun Technology
t:+44 7930 524 155 | twitter:@archaeogeek | mastodon:@archaeogeek@anonymised.com.
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009
Hi
Jo, from Gemini 2.3 4.2.x branch you’ll need to remove from https://github.com/metadata101/iso19139.gemini23/tree/4.2.x/src/main/plugin/iso19139.gemini23/formatter if the PR is merged:
-
full_view
-
groovy/iso19139
-
partial_view
Florent, about the code, I have no doubt that it can be impressive. Unfortunately, it hasn’t been maintained for years and uses an old/problematic version 2.4.21 (updated 2 years ago). It’s not clear to me why was not upgraded to at least 2.5.x, but it would probably also require code changes that no one could or knows how to manage. Currently, some formatters doesn’t work well with GN 4, as probably require also additional code changes.
I think when it was added everyone was excited. We actually tried using it, like other users, but we had some pretty cryptic problems trying to use in a production system for a customer. So after several days without any clear results we went back to the XSLT one.
As indicated in my vote, if someone is using it and is willing to update it and maintain it, it should be fine to keep it.
Regards,
Jose García
|
|
|
Jose Garcia E-mail: jose.garcia@anonymised.com |
|
Veenderweg 13 6721 WD Bennekom The Netherlands Tel: +31318416664 |
|
|
---- On Thu, 28 Sep 2023 10:42:24 +0200 Jo Cook jocook@anonymised.com wrote —
Hi All,
Thanks for the background and explanation- I don’t think it impacts on any of the metadata profiles that we maintain so I am happy to vote +1 for removing it.
It would be helpful if we could have some documentation on what code, if anything, can be removed from the metaprofiles in light of this.
All the best
Jo
On Thu, Sep 28, 2023 at 9:04 AM Florent Gravin <florent.gravin@anonymised.com.189…> wrote:
–
Jo Cook
Data Discovery Lead, Astun Technology
t:+44 7930 524 155 | twitter:@archaeogeek | mastodon:@archaeogeek@anonymised.comPlease note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009
–
Book a call with one of us
Sign up to our mailing list for any updates
iShare - enterprise geographic intelligence platform
GeoServer, PostGIS and QGIS training
Open Source SupportAstun Technology Ltd t:+44 1372 744 009 contact us online
web: astuntechnology.com twitter:@astuntech
Company registration no. 5410695. Registered in England and Wales. Registered office: Penrose House, 67 Hightown Road, Banbury, OX16 9BE VAT no. 864201149.
Hi all,
This work, pushed by Jesse, was really impressive. It was a great step to more sustainable, maintainable, and testable code, which is unfortunately not the case with all those XSL transformations.
Nevertheless, when Jesse left, this part of the code hadn’t been adopted by other code developers. I regret it but I understand it.
As this code is not maintained, I understand the desire to remove it. However, I was secretly hoping that one day some people would push energy to revive it.
So I vote 0 for my part.
Cheers !
On Wed, Sep 27, 2023 at 9:17 PM Jeroen Ticheler <jeroen.ticheler@anonymised.com437…> wrote:
+1 from me
---- On Wed, 27 Sep 2023 08:39:45 +0200 Francois Prunayre <fx.prunayre@anonymised.com> wrote —
Dear PSC,
Groovy formatter is unused in GeoNetwork. As far as we know, It is also not used anymore in any projects. This is a proposal to remove it https://github.com/geonetwork/core-geonetwork/pull/7346
Looking forward to your vote.
Francois–