Hi Francois,
+1 for me.
I have a minor concern about the file where such filters are defined:
I don't see them fit in a file that describes the basics of the schema.
Since those filters are applied only during view/editing, probably a file in
present/ would suit better.
Ciao,
Emanuele
Alle 12:33:05 di Thursday 17 April 2014, Francois Prunayre ha scritto:
2014-04-17 12:13 GMT+02:00 Jose Garcia <jose.garcia@anonymised.com>:
> Hi Francois
>
> The proposal looks fine to me, just a question about this comment:
>
> It only applies filters when user access a record in view mode, xml, csw,
> ...
>
>
> Does it work also for the harvesters, when other catalog uses the
> GeoNetwork or CSW harvester against "our" catalog with this feature?
Yes. This is the benefit of having the filter in XMLSerializer instead of
some places of the XSLTs which were checking the dynamic/download state for
the current user. So filters are also applied when a node harvest the
catalog (ie. using CSW GetRecordById, mef.export or xml.metadata.get).
Francois
> Regards,
> Jose García
>
> On Tue, Apr 15, 2014 at 5:02 PM, Jose Garcia
<jose.garcia@anonymised.com>wrote:
>> Thanks, will check in the morning the proposal in more detail and will
>> provide any feedback or the vote.
>>
>> Regards,
>> Jose García
>>
>>
>> On Tue, Apr 15, 2014 at 4:45 PM, Francois Prunayre
>> <fx.prunayre@anonymised.com
>>
>> > wrote:
>>> 2014-04-15 16:40 GMT+02:00 Jose Garcia <jose.garcia@anonymised.com>:
>>> > Hi Francois
>>>
>>> > We're working to finish this proposal:
>>> https://github.com/geonetwork/core-geonetwork/wiki/Dublin-Core-Related-
>>> Resources, and hope this week can send for voting.
>>>
>>> Good to have file upload in dublin core too!
>>>
>>> > Do you see any impact between the 2? Should we manage any additional
>>>
>>> stuff in our proposal to support this proposal?
>>>
>>>
>>> No, with your proposal you get the resource.get service allowing access
>>> or not according to the download operation. But user will still see the
>>> links in the metadata. With this proposal, it could also be filtered
>>> (and as such not displayed) using a filter in schema-ident.xml for
>>> dublin-core
>>>
>>> with something like :
>>> <filter xpath="*//dct:references[contains(text(), 'resource.get')]"
>>>
>>> ifNotOperation="download"/>
>>>
>>> Cheers.
>>>
>>> Francois
>>>
>>> > Regards,
>>> > Jose García
>>> >
>>> >
>>> >
>>> > On Tue, Apr 15, 2014 at 4:31 PM, Francois Prunayre <
>>>
>>> fx.prunayre@anonymised.com> wrote:
>>> >> Dear PSC,
>>> >>
>>> >> Here is the proposal to provide custom filters (defined per schema)
>>>
>>> to be applied to the edit/download/dynamic operations:
>>> https://github.com/geonetwork/core-geonetwork/wiki/Custom-Privileges-Fi
>>> lter
>>>
>>> >> You can find the code changes in this pull request:
>>> https://github.com/geonetwork/core-geonetwork/pull/454
>>>
>>> >> Looking forward to your votes.
>>> >>
>>> >> Thanks.
>>> >>
>>> >> Francois
--
Ing. Emanuele Tajariol
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 380 2116282
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------