[GeoNetwork-devel] CFV / Remove deprecated services from develop branch

Dear PSC

There’s an ongoing effort to migrate the old services in Jeeves to the new API with Spring MVC.

All migrated services have been annotated with @Deprecated annotation. We’re keeping them in 3.2.x, but would like to propose to remove them in the develop branch for the future 3.4 version.

That should allow to cleanup the code and avoid any security risks related to all this code.

These a risks for applications using the old API, but as this change is applied in develop branch, I think should be time enough for developers to change their applications to use the new API until version 3.4 is released.

Looking for your vote about this proposal. If accepted I’ll prepare a pull request removing all deprecated services.

Regards,
Jose García

···

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.

Dear Jose, +1 for me on this proposal as it will improve the code quality, simplify usage via the API, improve the security and reduce the code to maintain even if it will drop support to ExtJS UI that some users may still be using and will probably break compatibility with old GN node harvesting with GN protocol (that could be replaced by CSW).

Cheers.

Francois

···

2017-03-21 12:22 GMT+01:00 Jose Garcia <jose.garcia@anonymised.com>:

Dear PSC

There’s an ongoing effort to migrate the old services in Jeeves to the new API with Spring MVC.

All migrated services have been annotated with @Deprecated annotation. We’re keeping them in 3.2.x, but would like to propose to remove them in the develop branch for the future 3.4 version.

That should allow to cleanup the code and avoid any security risks related to all this code.

These a risks for applications using the old API, but as this change is applied in develop branch, I think should be time enough for developers to change their applications to use the new API until version 3.4 is released.

Looking for your vote about this proposal. If accepted I’ll prepare a pull request removing all deprecated services.

Regards,
Jose García

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


GeoNetwork-devel mailing list
GeoNetwork-devel@…537…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hi Francois

Thanks for your feedback, see some comments inline.

Regards,
Jose García

···

On Wed, Mar 22, 2017 at 7:23 AM, Francois Prunayre <fx.prunayre@anonymised.com> wrote:

Dear Jose, +1 for me on this proposal as it will improve the code quality, simplify usage via the API, improve the security and reduce the code to maintain even if it will drop support to ExtJS UI that some users may still be using

That’s not optimal, would be good to check with the customers that still are using ExtJS UI if the reason is that they are missing any feature in the AngularJs UI, so can be check in following months to migrate them.

Also this is for future version 3.4, so will not affect current stable version.

and will probably break compatibility with old GN node harvesting with GN protocol (that could be replaced by CSW).

Maybe we can check to add urlrewrite rules to handle this, but not sure if that will solve the issue.

In any case, I understand that will require to change the GN harvester in current develop to use the new API services (if this is not done yet)

Cheers.

Francois

2017-03-21 12:22 GMT+01:00 Jose Garcia <jose.garcia@anonymised.com>:

Dear PSC

There’s an ongoing effort to migrate the old services in Jeeves to the new API with Spring MVC.

All migrated services have been annotated with @Deprecated annotation. We’re keeping them in 3.2.x, but would like to propose to remove them in the develop branch for the future 3.4 version.

That should allow to cleanup the code and avoid any security risks related to all this code.

These a risks for applications using the old API, but as this change is applied in develop branch, I think should be time enough for developers to change their applications to use the new API until version 3.4 is released.

Looking for your vote about this proposal. If accepted I’ll prepare a pull request removing all deprecated services.

Regards,
Jose García

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comorge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.

2017-03-22 8:03 GMT+01:00 Jose Garcia <jose.garcia@anonymised.com>:

Hi Francois

Thanks for your feedback, see some comments inline.

Regards,
Jose García

On Wed, Mar 22, 2017 at 7:23 AM, Francois Prunayre <fx.prunayre@anonymised.com>
wrote:

Dear Jose, +1 for me on this proposal as it will improve the code
quality, simplify usage via the API, improve the security and reduce the
code to maintain even if it will drop support to ExtJS UI that some users
may still be using

That's not optimal, would be good to check with the customers that still
are using ExtJS UI if the reason is that they are missing any feature in
the AngularJs UI, so can be check in following months to migrate them.

The main reason I'm aware of is that some custom schemas are only
configured with ExtJS and not yet with Angular. It will be a good reason to
migrate.

Francois

Also this is for future version 3.4, so will not affect current stable
version.

and will probably break compatibility with old GN node harvesting with GN
protocol (that could be replaced by CSW).

Maybe we can check to add urlrewrite rules to handle this, but not sure if
that will solve the issue.

In any case, I understand that will require to change the GN harvester in
current develop to use the new API services (if this is not done yet)

Cheers.

Francois

2017-03-21 12:22 GMT+01:00 Jose Garcia <jose.garcia@anonymised.com>:

Dear PSC

There's an ongoing effort to migrate the old services in Jeeves to the
new API with Spring MVC.

All migrated services have been annotated with @Deprecated annotation.
We're keeping them in 3.2.x, but would like to propose to remove them in
the develop branch for the future 3.4 version.

That should allow to cleanup the code and avoid any security risks
related to all this code.

These a risks for applications using the old API, but as this change is
applied in develop branch, I think should be time enough for developers to
change their applications to use the new API until version 3.4 is released.

Looking for your vote about this proposal. If accepted I'll prepare a
pull request removing all deprecated services.

Regards,
Jose García

--

*Vriendelijke groeten / Kind regards,Jose García
<http://www.geocat.net/&gt;Veenderweg 136721 WD BennekomThe NetherlandsT: +31
(0)318 416664 <+31318416664> <https://www.facebook.com/geocatbv&gt;
<https://twitter.com/geocat_bv&gt;
<https://plus.google.com/u/1/+GeocatNetbv/posts&gt;Please consider the
environment before printing this email.*

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/project
s/geonetwork

--

*Vriendelijke groeten / Kind regards,Jose García
<http://www.geocat.net/&gt;Veenderweg 136721 WD BennekomThe NetherlandsT: +31
(0)318 416664 <+31318416664> <https://www.facebook.com/geocatbv&gt;
<https://twitter.com/geocat_bv&gt;
<https://plus.google.com/u/1/+GeocatNetbv/posts&gt;Please consider the
environment before printing this email.*