[GeoNetwork-devel] Create metadata privileges

Hi

When creating a new metadata, by default it gets only the View privilege in the owner group, so other users in the group

There is a flag that allows to share it with other editors of the group, so they can edit.

But the download and interactive map privilege are linked to the previous flag. See: https://github.com/geonetwork/core-geonetwork/blob/bc20706cf959af1b649cab0d0ce688f9cf1d67f9/core/src/main/java/org/fao/geonet/kernel/datamanager/base/BaseMetadataOperations.java#L343-L351

Is there any reason for this? Why users of the group owner can view the metadata by default, but not it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664

Hi

Apologies I left a parragraph incomplete:

… so other users in the group can view the metadata, but not access it’s resources.

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664

---- On Wed, 13 Dec 2023 13:04:19 +0100 Jose Garcia jose.garcia@anonymised.com wrote —

Hi

When creating a new metadata, by default it gets only the View privilege in the owner group, so other users in the group

There is a flag that allows to share it with other editors of the group, so they can edit.

But the download and interactive map privilege are linked to the previous flag. See: https://github.com/geonetwork/core-geonetwork/blob/bc20706cf959af1b649cab0d0ce688f9cf1d67f9/core/src/main/java/org/fao/geonet/kernel/datamanager/base/BaseMetadataOperations.java#L343-L351

Is there any reason for this? Why users of the group owner can view the metadata by default, but not it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664

Jose,

Assembling your email into:

Is there any reason for this? Why users of the group owner can view the metadata by default, but not access it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

It does not make sense to me, if you can view the record you should be able to view its resources also?

The only use for such a default would be if it was common for EDITORS to have a public record, and then want to attach internal resources (like PDFs) that were only intended to be used by EDITORS responsible for the public record.

I think that would be unusual, and limiting - and not suitable for a default case.

···


Jody Garnett

Hi Jody and Florent

I see this was changed by Florent in https://github.com/geonetwork/core-geonetwork/commit/003fda740bef3839a12403624a9b4781aa1812dd, previously the code was there, but commented.

I know it’s a long ago about this commit, “Add option to give all privileges to the group on MD creation”. I can see that can be useful for the edit privilege, but not for the dynamic and download ones.

I’ll do a PR to change this, but if you remember any good reason to keep the current behaviour let me know.

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664

---- On Tue, 30 Jan 2024 22:14:18 +0100 Jody Garnett <jody.garnett@…31…> wrote —

Jose,

Assembling your email into:

Is there any reason for this? Why users of the group owner can view the metadata by default, but not access it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

It does not make sense to me, if you can view the record you should be able to view its resources also?

The only use for such a default would be if it was common for EDITORS to have a public record, and then want to attach internal resources (like PDFs) that were only intended to be used by EDITORS responsible for the public record.

I think that would be unusual, and limiting - and not suitable for a default case.

Jody Garnett

On Dec 13, 2023 at 4:04:19 AM, Jose Garcia via GeoNetwork-devel <geonetwork-devel@lists.sourceforge.net> wrote:

Hi

When creating a new metadata, by default it gets only the View privilege in the owner group, so other users in the group

There is a flag that allows to share it with other editors of the group, so they can edit.

But the download and interactive map privilege are linked to the previous flag. See: https://github.com/geonetwork/core-geonetwork/blob/bc20706cf959af1b649cab0d0ce688f9cf1d67f9/core/src/main/java/org/fao/geonet/kernel/datamanager/base/BaseMetadataOperations.java#L343-L351

Is there any reason for this? Why users of the group owner can view the metadata by default, but not it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664


GeoNetwork-devel mailing list
GeoNetwork-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hi

I’ve added this pull request: https://github.com/geonetwork/core-geonetwork/pull/7679, please check to add any relevant feedback, thanks.

Regards,
Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664

---- On Wed, 31 Jan 2024 12:01:24 +0100 Jose Garcia via GeoNetwork-devel geonetwork-devel@lists.sourceforge.net wrote —

Hi Jody and Florent

I see this was changed by Florent in https://github.com/geonetwork/core-geonetwork/commit/003fda740bef3839a12403624a9b4781aa1812dd, previously the code was there, but commented.

I know it’s a long ago about this commit, “Add option to give all privileges to the group on MD creation”. I can see that can be useful for the edit privilege, but not for the dynamic and download ones.

I’ll do a PR to change this, but if you remember any good reason to keep the current behaviour let me know.

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664

---- On Tue, 30 Jan 2024 22:14:18 +0100 Jody Garnett <jody.garnett@anonymised.com> wrote —

blockquote>


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Jose,

Assembling your email into:

Is there any reason for this? Why users of the group owner can view the metadata by default, but not access it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

It does not make sense to me, if you can view the record you should be able to view its resources also?

The only use for such a default would be if it was common for EDITORS to have a public record, and then want to attach internal resources (like PDFs) that were only intended to be used by EDITORS responsible for the public record.

I think that would be unusual, and limiting - and not suitable for a default case.

Jody Garnett

On Dec 13, 2023 at 4:04:19 AM, Jose Garcia via GeoNetwork-devel <geonetwork-devel@lists.sourceforge.net> wrote:

Hi

When creating a new metadata, by default it gets only the View privilege in the owner group, so other users in the group

There is a flag that allows to share it with other editors of the group, so they can edit.

But the download and interactive map privilege are linked to the previous flag. See: https://github.com/geonetwork/core-geonetwork/blob/bc20706cf959af1b649cab0d0ce688f9cf1d67f9/core/src/main/java/org/fao/geonet/kernel/datamanager/base/BaseMetadataOperations.java#L343-L351

Is there any reason for this? Why users of the group owner can view the metadata by default, but not it’s resources unless you use the previous flag to allow to edit the metadata by other Editors?

Regards,

Jose García

Jose Garcia

E-mail: jose.garcia@anonymised.com

https://www.geocat.net

Veenderweg 13

6721 WD Bennekom

The Netherlands

Tel: +31318416664


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

</

Hi,

Yes it was in 2012, my very first commits in GN :smiling_face:
I don’t remember the context, but I agree with the new logic, it makes more sense !

Thanks

···

This is Florent Gravin's card. Their email is florent.gravin@anonymised.com