[GeoNetwork-devel] Fix issue in harvesting OGC WxS

GeoNetwork GeoNetwork Developer
1

Dear list,

my apologies for not bringing this up on the list sooner, I am new to Geonetwork and not aware of all procedures (pointers appreciated).

I created a PR for fixing an issue with harvesting WxS services [1]. I brought up the issue before on the discuss list, but now was glad I found the time to fix it that I created the PR before asking you guys.

Feedback is highly welcome on these changes, as they also concern current 3.x version, at least as far as I can see. Should I create a PR to the current developments and backport after it was accepted?

Best regards,
Daniel

[1] https://github.com/geonetwork/core-geonetwork/pull/1351 (As the setup concerns me using 2.10.x I created the PR to that branch.)

--
Daniel Nüst
52°North Initiative for Geospatial Open Source Software GmbH
Martin-Luther-King-Weg 24
48155 Münster, Germany
E-Mail: d.nuest@anonymised.com
Fon: +49-(0)-251–396371-36
Fax: +49-(0)-251–396371-11

http://52north.org/
Twitter: @FiveTwoN

General Managers: Dr. Albert Remke, Dr. Andreas Wytzisk
Local Court Muenster HRB 10849

2

Hi Daniel,

···

2015-12-16 10:08 GMT+01:00 Daniel Nüst <d.nuest@anonymised.com4…>:

Dear list,

my apologies for not bringing this up on the list sooner, I am new to
Geonetwork and not aware of all procedures (pointers appreciated).

I created a PR for fixing an issue with harvesting WxS services [1]. I
brought up the issue before on the discuss list, but now was glad I
found the time to fix it that I created the PR before asking you guys.

Feedback is highly welcome on these changes, as they also concern
current 3.x version, at least as far as I can see. Should I create a PR
to the current developments and backport after it was accepted?

For minor features and fix like this one, you should make a PR to branch 3.0.x https://github.com/geonetwork/core-geonetwork/tree/3.0.x. For major features, the PR should target develop.

Cheers.

Francois

Best regards,
Daniel

[1] https://github.com/geonetwork/core-geonetwork/pull/1351 (As the
setup concerns me using 2.10.x I created the PR to that branch.)

–
Daniel Nüst
52°North Initiative for Geospatial Open Source Software GmbH
Martin-Luther-King-Weg 24
48155 Münster, Germany
E-Mail: d.nuest@anonymised.com
Fon: +49-(0)-251–396371-36
Fax: +49-(0)-251–396371-11

http://52north.org/
Twitter: @FiveTwoN

General Managers: Dr. Albert Remke, Dr. Andreas Wytzisk
Local Court Muenster HRB 10849

GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

3

Am 16/12/2015 um 10:48 schrieb Francois Prunayre:

Hi Daniel,

2015-12-16 10:08 GMT+01:00 Daniel Nüst <d.nuest@anonymised.com
<mailto:d.nuest@anonymised.com>>:

    Dear list,

    my apologies for not bringing this up on the list sooner, I am new to
    Geonetwork and not aware of all procedures (pointers appreciated).

    I created a PR for fixing an issue with harvesting WxS services [1]. I
    brought up the issue before on the discuss list, but now was glad I
    found the time to fix it that I created the PR before asking you guys.

    Feedback is highly welcome on these changes, as they also concern
    current 3.x version, at least as far as I can see. Should I create a PR
    to the current developments and backport after it was accepted?

For minor features and fix like this one, you should make a PR to branch
3.0.x https://github.com/geonetwork/core-geonetwork/tree/3.0.x. For
major features, the PR should target develop.

Will do.

If the PR goes through there, how can I get it into 2.10?

/Daniel

    Best regards,
    Daniel

    [1] https://github.com/geonetwork/core-geonetwork/pull/1351 (As the
    setup concerns me using 2.10.x I created the PR to that branch.)

    --
    Daniel Nüst
    52°North Initiative for Geospatial Open Source Software GmbH
    Martin-Luther-King-Weg 24
    48155 Münster, Germany
    E-Mail: d.nuest@anonymised.com <mailto:d.nuest@anonymised.com>
    Fon: +49-(0)-251–396371-36 <tel:%2B49-%280%29-251%E2%80%93396371-36>
    Fax: +49-(0)-251–396371-11 <tel:%2B49-%280%29-251%E2%80%93396371-11>

    http://52north.org/
    Twitter: @FiveTwoN

    General Managers: Dr. Albert Remke, Dr. Andreas Wytzisk
    Local Court Muenster HRB 10849

    ------------------------------------------------------------------------------
    _______________________________________________
    GeoNetwork-devel mailing list
    GeoNetwork-devel@lists.sourceforge.net
    <mailto:GeoNetwork-devel@lists.sourceforge.net>
    https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
    GeoNetwork OpenSource is maintained at
    http://sourceforge.net/projects/geonetwork

--
Daniel Nüst
52°North Initiative for Geospatial Open Source Software GmbH
Martin-Luther-King-Weg 24
48155 Münster, Germany
E-Mail: d.nuest@anonymised.com
Fon: +49-(0)-251–396371-36
Fax: +49-(0)-251–396371-11

http://52north.org/
Twitter: @FiveTwoN

General Managers: Dr. Albert Remke, Dr. Andreas Wytzisk
Local Court Muenster HRB 10849