While at the code sprint I’m trying to sort out and extend the integration tests for GeoNetwork, sadly it seems as though a lot of changes have occurred to the GUI with out updates to the selenium/cucumber code. So my question is does anyone regularly run these tests? and if not do the current tests get ignored because it’s too hard to run them or that they were brittle and fail to easily for small changes?
Would it be beneficial to add them to a regular build server (Jenkins for example) or a git action (though that would probably be harder).
We (Astun) would be happy to provide a jenkins server that ran an expanded set of integration tests against stable branches if devs would be prepared to take responsibility for breakages to the GUI (0r updating the tests if you make changes)?
What do people think?
cheers
Ian
···
Ian Turton
Hi Ian and thanks for the initiative,
I don’t know of anyone who uses or relies on those tests. IIRC they were fragile and also complex to run since you needed to spin up a GN instance with a new database each time (sine the tests were altering the DB).
We have made estimations for a customer to achieve at least moderate coverage using this system, I could probably find the numbers but it was quite high (not sure what were the follow up of this). Maybe @Christophe Mangeat has a fresher memory on this topic.
Aprt from that, my very personal opinion is that such effort would be way better invested on the geonetwork-ui project which provides a healthier and safer framework for investments in the UI department.
Cheers,
···
–
camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS
Olivier Guyot
Geospatial Developer
+49 89 2620 89 924
Hi Ian,
So my question is does anyone regularly run these tests? and if not do the current tests get ignored because it’s too hard to run them or that they were brittle and fail to easily for small changes?
I don’t think anyone run them.
I don’t think it’s worth it to try to run e2e tests on AngularJS UI, any other opinion ? The code is not tested at all and quite huge. It would be a massive task.
I agree with Olivier that if it’s important to have the UI well tested (and it is), it’s better to invest on geonetwork-ui which use modern technologies and which have a huge test coverage of the UI code base (with Jest). Everything is also configured to write e2e tests with Cypress.
Cheers
Cheers
···
camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS
Florent Gravin
Technical Leader - Architect
+33 4 58 48 20 36