[GeoNetwork-devel] Jeeves configPath init param patch

Hi all,

I am working on a system where GeoNetwork is a dependency and I would need to run it for automated integration testing. Hence, it would be nice if I could have the configuration files out of WEB-INF, in order for the automatically deployed geonetwork war to read the configuration from an external directory.
To do so, I created the attached patch that allows JeevesServlet to read the config files from a directory specified in a servlet init parameter.

Do you think that'd be a useful contribution and if so could please consider committing it to trunk? Alternatively, I am eager of any feedback/alternate way to accomplish the same thing you might propose.

Best regards,
Gabriel

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

(attachments)

jeeves_configPath_initParam.patch (2.92 KB)

Further working on this I realize decoupling the configuration from the web application might be more a convoluted process than the afore mentioned patch. For instance, the McKoiActivator is being given the appPath instead of the configPath hence can't really decouple.

I wonder if there's any chance to consider making sure the full configuration can be externalized out of the app context and of so whether using the configPath instead of the appPath where relevant might suffice, or is it a too naive assumption?

Cheers,
Gabriel

Gabriel Roldan wrote:

Hi all,

I am working on a system where GeoNetwork is a dependency and I would need to run it for automated integration testing. Hence, it would be nice if I could have the configuration files out of WEB-INF, in order for the automatically deployed geonetwork war to read the configuration from an external directory.
To do so, I created the attached patch that allows JeevesServlet to read the config files from a directory specified in a servlet init parameter.

Do you think that'd be a useful contribution and if so could please consider committing it to trunk? Alternatively, I am eager of any feedback/alternate way to accomplish the same thing you might propose.

Best regards,
Gabriel

------------------------------------------------------------------------

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev

------------------------------------------------------------------------

_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Hello Gabriel,

2010/1/16 Gabriel Roldan <groldan@anonymised.com>:

Further working on this I realize decoupling the configuration from the
web application might be more a convoluted process than the afore
mentioned patch. For instance, the McKoiActivator is being given the
appPath instead of the configPath hence can't really decouple.

I wonder if there's any chance to consider making sure the full
configuration can be externalized out of the app context and of so
whether using the configPath instead of the appPath where relevant might
suffice, or is it a too naive assumption?

AFAIK, appPath is passed in all Jeeves services init methods, it's not
used so much.
You current issue is only for starting mckoi ? using your new config
file parameter should work fine in McKoiActivator.
Did you notice any other parameters which could not be externalized ?

Cheers.

Francois

Cheers,
Gabriel

Gabriel Roldan wrote:

Hi all,

I am working on a system where GeoNetwork is a dependency and I would
need to run it for automated integration testing. Hence, it would be
nice if I could have the configuration files out of WEB-INF, in order
for the automatically deployed geonetwork war to read the configuration
from an external directory.
To do so, I created the attached patch that allows JeevesServlet to read
the config files from a directory specified in a servlet init parameter.

Do you think that'd be a useful contribution and if so could please
consider committing it to trunk? Alternatively, I am eager of any
feedback/alternate way to accomplish the same thing you might propose.

Best regards,
Gabriel

------------------------------------------------------------------------

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev

------------------------------------------------------------------------

_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Hi Francois,

thanks for the reply and sorry for the late one of mine.

I'm heading a hard deadline these days, but will come back to you with more insights asap (which might mean a couple weeks from now though due to after-deadline-vacations)

Cheers,
Gabriel

Francois Prunayre wrote:

Hello Gabriel,

2010/1/16 Gabriel Roldan <groldan@anonymised.com>:

Further working on this I realize decoupling the configuration from the
web application might be more a convoluted process than the afore
mentioned patch. For instance, the McKoiActivator is being given the
appPath instead of the configPath hence can't really decouple.

I wonder if there's any chance to consider making sure the full
configuration can be externalized out of the app context and of so
whether using the configPath instead of the appPath where relevant might
suffice, or is it a too naive assumption?

AFAIK, appPath is passed in all Jeeves services init methods, it's not
used so much.
You current issue is only for starting mckoi ? using your new config
file parameter should work fine in McKoiActivator.
Did you notice any other parameters which could not be externalized ?

Cheers.

Francois

Cheers,
Gabriel

Gabriel Roldan wrote:

Hi all,

I am working on a system where GeoNetwork is a dependency and I would
need to run it for automated integration testing. Hence, it would be
nice if I could have the configuration files out of WEB-INF, in order
for the automatically deployed geonetwork war to read the configuration
from an external directory.
To do so, I created the attached patch that allows JeevesServlet to read
the config files from a directory specified in a servlet init parameter.

Do you think that'd be a useful contribution and if so could please
consider committing it to trunk? Alternatively, I am eager of any
feedback/alternate way to accomplish the same thing you might propose.

Best regards,
Gabriel

------------------------------------------------------------------------

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev

------------------------------------------------------------------------

_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.