Hi Developers,
Doing some more testing today of GN2.8, 27/7/12 snapshot,
today reminds me to this bug:
(see ticket http://trac.osgeo.org/geonetwork/ticket/960 )
Any chance of moving this bug up the priority list for a fix?
Not good how there is a side effect of altering the metadata.
Cheers,
Andrew
Andrew,
I was working on a patch on my spare time in the last couple weeks - it is
not fully complete - it seems to work however I'm not sure if it is the best
approach. Going to need some input from the experts....
Maybe you can test the patch to see what you think?
I have uploaded a patch to the ticket.
--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Open-for-edit-of-ISO19139-MCP-record-with-Z-date-time-resets-start-end-date-to-1970-01-01-tp4995835p4996462.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.
Hi Ian,
Thanks for the patch, I will try it out but...
I have downloaded your patch file as is (attached) and put into top
of my local core-gn git repo (just above 'web' folder).
I then run (to check before run 'git apply '):
git apply --check 0001-Fix-for-Ticket-960
but get error:
error: patch failed: web/src/main/webapp/scripts/editor/metadata-editor.js:929
error: web/src/main/webapp/scripts/editor/metadata-editor.js: patch does not apply
Obviously I am doing something wrong. What is the right way to apply this
patch? Do I need to edit the patch file in some way?
FYI: I am running msysgit 1.7.11 on windows XP
Thanks,
Andrew
----- Original Message ----- From: "ianwallen" <ianwallen@anonymised.com>
To: <geonetwork-devel@lists.sourceforge.net>
Sent: Tuesday, August 21, 2012 5:13 AM
Subject: Re: [GeoNetwork-devel] Open for edit of ISO19139-MCP record with 'Z' date/time resets start/end date to 1970-01-01
Andrew,
I was working on a patch on my spare time in the last couple weeks - it is
not fully complete - it seems to work however I'm not sure if it is the best
approach. Going to need some input from the experts....Maybe you can test the patch to see what you think?
I have uploaded a patch to the ticket.
--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Open-for-edit-of-ISO19139-MCP-record-with-Z-date-time-resets-start-end-date-to-1970-01-01-tp4995835p4996462.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
0001-Fix-for-Ticket-960.patch (10.2 KB)
Andrew,
I'm not sure what I did wrong. Try the following.
patch -p1 < 0001-Fix-for-Ticket-960.patch
Taken from the following site.
http://drupal.org/node/1129120
--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Open-for-edit-of-ISO19139-MCP-record-with-Z-date-time-resets-start-end-date-to-1970-01-01-tp4995835p4996628.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.
Ian,
Thanks that works now using 'patch -p1 ...' and have applied and tested the patch.
I am guessing that when I tried it with 'git apply' its sensitive to line
numbers so the patch fails.
See my results on the ticket: http://trac.osgeo.org/geonetwork/ticket/960
From code quality point of view it needs another developer to look at
now as I know very little about javascript and any side effect of your patch.
Thanks and Regards,
Andrew
----- Original Message ----- From: "ianwallen" <ianwallen@anonymised.com>
To: <geonetwork-devel@lists.sourceforge.net>
Sent: Tuesday, August 21, 2012 8:56 PM
Subject: Re: [GeoNetwork-devel] Open for edit of ISO19139-MCP record with 'Z' date/time resets start/end date to 1970-01-01
Andrew,
I'm not sure what I did wrong. Try the following.
patch -p1 < 0001-Fix-for-Ticket-960.patch
Taken from the following site.
http://drupal.org/node/1129120
--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Open-for-edit-of-ISO19139-MCP-record-with-Z-date-time-resets-start-end-date-to-1970-01-01-tp4995835p4996628.html
Sent from the GeoNetwork developer mailing list archive at Nabble.com.------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork