[GeoNetwork-devel] Proposal to remove the ISO19115-3 git submodule from 3.10.x branch and add it as part of the branch

Hi

Currently we have the ISO19115-3 schema in master as part of the branch and in 3.10.x still it’s a submodule.

This makes it difficult to cherry-pick commits from master involving changes to the ISO19115-3 schema. Some of the changes involve only code in that schema, so are quite isolated, but other changes also affect other modules making the backports a bit more complicated.

Are there any concerns about removing the ISO19115-3 submodule from 3.10.x and managing it as part of the branch as in master.

Regards,
Jose García

···

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.

FIne for me Jose.

Francois

Le lun. 21 sept. 2020 à 11:21, Jose Garcia <jose.garcia@anonymised.com> a écrit :

Hi

Currently we have the ISO19115-3 schema in master as part of the branch and in 3.10.x still it’s a submodule.

This makes it difficult to cherry-pick commits from master involving changes to the ISO19115-3 schema. Some of the changes involve only code in that schema, so are quite isolated, but other changes also affect other modules making the backports a bit more complicated.

Are there any concerns about removing the ISO19115-3 submodule from 3.10.x and managing it as part of the branch as in master.

Regards,
Jose García

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.


GeoNetwork-devel mailing list
GeoNetwork-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

I think it is a great idea :slight_smile:

Any chance we could change the schema version to 3.10.x while we do this? It would help allowing things like https://github.com/GeoCat/experiment-hnap to build straight from the maven repository without having to build geonetwork locally.

···

–
Jody Garnett

Hi

Nice, Jody is going to manage this for the 3.10.x branch, removing the submodule and copying the code for iso19115-3 from GeoNetwork master branch as it has been getting updates after the submodule was abandoned.

Regards,
Jose García

···

Vriendelijke groeten / Kind regards,

Jose García


Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664

Please consider the environment before printing this email.

Here is the PR for 3.10.x:

I also noted some changes to the README.md so there is a PR for master:

···

–
Jody Garnett

Reminder with this change I am reposting these instructions:

If you update with git pull you will get the following error:

From github.com:geonetwork/core-geonetwork
* branch master → FETCH_HEAD
= [up to date] master → upstream/master
error: The following untracked working tree files would be overwritten by merge:
schemas/iso19115-3.2018/ISO19115-3-2014-to-ISO19115-3-2018.xsl
schemas/iso19115-3.2018/ISO19139-to-ISO19115-3-2018.xsl

Here is how to update:

cd schemas
rm -r iso19115-3.2018

git pull
git checkout .

···

–
Jody Garnett