Hi
In GeoNetwork, there’re some third party libraries like bootstrap included as submodules (See https://github.com/geonetwork/core-geonetwork/blob/develop/.gitmodules#L8-L16)
Just want to check if this can be a potential issue as that submodules refer to the default branch in the projects (usually master).
Has anybody think about what would happen if any of these projects is upgraded to a major version and causes some incompatibility? Or for the third-party libraries used in GeoNetwork this can’t be a issue?
Also the code checkout can be different depending when GeoNetwork is cloned, no?
Would not be safer to manage these submodules pointing to a specific tag? For sure, will require some additional work to upgrade links at least for minor bug fixes releases.
Regards,
Jose García
···
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
Hi
Apologies as I got confused, as indicated by a colleague the submodule points to specific revision, so the potential problem I described can’t happen.
Sorry for the noise.
Regards,
Jose García
···
On Wed, May 18, 2016 at 12:55 PM, Jose Garcia <jose.garcia@anonymised.com> wrote:
Hi
In GeoNetwork, there’re some third party libraries like bootstrap included as submodules (See https://github.com/geonetwork/core-geonetwork/blob/develop/.gitmodules#L8-L16)
Just want to check if this can be a potential issue as that submodules refer to the default branch in the projects (usually master).
Has anybody think about what would happen if any of these projects is upgraded to a major version and causes some incompatibility? Or for the third-party libraries used in GeoNetwork this can’t be a issue?
Also the code checkout can be different depending when GeoNetwork is cloned, no?
Would not be safer to manage these submodules pointing to a specific tag? For sure, will require some additional work to upgrade links at least for minor bug fixes releases.
Regards,
Jose García
–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.
–
Vriendelijke groeten / Kind regards,
Jose García
Veenderweg 13
6721 WD Bennekom
The Netherlands
T: +31 (0)318 416664
Please consider the environment before printing this email.