I approved the PR for 4.4.x but the one for 4.2.x contains surprising changes (deletion of keys and reverting some values to English), could you please confirm that this is intentional?
That is intentional, the problem is that the Transifex translations only are updated with main branch, so if removed or added new keys, doesnât apply to 4.2.x branch and requires manual integration.
It should not cause regressions. I have done the following steps:
Download the translations from transifex, this step:
Updates translations common translations from 4.2.x and 4.4.x â> This is ok
Add new ones from 4.4.x that are not required in 4.2.x
Removes translations from 4.2.x that doesnât exist anymore in 4.4.x
For step 3, I have kept in the different translation files, the entries that are defined in the English version, using a Python script. So all translation files should have the same keys as the English ones.
For step 4, I have readded the missing translations from 4.2.x.
Got it, thanks for the clarification! I feel like in the future we could just bring in all the translations from 4.4.x without worrying too much about which is used or not.
@jahow It would be good to mention in the announcement of the releases to apply this change manually to fix the metadata full view map background image.
I guess most users doesnât use that view, but just in case.