[Geoserver-devel] a rest dispatcher callback interface

Hi all,

Recently I have been experimenting with the notion of a rest dispatcher callback, the same way we have a callback for ows based services.

Attached is the first cut of the patch. Let me know what you think. You will probably note in the patch that the exception() and finished() callbacks are not called. That is because I would like to build off of a recent patch from Andrea that involves a subclass of ServletConverter and invoke the callback methods there.

A couple of other questions. Should I throw together a proposal for this? Also I eventually would like to backport this to 2.1.x. But can hold off on that for a while and let it sit on trunk.

-Justin


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

(attachments)

rest_dispatcher.patch (3.7 KB)

On Mon, Jan 31, 2011 at 7:20 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,
Recently I have been experimenting with the notion of a rest dispatcher
callback, the same way we have a callback for ows based services.
Attached is the first cut of the patch. Let me know what you think. You will
probably note in the patch that the exception() and finished() callbacks are
not called. That is because I would like to build off of a recent patch from
Andrea that involves a subclass of ServletConverter and invoke the callback
methods there.

Sounds good to me. If you want just go ahead and also merge in the patch
I was talking about yesterday

Cheers
Andrea

--
Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------

Cool, callback and servlet converter committed on trunk. Will backport to 2.1.x after it has a chance to settle.

On Mon, Jan 31, 2011 at 2:18 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Jan 31, 2011 at 7:20 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,
Recently I have been experimenting with the notion of a rest dispatcher
callback, the same way we have a callback for ows based services.
Attached is the first cut of the patch. Let me know what you think. You will
probably note in the patch that the exception() and finished() callbacks are
not called. That is because I would like to build off of a recent patch from
Andrea that involves a subclass of ServletConverter and invoke the callback
methods there.

Sounds good to me. If you want just go ahead and also merge in the patch
I was talking about yesterday

Cheers
Andrea


Ing. Andrea Aime
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584962313
fax: +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf



Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.