[Geoserver-devel] Backporting GEOT-6409/GEOS-9379: TimeParser refactoring and improvement

Hi,
sorry for crossposting but the 2 commits are strictly related since the GEOS one requires the GEOT one and they can’t be handled separately.

I would like to ask permission for backporting:

  • [GEOT-6409]: “Refactor and Improve ImageMosaic’s TimeParser adopting pieces of code from GeoServer’s TimeParser” to 22.x

  • [GEOS-9379]: “Move GeoServer’s TimeParser code/parsing capabilities down to GeoTools” to 2.16.x

They are related to the TimeParser refactoring and improvement work done on master series and the 1 month interim period already expired.
That work was collecting lot of duplicated code from different Time parsing classes (one in GeoTools and one in GeoServer) into a single point in GeoTools.
It was also supporting and integrating slightly different customization options from the 2 classes (such as lenient ISO8601 parsing) as well as improving some of them, as an instance, the reduced precision time ranges management.

More details available here on the JIRA:
https://osgeo-org.atlassian.net/browse/GEOT-6409

https://osgeo-org.atlassian.net/browse/GEOS-9379

Referred Pull Requests:
https://github.com/geotools/geotools/pull/2658
https://github.com/geoserver/geoserver/pull/3884

Thanks and Regards,

···

Daniele

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Daniele Romagnoli
Senior Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

+1

Ian

···

Ian Turton

+1

Torben

On Thu, Jan 30, 2020 at 3:02 AM Ian Turton <ijturton@anonymised.com> wrote:

+1

Ian

On Thu, 30 Jan 2020 at 10:02, Daniele Romagnoli <daniele.romagnoli@anonymised.com> wrote:

Hi,
sorry for crossposting but the 2 commits are strictly related since the GEOS one requires the GEOT one and they can’t be handled separately.

I would like to ask permission for backporting:

  • [GEOT-6409]: “Refactor and Improve ImageMosaic’s TimeParser adopting pieces of code from GeoServer’s TimeParser” to 22.x

  • [GEOS-9379]: “Move GeoServer’s TimeParser code/parsing capabilities down to GeoTools” to 2.16.x

They are related to the TimeParser refactoring and improvement work done on master series and the 1 month interim period already expired.
That work was collecting lot of duplicated code from different Time parsing classes (one in GeoTools and one in GeoServer) into a single point in GeoTools.
It was also supporting and integrating slightly different customization options from the 2 classes (such as lenient ISO8601 parsing) as well as improving some of them, as an instance, the reduced precision time ranges management.

More details available here on the JIRA:
https://osgeo-org.atlassian.net/browse/GEOT-6409

https://osgeo-org.atlassian.net/browse/GEOS-9379

Referred Pull Requests:
https://github.com/geotools/geotools/pull/2658
https://github.com/geoserver/geoserver/pull/3884

Thanks and Regards,

Daniele

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Daniele Romagnoli
Senior Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.


GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Ian Turton


GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

No objections! :smiley:

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.