[Geoserver-devel] CLA for "less than one file" changes

GeoServer GeoServer Developer
1

Hi,
the GeoTools contribution guidelines clearly state that a small change does not require a CLA:
http://docs.geotools.org/latest/developer/procedures/contribute.html

I thought we had the same in GeoServer, but I cannot find it:

Have I missed some change? Or did I just wrongly assume the policies were the same
for the two projects, and they are not?

Cheers
Andrea

···

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

2

I do not think we provided similar language for GeoServer.

···

–
Jody Garnett

3

Ok, but was that a deliberate choice or a mistake? Should we fix it?

Cheers
Andrea

Il sab 25 ago 2018, 03:51 Jody Garnett <jody.garnett@anonymised.com> ha scritto:

I do not think we provided similar language for GeoServer.

On Fri, Aug 24, 2018 at 9:18 AM Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
the GeoTools contribution guidelines clearly state that a small change does not require a CLA:
http://docs.geotools.org/latest/developer/procedures/contribute.html

I thought we had the same in GeoServer, but I cannot find it:

Have I missed some change? Or did I just wrongly assume the policies were the same
for the two projects, and they are not?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

–
Jody Garnett

4

Last time we got stuck because of wanting a fix and a test case (two files) and then the conversation died off.

I would be fine if we included it and used it to accept documentation fixes for example.

···

–
Jody Garnett

5

+1

I think it would encourage more “part-time” contributors, to support you core developers.

Peter

On Sat, 25 Aug 2018 at 16:27, Jody Garnett <jody.garnett@anonymised.com> wrote:

Last time we got stuck because of wanting a fix and a test case (two files) and then the conversation died off.

I would be fine if we included it and used it to accept documentation fixes for example.

On Sat, Aug 25, 2018 at 7:45 AM Andrea Aime <andrea.aime@anonymised.com> wrote:

Ok, but was that a deliberate choice or a mistake? Should we fix it?

Cheers

Andrea

Il sab 25 ago 2018, 03:51 Jody Garnett <jody.garnett@anonymised.com> ha scritto:

I do not think we provided similar language for GeoServer.

On Fri, Aug 24, 2018 at 9:18 AM Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
the GeoTools contribution guidelines clearly state that a small change does not require a CLA:
http://docs.geotools.org/latest/developer/procedures/contribute.html

I thought we had the same in GeoServer, but I cannot find it:

Have I missed some change? Or did I just wrongly assume the policies were the same
for the two projects, and they are not?

Cheers
Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

–
Jody Garnett

–

–
Jody Garnett

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

6

At least it’s a mistake to tell the change must effect ‘less then one file’ :wink:

Regards,

Ronald Hoek

Application Developer
ComponentAgro B.V.
Oud-Beijerland - The Netherlands

Website: http://www.componentagro.nl

KvK: H24264020

Verzonden: zaterdag 25 augustus 2018 8:45

···

Ok, but was that a deliberate choice or a mistake? Should we fix it?

Cheers

Andrea

Il sab 25 ago 2018, 03:51 Jody Garnett <jody.garnett@…403…> ha scritto:

I do not think we provided similar language for GeoServer.

On Fri, Aug 24, 2018 at 9:18 AM Andrea Aime <andrea.aime@…1268…> wrote:

Hi,

the GeoTools contribution guidelines clearly state that a small change does not require a CLA:

http://docs.geotools.org/latest/developer/procedures/contribute.html

I thought we had the same in GeoServer, but I cannot find it:

Have I missed some change? Or did I just wrongly assume the policies were the same

for the two projects, and they are not?

Cheers

Andrea

==

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

–

Jody Garnett

7

Made a pull request to change contributing.MD here:

https://github.com/geoserver/geoserver/pull/3069

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

8

I found another take on this idea here - https://carto.com/contributions/

The language used is to accept “obvious fix” … https://carto.com/contributions/#obvious-fix spelling mistake or logic error, rather than any kind of new functionality.

···

–
Jody Garnett