[Geoserver-devel] DefaultRasterMapProducer and graphic disposing

Evan_Martin · February 28, 2006, 12:08am

Hi all!

I have a question about "DefaultRasterMapProducer.java". In the produceMap() function, on line 234 in the 1.4 sources, on line 239 in the 1.3.0 sources, there is 2 tests of abortRequested and for the first of them, if it is true, the function returns without disposing graphic object. So are any system resources that this object is using released after the request aborts (if it aborts before rendering)?
Thanks,

Pierre-Emmanuel

Simone3 · February 28, 2006, 4:22pm

Hi Pierre,
I think the code in the first if block should be corrected to:

        if (this.abortRequested)
        {
          graphic.dispose();
            return;
        }

in order to release resources for the graphics.

Simone.

°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°
Simone Giannecchini
Software Engineer
Freelance Consultant

http://simboss.wordpress.com/

°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°

On 2/28/06, Alcer (Pierre-Emmanuel Balageas) <geoserver@anonymised.com> wrote:

Hi all!

I have a question about "DefaultRasterMapProducer.java". In the
produceMap() function, on line 234 in the 1.4 sources, on line 239 in
the 1.3.0 sources, there is 2 tests of abortRequested and for the first
of them, if it is true, the function returns without disposing graphic
object. So are any system resources that this object is using released
after the request aborts (if it aborts before rendering)?
Thanks,

Pierre-Emmanuel

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°
Simone Giannecchini
Software Engineer
Freelance Consultant

http://simboss.wordpress.com/

°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°

Chris_Holmes1 · March 3, 2006, 9:04am

Could someone put this in JIRA? Ideally a patch file that you've tested that we can just apply.

best regards,

Chris

Simone Giannecchini wrote:

Hi Pierre,
I think the code in the first if block should be corrected to:

        if (this.abortRequested)
        {
          graphic.dispose();
            return;
        }

in order to release resources for the graphics.

Simone.

°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°
Simone Giannecchini
Software Engineer
Freelance Consultant

http://simboss.wordpress.com/

°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°

On 2/28/06, Alcer (Pierre-Emmanuel Balageas) <geoserver@anonymised.com> wrote:

Hi all!

I have a question about "DefaultRasterMapProducer.java". In the
produceMap() function, on line 234 in the 1.4 sources, on line 239 in
the 1.3.0 sources, there is 2 tests of abortRequested and for the first
of them, if it is true, the function returns without disposing graphic
object. So are any system resources that this object is using released
after the request aborts (if it aborts before rendering)?
Thanks,

Pierre-Emmanuel

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°
Simone Giannecchini
Software Engineer
Freelance Consultant

http://simboss.wordpress.com/

°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Chris Holmes
The Open Planning Project
thoughts at: http://cholmes.wordpress.com