Hi all,
I'm testing struts 1.2.4 with geoserver 1.2.3. Some deprecated methods have
been removed from struts 1.1 especially getResources() on ActionServlet.
I have locally fixed this on the followings :
TypesEditorForm.java
DataDataStoresSelectForm.java
LoginForm.java
DataDataStoresSelectAction.java
DataFeatureTypesSelectAction.java
DataNamespacesSelectAction.java
StylesSelectAction.java
TypesEditorAction.java
ValidationTestSelectAction.java
ValidationTestSuiteSelectAction.java
with :
// didier (2004-10-16) deprecated Struts 1.1, removed 1.2 : MessageResources
messages = servlet.getResources();
MessageResources messages = servlet.getInternal();
I am not sure these fixes are deemed necessary (does getInternal() exist in
1.0.x struts release ?). Any advice ?
Another point is that I got the following exception at compiled time (during
JSPCompiler process) :
2004-10-16 14:20:35 StandardWrapperValve[action]: "Servlet.service()" pour la
servlet action a généré une exception
javax.servlet.jsp.JspException: ServletException in
'/WEB-INF/pages/data/namespaces/Select.jsp': Property namespaces returned a
null value
at
org.apache.struts.taglib.tiles.InsertTag$InsertHandler.doEndTag(InsertTag.java:921)
at
org.apache.struts.taglib.tiles.InsertTag.doEndTag(InsertTag.java:460)
at
org.apache.jsp.WEB_002dINF.pages.layouts.mainLayout_jsp._jspx_meth_tiles_insert_6(mainLayout_jsp.java:1327)
at
org.apache.jsp.WEB_002dINF.pages.layouts.mainLayout_jsp._jspService(mainLayout_jsp.java:513)
(the line corresponds to lien 140 in mainLayout.jsp when it loads the body
tile which is Select.jsp in that case)
but, this does not prevent the admin pages to work correctly ... Does it occur
with struts 1.1.x or less ?
didier
Is there a motivation for upgrading to struts? I think the changes are
probably fine, as everything works the same in the struts that is
distributed with GeoServer. I don't know that much about struts,
upgrading doesn't mean that we need to place any more requirements on the
users, like servlet version or anything, does it? And does it have a lot
of improvements?
As for that error, I don't think I've ever seen it.
Chris
On Sat, 16 Oct 2004, Richard didier wrote:
Hi all,
I'm testing struts 1.2.4 with geoserver 1.2.3. Some deprecated methods have
been removed from struts 1.1 especially getResources() on ActionServlet.
I have locally fixed this on the followings :
TypesEditorForm.java
DataDataStoresSelectForm.java
LoginForm.java
DataDataStoresSelectAction.java
DataFeatureTypesSelectAction.java
DataNamespacesSelectAction.java
StylesSelectAction.java
TypesEditorAction.java
ValidationTestSelectAction.java
ValidationTestSuiteSelectAction.java
with :
// didier (2004-10-16) deprecated Struts 1.1, removed 1.2 : MessageResources
messages = servlet.getResources();
MessageResources messages = servlet.getInternal();
I am not sure these fixes are deemed necessary (does getInternal() exist in
1.0.x struts release ?). Any advice ?
Another point is that I got the following exception at compiled time (during
JSPCompiler process) :
2004-10-16 14:20:35 StandardWrapperValve[action]: "Servlet.service()" pour la
servlet action a généré une exception
javax.servlet.jsp.JspException: ServletException in
'/WEB-INF/pages/data/namespaces/Select.jsp': Property namespaces returned a
null value
at
org.apache.struts.taglib.tiles.InsertTag$InsertHandler.doEndTag(InsertTag.java:921)
at
org.apache.struts.taglib.tiles.InsertTag.doEndTag(InsertTag.java:460)
at
org.apache.jsp.WEB_002dINF.pages.layouts.mainLayout_jsp._jspx_meth_tiles_insert_6(mainLayout_jsp.java:1327)
at
org.apache.jsp.WEB_002dINF.pages.layouts.mainLayout_jsp._jspService(mainLayout_jsp.java:513)
(the line corresponds to lien 140 in mainLayout.jsp when it loads the body
tile which is Select.jsp in that case)
but, this does not prevent the admin pages to work correctly ... Does it occur
with struts 1.1.x or less ?
didier
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Le Lundi 18 Octobre 2004 20:00, Chris Holmes a écrit :
Is there a motivation for upgrading to struts? I think the changes are
probably fine, as everything works the same in the struts that is
distributed with GeoServer. I don't know that much about struts,
upgrading doesn't mean that we need to place any more requirements on the
users, like servlet version or anything, does it? And does it have a lot
of improvements?
There is no motivation at all : it was mainly due a home test (See
http://struts.apache.org/userGuide/release-notes.html for more info, but
there are interesting points for web pages like Validator enhancements,
DigestingPlugIn, MappingDispatchAction, etc ...). I will put back the svn
struts version (1.1) on my home dev tree, and test the changes. If the webapp
keeps on working, I may commit them (upon agreement).
Struts 1.2 needs antlr-#.#.jar, but jdbc2_0-stdext.jar is not any more needed
(that's all I see as requirements).
Version 1.2.2 enhanced version 1.1, I guess version 1.2.4 adds more
improvements.
didier