Hi all,
playing with GeoServer’s REST API I experienced a behavior that doesn’t sound right, at least to me.
When a namespace is created issuing a POST request to the /namespaces endpoint, a corresponding workspace is automatically created by GeoServer; conversely, when a namespace is deleted issuing a DELETE request to the /namespaces/ endpoint, the associated workspace is not explictly removed from the catalog (I checked the code in NamespaceResource) and continues to appear in the UI (a NullPointerException is thrown if user clicks on it) and in the outcome of REST calls, even though the workspace.xml file no longer exists on disk. If GeoServer is rebooted, the workspace disappears.
I believe this could be fixed either by adding a few lines of code to NamespaceResource’s method:
https://github.com/geoserver/geoserver/blob/d54d57219141b9d8806307c1f02228c0008912c4/src/restconfig/src/main/java/org/geoserver/catalog/rest/NamespaceResource.java#L109
or, more generally, by implementing the method handleRemoveEvent(CatalogRemoveEvent) in the catalog listener NamespaceWorkspaceConsistencyListener:
https://github.com/geoserver/geoserver/blob/d54d57219141b9d8806307c1f02228c0008912c4/src/main/src/main/java/org/geoserver/catalog/NamespaceWorkspaceConsistencyListener.java#L128
cURL requests to reproduce the issue:
curl -X POST -d ‘test_nshttp://www.exmple.com’ -H “Content-Type: text/xml” -u admin:geoserver http://localhost:8080/geoserver/rest/namespaces
curl -X DELETE -u admin:geoserver http://localhost:8080/geoserver/rest/namespaces/test_ns
I’m using GeoServer master.
<br>-- <br><br>Best regards,<br>Stefano Costa<br><br>==<br>GeoServer Professional Services from the experts! Visit<br>http://goo.gl/it488V for more information.<br>==<br>Dott. Stefano Costa<br>Senior Software Engineer<br><br>GeoSolutions S.A.S.<br>Via Poggio alle Viti 1187<br>55054 Massarosa (LU)<br>Italy<br>phone: +39 0584 962313<br>fax: +39 0584 1660272<br><br>http://www.geo-solutions.it<br>http://twitter.com/geosolutions_it<br><br>-------------------------------------------------------<br>AVVERTENZE AI SENSI DEL D.Lgs. 196/2003<br>Le informazioni contenute in questo messaggio di posta elettronica e/o<br>nel/i file/s allegato/i sono da considerarsi strettamente riservate.<br>Il loro utilizzo è consentito esclusivamente al destinatario del<br>messaggio, per le finalità indicate nel messaggio stesso. Qualora<br>riceviate questo messaggio senza esserne il destinatario, Vi preghiamo<br>cortesemente di darcene notizia via e-mail e di procedere alla<br>distruzione del messaggio stesso, cancellandolo dal Vostro sistema.<br>Conservare il messaggio stesso, divulgarlo anche in parte,<br>distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità<br>diverse, costituisce comportamento contrario ai principi dettati dal<br>D.Lgs. 196/2003.<br><br>The information in this message and/or attachments, is intended solely<br>for the attention and use of the named addressee(s) and may be<br>confidential or proprietary in nature or covered by the provisions of<br>privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New<br>Data Protection Code).Any use not in accord with its purpose, any<br>disclosure, reproduction, copying, distribution, or either<br>dissemination, either whole or partial, is strictly forbidden except<br>previous formal approval of the named addressee(s). If you are not the<br>intended recipient, please contact immediately the sender by<br>telephone, fax or e-mail and delete the information in this message<br>that has been received in error. The sender does not give any warranty<br>or accept liability as the content, accuracy or completeness of sent<br>messages and accepts no responsibility for changes made after they<br>were sent or for other risks which arise as a result of e-mail<br>transmission, viruses, etc.<br><br><br><br> |
|---|