[Geoserver-devel] GetFeature 1.1 broken on trunk?

Hi,
seems GetFeature is broken for wfs 1.1 requests on trunk. It is something I've
noticed and fixed on wfs-c, the fix is trivial.

it just makes me wonder how a small change in geotools might completely break
some geoserver functionality and we can't even notice it.

Time for a functional test suite?

Gabriel

Which was the bug exactly? Was it the same one as found recently in this
thread:

http://www.nabble.com/WFS-GetFeature-broken-on-trunk--tf3856846.html#a10926998

For some tests I believe we are in luck. I wrote a whole heap of unit
tests for ows4 but haven't ported them to trunk. However now that we
have mock testing on trunk I can go ahead and do that. I will keep you
posted.

-Justin

Gabriel Roldán wrote:

Hi,
seems GetFeature is broken for wfs 1.1 requests on trunk. It is something I've
noticed and fixed on wfs-c, the fix is trivial.

it just makes me wonder how a small change in geotools might completely break
some geoserver functionality and we can't even notice it.

Time for a functional test suite?

Gabriel

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,46680077318181431913854!

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com

Hi Justin,

On Thursday 07 June 2007 17:22:28 Justin Deoliveira wrote:

Which was the bug exactly? Was it the same one as found recently in this
thread:

http://www.nabble.com/WFS-GetFeature-broken-on-trunk--tf3856846.html#a10926
998

seems related. It was just TypeNameListTypeBinding assuming its value argument
was a Strign and trying to build the qname list from it, but since the added
support for list types in the parser it is no longer needed. As said, the bug
was trivial and the fix very easy.

For some tests I believe we are in luck. I wrote a whole heap of unit
tests for ows4 but haven't ported them to trunk. However now that we
have mock testing on trunk I can go ahead and do that. I will keep you
posted.

That sounds great, no rush though, I'm sure you're bussy enough. I just wanted
to raise an alarm on how reliable our trunk-on-trunk build process is.

thanks for careing,

Gabriel

-Justin

Gabriel Roldán wrote:
> Hi,
> seems GetFeature is broken for wfs 1.1 requests on trunk. It is something
> I've noticed and fixed on wfs-c, the fix is trivial.
>
> it just makes me wonder how a small change in geotools might completely
> break some geoserver functionality and we can't even notice it.
>
> Time for a functional test suite?
>
> Gabriel
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
> !DSPAM:4007,46680077318181431913854!