Quick proposal for a public API change:
http://geoserver.org/display/GEOS/GSIP+111+GetLegendGraphicsRequest+Cleanup
This proposal addresses the WMS unholy trinity of GetLegendGraphicKvpReader / GetLegendGraphicsRequest / BufferedImageLegendGraphicBuilder making code easier to follow and fix.
Jody Garnett
+1. Looks like a well-needed improvement. The GSIP includes detailed consideration (and testing) of ordering issues.
Kind regards,
Ben.
On 31/03/14 12:22, Jody Garnett wrote:
Quick proposal for a public API change:
http://geoserver.org/display/GEOS/GSIP+111+GetLegendGraphicsRequest+Cleanup
This proposal addresses the WMS unholy trinity of
GetLegendGraphicKvpReader / GetLegendGraphicsRequest /
BufferedImageLegendGraphicBuilder making code easier to follow and fix.This clean is implemented as part of
https://github.com/geoserver/geoserver/pull/551
--
Jody Garnett------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Ciao Jody,
just to be clear,
this proposal does not include any work wrt refactoring the encoding code available for GetLegendGraphic?
Ing. Simone Giannecchini
@simogeo
Founder/Director
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Mon, Mar 31, 2014 at 10:23 AM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:
+1. Looks like a well-needed improvement. The GSIP includes detailed
consideration (and testing) of ordering issues.Kind regards,
Ben.On 31/03/14 12:22, Jody Garnett wrote:
Quick proposal for a public API change:
http://geoserver.org/display/GEOS/GSIP+111+GetLegendGraphicsRequest+Cleanup
This proposal addresses the WMS unholy trinity of
GetLegendGraphicKvpReader / GetLegendGraphicsRequest /
BufferedImageLegendGraphicBuilder making code easier to follow and fix.This clean is implemented as part of
https://github.com/geoserver/geoserver/pull/551Jody Garnett
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
This work comes out of a fix I was working on and includes updating GetLegendGraphic (and contains my QA checklist).
Since this section of code does not really have a champion I figured a GSIP (rather than just a patch) was a good idea.
Actually since these classes are all in the same package, I could knock this API change back to package visibility and back port to the stable branch.
Jody Garnett
On Mon, Mar 31, 2014 at 7:39 PM, Simone Giannecchini <simone.giannecchini@anonymised.com> wrote:
Ciao Jody,
just to be clear,
this proposal does not include any work wrt refactoring the encoding code available for GetLegendGraphic?
Ing. Simone Giannecchini
@simogeo
Founder/Director
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Mon, Mar 31, 2014 at 10:23 AM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:
+1. Looks like a well-needed improvement. The GSIP includes detailed
consideration (and testing) of ordering issues.Kind regards,
Ben.On 31/03/14 12:22, Jody Garnett wrote:
Quick proposal for a public API change:
http://geoserver.org/display/GEOS/GSIP+111+GetLegendGraphicsRequest+Cleanup
This proposal addresses the WMS unholy trinity of
GetLegendGraphicKvpReader / GetLegendGraphicsRequest /
BufferedImageLegendGraphicBuilder making code easier to follow and fix.This clean is implemented as part of
https://github.com/geoserver/geoserver/pull/551Jody Garnett
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
+1, the API does indeed look better
Cheers
Andrea
On Mon, Mar 31, 2014 at 11:20 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:
This work comes out of a fix I was working on and includes updating GetLegendGraphic (and contains my QA checklist).
Since this section of code does not really have a champion I figured a GSIP (rather than just a patch) was a good idea.
Actually since these classes are all in the same package, I could knock this API change back to package visibility and back port to the stable branch.
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
Jody Garnett
On Mon, Mar 31, 2014 at 7:39 PM, Simone Giannecchini <simone.giannecchini@anonymised.com> wrote:
Ciao Jody,
just to be clear,
this proposal does not include any work wrt refactoring the encoding code available for GetLegendGraphic?
Ing. Simone Giannecchini
@simogeo
Founder/Director
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Mon, Mar 31, 2014 at 10:23 AM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:
+1. Looks like a well-needed improvement. The GSIP includes detailed
consideration (and testing) of ordering issues.Kind regards,
Ben.On 31/03/14 12:22, Jody Garnett wrote:
Quick proposal for a public API change:
http://geoserver.org/display/GEOS/GSIP+111+GetLegendGraphicsRequest+Cleanup
This proposal addresses the WMS unholy trinity of
GetLegendGraphicKvpReader / GetLegendGraphicsRequest /
BufferedImageLegendGraphicBuilder making code easier to follow and fix.This clean is implemented as part of
https://github.com/geoserver/geoserver/pull/551Jody Garnett
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Sorry for the late response.
The proposal looks good to me. +1
On Wed, Apr 2, 2014 at 6:38 AM, Andrea Aime <andrea.aime@anonymised.com68…> wrote:
+1, the API does indeed look better
Cheers
Andrea
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Gabriel Roldán
Software Developer | Boundless
On Mon, Mar 31, 2014 at 11:20 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:
This work comes out of a fix I was working on and includes updating GetLegendGraphic (and contains my QA checklist).
Since this section of code does not really have a champion I figured a GSIP (rather than just a patch) was a good idea.
Actually since these classes are all in the same package, I could knock this API change back to package visibility and back port to the stable branch.
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
Jody Garnett
On Mon, Mar 31, 2014 at 7:39 PM, Simone Giannecchini <simone.giannecchini@anonymised.com> wrote:
Ciao Jody,
just to be clear,
this proposal does not include any work wrt refactoring the encoding code available for GetLegendGraphic?
Ing. Simone Giannecchini
@simogeo
Founder/Director
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 333 8128928
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Mon, Mar 31, 2014 at 10:23 AM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:
+1. Looks like a well-needed improvement. The GSIP includes detailed
consideration (and testing) of ordering issues.Kind regards,
Ben.On 31/03/14 12:22, Jody Garnett wrote:
Quick proposal for a public API change:
http://geoserver.org/display/GEOS/GSIP+111+GetLegendGraphicsRequest+Cleanup
This proposal addresses the WMS unholy trinity of
GetLegendGraphicKvpReader / GetLegendGraphicsRequest /
BufferedImageLegendGraphicBuilder making code easier to follow and fix.This clean is implemented as part of
https://github.com/geoserver/geoserver/pull/551Jody Garnett
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel–
Ben Caradoc-Davies Ben.Caradoc-Davies@anonymised.com
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel