[Geoserver-devel] GSIP-215 Drop Java 8

GeoServer GeoServer Developer
1

Hi,

I sent also my +1 that was meant to mean for 2.23 only on August 31.

-Jukka-

···

Lähettäjä: Jody Garnett jody.garnett@anonymised.com
Lähetetty: maanantai 19. syyskuuta 2022 19.06
Vastaanottaja: GeoServer geoserver-devel@lists.sourceforge.net
Aihe: Re: [Geoserver-devel] GSIP-215 Drop Java 8

I think this proposal is now ready to be accepted? (Note it was updated to indicate 2.23.0 timeframe)

Project Steering Committee:

  • Alessio Fabiani:
  • Andrea Aime: +1 (2.23.0 only)
  • Ian Turton: +1 (2.22.0 or 2.23.0)
  • Jody Garnett: +1 (2.22.0 or 2.23.0)
  • Jukka Rahkonen:
  • Kevin Smith: +1
  • Simone Giannecchini:
  • Torben Barsballe: +1
  • Nuno Oliveira: +1

Community support:

  • Fernando Mino: +1

–

Jody Garnett

On Tue, 30 Aug 2022 at 11:14, Jody Garnett <jody.garnett@anonymised.com> wrote:

Please see https://github.com/geoserver/geoserver/wiki/GSIP-215 for details, general idea is to drop Java 8 support so we can update dependencies and plan Jakarta migration.

Thanks to foss4g code sprint and Euan Mitchell for initial pull request for docs:

If this proposal is ready for the 2.22.0 release it would simplify the process of setting up build jobs for the new release cycle. Vote early, vote often…

–

Jody Garnett

2

Thanks Jukka, updated the page.

···

–
Jody Garnett

3

I merged the initial PR now that the proposal is approved and the RC is out.

And tried the github resolves the conflict thing … and now have regrests:

  1. There was one conflict on one documentation page due to a new section on paramertized security
  2. Resolving the conflict indicated it would be a commitment to main … which I took to mean the PR would be merged…
  3. The commit history locally shows two merge commits and everything seems okay…
  4. However … the commit history in github shows:

I am not sure what to make of it; and do not wish to revert; or force push; without a better understanding of what is going on.

···

–
Jody Garnett

4

The build server only sees a small number of files changed: https://build.geoserver.org/view/geoserver/job/geoserver-main/1358/changes

Summary

  1. [GEOS-10638] drop Java 8 support from docs (details)
  2. Remove java 8 reference from developers guide (details)

Commit 6fdd602bcb3cffc66f80f22ef3c93b2a84a3c606 by Jody Garnett
[GEOS-10638] drop Java 8 support from docs
The file was modified doc/en/user/source/configuration/status.rst (diff)
The file was modified doc/en/user/source/production/java.rst (diff)
The file was modified doc/en/user/source/security/passwd.rst (diff)
The file was modified doc/en/user/source/installation/index.rst (diff)
The file was modified doc/en/user/source/installation/war.rst (diff)
The file was modified doc/en/user/source/installation/win_binary.rst (diff)
The file was modified doc/en/user/source/installation/win_installer.rst (diff)
The file was modified doc/en/user/source/installation/linux.rst (diff)
The file was modified doc/en/user/source/production/container.rst (diff)

Commit 21fa400de4fb43fd8c26dda8dd4f18f45b98d4fc by Jody Garnett
Remove java 8 reference from developers guide
The file was modified doc/en/developer/source/tools.rst (diff)
The file was modified doc/en/developer/source/qa-guide/index.rst (diff)

···

So I hope everything is okay…

Jody Garnett

5

Hi Jody,

I think I see what’s going on here.

On Fri, Oct 21, 2022 at 7:22 PM Jody Garnett <jody.garnett@anonymised.com> wrote:

I am not sure what to make of it; and do not wish to revert; or force push; without a better understanding of what is going on.

That looks to be a merge of geoserver:main into euanmitchell:main (the source of the PR). I assume that remote was rather behind geoserver:main at the time of the merge, which would explain the large number of changes for that commit, and the relatively few number of actual changes relative to geoserver:main

So, things are probably fine?

Cheers,
Torben

–
Jody

–
Jody Garnett

On Mon, 19 Sept 2022 at 14:29, Jody Garnett <jody.garnett@anonymised.com> wrote:

Thanks Jukka, updated the page.

–
Jody Garnett

On Mon, 19 Sept 2022 at 10:21, Rahkonen Jukka <jukka.rahkonen@anonymised.com> wrote:

Hi,

I sent also my +1 that was meant to mean for 2.23 only on August 31.

-Jukka-

Lähettäjä: Jody Garnett <jody.garnett@anonymised.com03…>
Lähetetty: maanantai 19. syyskuuta 2022 19.06
Vastaanottaja: GeoServer <geoserver-devel@lists.sourceforge.net>
Aihe: Re: [Geoserver-devel] GSIP-215 Drop Java 8

I think this proposal is now ready to be accepted? (Note it was updated to indicate 2.23.0 timeframe)

Project Steering Committee:

  • Alessio Fabiani:
  • Andrea Aime: +1 (2.23.0 only)
  • Ian Turton: +1 (2.22.0 or 2.23.0)
  • Jody Garnett: +1 (2.22.0 or 2.23.0)
  • Jukka Rahkonen:
  • Kevin Smith: +1
  • Simone Giannecchini:
  • Torben Barsballe: +1
  • Nuno Oliveira: +1

Community support:

  • Fernando Mino: +1

–

Jody Garnett

On Tue, 30 Aug 2022 at 11:14, Jody Garnett <jody.garnett@anonymised.com…> wrote:

Please see https://github.com/geoserver/geoserver/wiki/GSIP-215 for details, general idea is to drop Java 8 support so we can update dependencies and plan Jakarta migration.

Thanks to foss4g code sprint and Euan Mitchell for initial pull request for docs:

If this proposal is ready for the 2.22.0 release it would simplify the process of setting up build jobs for the new release cycle. Vote early, vote often…

–

Jody Garnett

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

6

Thanks torben; and that suddenly makes sense - that the PR was coming from a main branch and causing concern

···

–
Jody Garnett