[Geoserver-devel] GSIP 96 - pass down thread locals in thread pools

GeoServer GeoServer Developer
1

Hi,
following up today’s meeting I’ve put together a quick proposal for the machinery needed to fix http://jira.codehaus.org/browse/GEOS-5370 :

http://geoserver.org/display/GEOS/GSIP+96±+Machinery+to+pass+thread+locals+down+in+thread+pools

Feedback and votes welcomed :slight_smile:

Cheers
Andrea

–

==
GeoServer training in Milan, 6th & 7th June 2013! Visit http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

2

+0. While I am all for the bug being fixed, I dont think I can comment usefully on the efficacy of the proposed solution.

Notice: This email and any attachments are confidential.
If received in error please destroy and immediately notify us.
Do not copy or disclose the contents.

3

Looks good to me. +1

···

On Mon, May 27, 2013 at 4:37 PM, Phil Scadden <p.scadden@anonymised.com> wrote:

+0. While I am all for the bug being fixed, I dont think I can comment
usefully on the efficacy of the proposed solution.

Notice: This email and any attachments are confidential.
If received in error please destroy and immediately notify us.
Do not copy or disclose the contents.

Try New Relic Now & We’ll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

4

+1. Good analysis of the problem.

My one concern is that this change might introduce some interesting new thread-local leaks, either security or plain unanticipated thread interactions. Would you consider leaving this on master for a month before backporting?

Kind regards,
Ben.

On 27/05/13 22:28, Andrea Aime wrote:

Hi,
following up today's meeting I've put together a quick proposal for the
machinery needed to fix http://jira.codehaus.org/browse/GEOS-5370 :

http://geoserver.org/display/GEOS/GSIP+96+-+Machinery+to+pass+thread+locals+down+in+thread+pools

Feedback and votes welcomed :slight_smile:

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it
<http://geoserver.geo-solutions.it/&gt; for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

5

Pull request for this proposal ready:

https://github.com/geoserver/geoserver/pull/243

I’ve also modified the WPS demo request builder to allow the specification of username and password, pretty much like in the demo requests, so that wps and auth interaction can be easily tested

Cheers
Andrea

6

On Tue, May 28, 2013 at 6:09 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:

+1. Good analysis of the problem.

My one concern is that this change might introduce some interesting new
thread-local leaks, either security or plain unanticipated thread
interactions. Would you consider leaving this on master for a month before
backporting?

I've been very careful about avoiding cross thread contamination (see tests
in the pull request), but sure, no problem
in waiting a month for the backport

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

7

+0 here … although I understood the issue and the solution, it’s not fully clear to me if this is the optimal solution. It should work anyway.

A.

···

==
GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

==

Ing. Alessio Fabiani
@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

On Tue, May 28, 2013 at 12:01 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Tue, May 28, 2013 at 6:09 AM, Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com> wrote:

Try New Relic Now & We’ll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

+1. Good analysis of the problem.

My one concern is that this change might introduce some interesting new thread-local leaks, either security or plain unanticipated thread interactions. Would you consider leaving this on master for a month before backporting?

I’ve been very careful about avoiding cross thread contamination (see tests in the pull request), but sure, no problem
in waiting a month for the backport

Cheers

Andrea

–

==
GeoServer training in Milan, 6th & 7th June 2013! Visit http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

8

On Mon, May 27, 2013 at 4:28 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:

Hi,
following up today's meeting I've put together a quick proposal for the
machinery needed to fix http://jira.codehaus.org/browse/GEOS-5370 :

http://geoserver.org/display/GEOS/GSIP+96+-+Machinery+to+pass+thread+locals+down+in+thread+pools

Feedback and votes welcomed :slight_smile:

Pull request merged.
I'll wait for 2.3.3 to be out before backporting to the 2.3.x series

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------