Hi,
https://github.com/geoserver/geoserver/pull/7577 turns out to be much more work than anticipated, unfortunately I've no run out of time due to upcoming holidays, so this PR will stall from my side for a couple of weeks.
Anyone willing to spend some time on it is quite welcome 
If not I will continue when I get back.
Mark
Aaah yep, it’s a big one for sure… PMD upgrade to version 7. They rewrote the java scanner
and it’s not much better at finding violations.
441 files modified in the PR so far, quite a bit of modules not yet reached by the build, and this is the
current output:
Error: 0,053 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-web-core: You have 43 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/web/core/target/pmd.xml → [Help 1]
Error: 0,053 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-restconfig: You have 4 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/restconfig/target/pmd.xml → [Help 1]
Error: 0,053 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-sample-data-access-test: You have 2 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/extension/app-schema/sample-data-access-test/target/pmd.xml → [Help 1]
Error: 0,053 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-excel: You have 1 PMD violation. For more details see: /home/runner/work/geoserver/geoserver/src/extension/excel/target/pmd.xml → [Help 1]
Error: 0,053 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-dxf-core: You have 1 PMD violation. For more details see: /home/runner/work/geoserver/geoserver/src/extension/dxf/core/target/pmd.xml → [Help 1]
Error: 0,054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-sec-jdbc: You have 4 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/security/jdbc/target/pmd.xml → [Help 1]
Error: 0,054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-csw-simple-store: You have 1 PMD violation. For more details see: /home/runner/work/geoserver/geoserver/src/extension/csw/simple-store/target/pmd.xml → [Help 1]
Error: 0,054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-wms: You have 95 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/wms/target/pmd.xml → [Help 1]
Error: 0,054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-wcs2_0-eo-core: You have 2 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/extension/wcs2_0-eo/core/target/pmd.xml → [Help 1]
Error: 0,054 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.22.0:check (default) on project gs-wps-core: You have 24 PMD violations. For more details see: /home/runner/work/geoserver/geoserver/src/extension/wps/wps-core/target/pmd.xml → [Help 1]
200+ violations just here LOL. Yes, it needs to be a group effort, no doubt.
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts!
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions Group
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
https://www.geosolutionsgroup.com/
http://twitter.com/geosolutions_it
Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail