[Geoserver-devel] Introduction

GeoServer GeoServer Developer
1

Hello,

My name is Ronald Hoek.

I’m a spectrum wide application developer (analyst, design, programming, testing, user support, bug-fixing, etc.) for a company in the Netherlands.

Recently (this year) we created an application (using Delphi), which matches geo-data from different (secure) sources with each other.

Because this data was not always available as a service (and the data was to large to distribute), I started looking for a (web)service, which could ‘host’ that geo-data, so the application could request only parts of the complete set.

Then I found GeoServer as one of the first hits, and I was really positively surprised by all the possibilities the application has. We did not look very far for other solutions, because GeoServer looked so promising and showed some exceled behavior an performance during the first tests and the fact GeoServer showed very active development.

But as always all software has issues ( https://osgeo-org.atlassian.net/browse/GEOS-8683 ).

So now here I am – as a newby to GeoServer – offering to help with further development of GeoServer.

As I’m not a Java Developer, but a Windows Application Developer, for now I would like to help with tuning the Windows Installer.

I would suggest the following changes in the installer behavior:

  • Never to overwrite/delete/add files in an existing ‘data_dir’
  • Suggest to the user to use a ‘data_dir’ outside the application directory
    • Note: it’s best to uninstall the software before upgrading, as the ‘old’ Windows Service Entry is removed and a new one is created

Maybe other issue might be changed in due time.

But for now these are the two issues I would like to change (I also need to learn NSIS first…)

Regards,

Ronald Hoek

Application Developer
ComponentAgroB.V.
Oud-Beijerland - The Netherlands

Website: http://www.componentagro.nl

KvK: H24264020

2

Hi Ronald,
thanks for joining and introducing yourself. Find my comments below inline.

···

On Mon, Apr 16, 2018 at 3:31 PM, Ronald Hoek - ComponentAgro B.V. <ronald.hoek@anonymised.com> wrote:

But as always all software has issues ( https://osgeo-org.atlassian.net/browse/GEOS-8683 ).

So now here I am – as a newby to GeoServer – offering to help with further development of GeoServer.

As I’m not a Java Developer, but a Windows Application Developer, for now I would like to help with tuning the Windows Installer.

Yep, we surely need someone to help on the Windows side :slight_smile:

I would suggest the following changes in the installer behavior:

  • Never to overwrite/delete/add files in an existing ‘data_dir’

Seems reasonable, GeoServer should upgrade the contents of the data dir on startup if strictly needed (that cannot be fully avoided,
but we try to limit that to a very small number of cases).
Maybe also suggest people to backup the data directory before proceeding with the upgrade.

  • Suggest to the user to use a ‘data_dir’ outside the application directory
    • Note: it’s best to uninstall the software before upgrading, as the ‘old’ Windows Service Entry is removed and a new one is created

Agreed on this one as well.

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

3

Hello Andrea,

I’ve taken a bit of time to look into the NSIS ‘world’ and when I look at the script, it seems is requires file base on the location the script file if located.

However, it looks like these files are scattered across the repo, which requires me to create a copy of these file for testen the setup script.

I was wondering whether this is a required, as the automated build system creates this required set of files first and then compiles the script in the same location.

As said, the file are also (partially) available across the repo, so pointing to them (using relative path names) from within the script file, will not required a special copy of that data.

However, I don’t know how the setup is created by you (of the build system) at this time.

Can you give me some info, about how you create the setup at your end?

Regards,

Ronald Hoek

Application Developer

4

On Wed, Apr 18, 2018 at 11:27 AM, Ronald Hoek - ComponentAgro B.V. <
ronald.hoek@anonymised.com> wrote:

Hello Andrea,

I’ve taken a bit of time to look into the NSIS ‘world’ and when I look at
the script, it seems is requires file base on the location the script file
if located.

However, it looks like these files are scattered across the repo, which
requires me to create a copy of these file for testen the setup script.

I was wondering whether this is a required, as the automated build system
creates this required set of files first and then compiles the script in
the same location.

Yes, you should first run a release build that generates the required base
zip file, something like:

cd src
mvn clean install -T2 -DskipTests -Prelease
mvn assembly:attached -Prelease -DskipTests

The -DskipTests is required as GeoServer won't build with tests on Windows
(we lack a windows developer caring for it, and you
don't really need tests anyways for your purpose).
The output will be in src/target/release

As an alternative, you can just pick the -bin.zip file from the nightly
builds directly, e.g.:
https://build.geoserver.org/geoserver/master/geoserver-master-latest-bin.zip

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

5

Hello Andrea,

For testing I now used the ‘bin.zip’ content (as I don’t; have the environment set up for building GeoServer).

I’ve created a pull request (on the master) to change the installer behavior (pull contains two commits).

However I have two more (smaller) issues, which I fixed too:

  • The NSIS compiler gives warnings about a non-existing LANGUAGE identifier
  • Cleanup ‘work’ folder after install

Can I create these in the issue tracker and make two pull request for them?

  • Or two different commits (and one pull)

Regards,

Ronald Hoek

Application Developer

6

On Wed, Apr 18, 2018 at 2:43 PM, Ronald Hoek - ComponentAgro B.V. <
ronald.hoek@anonymised.com> wrote:

Hello Andrea,

For testing I now used the ‘bin.zip’ content (as I don’t; have the
environment set up for building GeoServer).

I’ve created a pull request (on the master) to change the installer
behavior (pull contains two commits).

However I have two more (smaller) issues, which I fixed too:

   - The NSIS compiler gives warnings about a non-existing LANGUAGE
   identifier
   - Cleanup ‘work’ folder after install

Can I create these in the issue tracker and make two pull request for them?

   - Or two different commits (and one pull)

Both work... or you can even attach them into your original pull request,
in separate commits. Our norm is "one commit per ticket",
though there are deviations.

Cheers
Andrea

--

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.