[Geoserver-devel] IOUtils.createTempDirectory - prefix is ignored

Ziegler_Stefan · October 8, 2009, 9:14am

Hi

it seems that the prefix is ignored and it always creates a temporary directory starting with "wfsshptmp".

line 185 from org.geoserver.data.util.java should changed from:

File reqTempDir = new File(sysTempDir + File.separator + "wfsshptemp" + Math.random());

to

File reqTempDir = new File(sysTempDir + File.separator + prefix + Math.random());

regards
Stefan

mit freundlichem Gruss
Stefan Ziegler

Lubomir_Varga · October 8, 2009, 8:43pm

Hi,

what that code do? Shouldnt it be replaced by something like this?:
File.createTempFile(arg0, arg1, arg2);

Imho this is standard method of doing it.

PS: this creates temp file, not folder. A little bit modifiing probably should
be used. I mean that like suggestion, I dont have any interest on that code.

Have a nice day.
--
Odborník na všetko je zlý odborník. Ja sa snažím byť výnimkou potvrdzujúcou
pravidlo.

On Thursday 08 October 2009 11:14:06 Ziegler Stefan wrote:

Hi

it seems that the prefix is ignored and it always creates a temporary
directory starting with "wfsshptmp".

line 185 from org.geoserver.data.util.java should changed from:

File reqTempDir = new File(sysTempDir + File.separator + "wfsshptemp" +
Math.random());

to

File reqTempDir = new File(sysTempDir + File.separator + prefix +
Math.random());

regards
Stefan

mit freundlichem Gruss
Stefan Ziegler

---------------------------------------------------------------------------
--- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is
the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Simone_Giannecchini3 · October 14, 2009, 8:55pm

Stefan,
can you open a jira for this?

Simone.
-------------------------------------------------------
Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy

phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://simboss.blogspot.com/
http://www.linkedin.com/in/simonegiannecchini

-------------------------------------------------------

On Thu, Oct 8, 2009 at 11:14 AM, Ziegler Stefan <Stefan.Ziegler@anonymised.com> wrote:

Hi

it seems that the prefix is ignored and it always creates a temporary directory starting with "wfsshptmp".

line 185 from org.geoserver.data.util.java should changed from:

File reqTempDir = new File(sysTempDir + File.separator + "wfsshptemp" + Math.random());

to

File reqTempDir = new File(sysTempDir + File.separator + prefix + Math.random());

regards
Stefan

mit freundlichem Gruss
Stefan Ziegler

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Ziegler_Stefan · October 15, 2009, 8:30am

can you open a jira for this?

done.