I've noticed a habit of pull requests to GeoWebCache that only describe
what they are doing in terms of GeoServer. Although referencing the
downstream issue that led to the change is useful, this is not, by
itself sufficient to evaluate the PR for inclusion in GeoWebCache. If a
feature or bug fix in GeoServer requires an upstream change in
GeoWebCache, please give your GWC PRs, issues, and commits descriptions
that make sense in the context of the GeoWebCache project and then add
the downstream context if it seems helpful.
It doesn't need to be complicated, something like "Adding foo so that
GeoServer can do baz" will do in most cases. The PR reviewer can then
look at whether the PR adds "foo" in a reasonable way without having to
understand "baz" and anyone looking through the commit history can get a
reasonable idea of what happened.
--
Kevin Michael Smith
<smithkm@anonymised.com>
Good notice, thanks for the heads up.
···
On 11/24/2017 10:02 PM, Kevin Smith wrote:
I've noticed a habit of pull requests to GeoWebCache that only describe
what they are doing in terms of GeoServer. Although referencing the
downstream issue that led to the change is useful, this is not, by
itself sufficient to evaluate the PR for inclusion in GeoWebCache. If a
feature or bug fix in GeoServer requires an upstream change in
GeoWebCache, please give your GWC PRs, issues, and commits descriptions
that make sense in the context of the GeoWebCache project and then add
the downstream context if it seems helpful.
It doesn't need to be complicated, something like "Adding foo so that
GeoServer can do baz" will do in most cases. The PR reviewer can then
look at whether the PR adds "foo" in a reasonable way without having to
understand "baz" and anyone looking through the commit history can get a
reasonable idea of what happened.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! [http://sdm.link/slashdot](http://sdm.link/slashdot)
_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@lists.sourceforge.net](mailto:Geoserver-devel@lists.sourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)
--
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==
Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)
-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.