[Geoserver-devel] Jalopy formatting, reborn

Hi all,
today I managed to make jalopy format our sources in 1.4.x.
(you can try it out there, just mvn update, build the maven
module so that build-configs gets updated, then run
mvn jalopy:format). For the record, it wasn't working because
of a sorting flag (import sorting was enabled and was breaking
formatting afaik).
I'll port to 1.5.x and trunk asap, but I think what's most
important is that someone elses tries it out on 1.4.x (wihtout
committing) and then we get organised so that one of use
just runs it on every module with everybody elses on hold,
with no uncommitte changes.

I could do that during this weekend, for example.
Cheers
Andrea

PS: this should allow me to close GSIP #2 btw.

I think the only thing to beware of with the formatting is people on branches. If someone has a branch that they intended to merge changes back to trunk from, formatting trunk and not the branch, or vice versa will undoubtedly lead to conflicts.

-Justin

Andrea Aime wrote:

Hi all,
today I managed to make jalopy format our sources in 1.4.x.
(you can try it out there, just mvn update, build the maven
module so that build-configs gets updated, then run
mvn jalopy:format). For the record, it wasn't working because
of a sorting flag (import sorting was enabled and was breaking
formatting afaik).
I'll port to 1.5.x and trunk asap, but I think what's most
important is that someone elses tries it out on 1.4.x (wihtout
committing) and then we get organised so that one of use
just runs it on every module with everybody elses on hold,
with no uncommitte changes.

I could do that during this weekend, for example.
Cheers
Andrea

PS: this should allow me to close GSIP #2 btw.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:1004,45b9023683571194215290!

--
Justin Deoliveira
jdeolive@anonymised.com
The Open Planning Project
http://topp.openplans.org

Justin Deoliveira ha scritto:

I think the only thing to beware of with the formatting is people on branches. If someone has a branch that they intended to merge changes back to trunk from, formatting trunk and not the branch, or vice versa will undoubtedly lead to conflicts.

So far trunk and 1.5.x were in synch, so there are no issues.
But since trunk is playing against geotools trunk, they are going
to diverge since coverages on trunk are not up to date.

So, the sooner we reformat both, the merrier.
Cheers
Andrea