Double event notification in Catalog.save
-----------------------------------------
Key: GEOS-4369
URL: http://jira.codehaus.org/browse/GEOS-4369
Project: GeoServer
Issue Type: Bug
Components: Configuration
Affects Versions: 2.1-RC1
Reporter: Gabriel Roldán
Assignee: Justin Deoliveira
Fix For: 2.1-RC2
Just found that when saving a {{StyleInfo}} the catalog issues the same post modification event twice. This is inconvenient cause there might be listeners performing expensive actions.
The call chain goes like:
{code}
CatalogImpl.save(style)
|--> DefaultCatalogFacade.save(style) -> DefaultCatalogFacade.saved(style) -> CatalogImpl.firePostModified(unwrapProxy(style))
|
|--> CatalogImpl.saved(style) --> CatalogImpl.firePostModified(style)
{code}
Actually it looks like that's the case for all the CatalogImpl.save() overrides. It doesn't look like DefaultCatalogFacade issues events for {{add(...)}} nor {{remove(....)}}, so maybe it's just an unintentional left over in {{DefaultCatalogFacade}} that should not trigger events?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira