[Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not include sld and vendor parameters into the request

carlo cancellieri created BugGEOS-5332
KMLTransformer does not include sld and vendor parameters into the request

Issue Type:

BugBug

Affects Versions:

2.2.x, 2.3-beta1

Assignee:

Andrea Aime

Created:

03/Oct/12 11:31 AM

Description:

when using a request like the following:
http://localhost:8080/geoserver/ows?
service=WMS&request=getMap&version=1.1.1
&layers=sf:7416_eto01
&cql_filter=gaez_id=‘lr_soi_hwsd_domi’
&bbox=-180,-90,180,90
&width=256&height=256&transparent=true
&sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136
&srs=EPSG:4326
&format=application/vnd.google-earth.kml+xml

I obtain a kml without the sld into the wms request, this also happens for some of the vendor parameters.

Fix Versions:

2.2.1

Project:

GeoServer

Priority:

MajorMajor

Reporter:

carlo cancellieri

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your [JIRA administrators](https://jira.codehaus.org/secure/ContactAdministrators!default.jspa). For more information on JIRA, see: [http://www.atlassian.com/software/jira](http://www.atlassian.com/software/jira)

Hi all,
I'm going to complete this fix but I'm in doubt on how to use some vendor parameters:

Looking here:
http://docs.geoserver.org/latest/en/user/services/wms/vendor.html

I see that KMSCORE and KMATTR may be specified as normal parameters &Kmscore=100&kmattr=...

The kml reflector instead uses those parameters into format_options:

<href><![CDATA[http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false;KMPLACEMARK:false;KMSCORE:40;KMATTR:true;&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]]></href>

What's the correct way? Are there any other vendor parameters which should be moved under format_options? (so I could fix documentation).

Thank you,
Carlo

________________________________

Date: Wed, 3 Oct 2012 11:32:36 -0500
From: jira@anonymised.com
To: geoserver-devel@lists.sourceforge.net
Subject: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not
include sld and vendor parameters into the request

[https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr%2FTscmysv4%3D0&url=http%3A%2F%2Fwww.codehaus.org%2Fcodehaus-small.gif]
[https://jira.codehaus.org/secure/useravatar?avatarId=10232]
carlo
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri&gt;
created [Bug] GEOS-5332<https://jira.codehaus.org/browse/GEOS-5332&gt;
KMLTransformer does not include sld and vendor parameters into the
request<https://jira.codehaus.org/browse/GEOS-5332&gt;

Issue Type: [Bug] Bug
Affects Versions: 2.2.x, 2.3-beta1
Assignee: Andrea
Aime<https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime&gt;
Created: 03/Oct/12 11:31 AM
Description:

when using a request like the following:
http://localhost:8080/geoserver/ows?
service=WMS&request=getMap&version=1.1.1
&layers=sf:7416_eto01
&cql_filter=gaez_id='lr_soi_hwsd_domi'
&bbox=-180,-90,180,90
&width=256&height=256&transparent=true
&sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136
&srs=EPSG:4326
&format=application/vnd.google-earth.kml+xml

I obtain a kml without the sld into the wms request, this also happens
for some of the vendor parameters.

Fix Versions: 2.2.1
Project: GeoServer<https://jira.codehaus.org/browse/GEOS&gt;
Priority: [Major] Major
Reporter: carlo
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri&gt;

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators<https://jira.codehaus.org/secure/ContactAdministrators!default.jspa&gt;\.
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic
APM Deploy New Relic app performance management and know exactly what
is happening inside your Ruby, Python, PHP, Java, and .NET app Try New
Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________ Geoserver-devel mailing
list Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
                 

From a pure WMS request standpoint the format options are the correct way. But the kml reflector is meant purely for convenience, so using the parameters as kvp in the request makes sense. So i would say that having the KML reflector (or some other reflector) support direct options and translate them into the format_options parameter for the reflecting request it is generated is ok. Does that make sense?

On Tue, Oct 16, 2012 at 7:00 AM, Carlo Cancellieri <ccancellieri@anonymised.com> wrote:

Hi all,
I’m going to complete this fix but I’m in doubt on how to use some vendor parameters:

Looking here:
http://docs.geoserver.org/latest/en/user/services/wms/vendor.html

I see that KMSCORE and KMATTR may be specified as normal parameters &Kmscore=100&kmattr=…

The kml reflector instead uses those parameters into format_options:

<![CDATA[http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false;KMPLACEMARK:false;KMSCORE:40;KMATTR:true;&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]]>

What’s the correct way? Are there any other vendor parameters which should be moved under format_options? (so I could fix documentation).

Thank you,
Carlo


Date: Wed, 3 Oct 2012 11:32:36 -0500
From: jira@anonymised.com
To: geoserver-devel@lists.sourceforge.net
Subject: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not

include sld and vendor parameters into the request

[https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr%2fTscmysv4%3d0&url=http%3a%2f%2fwww.codehaus.org%2fcodehaus-small.gif]
[https://jira.codehaus.org/secure/useravatar?avatarId=10232]
carlo
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri>
created [Bug] GEOS-5332<https://jira.codehaus.org/browse/GEOS-5332>

KMLTransformer does not include sld and vendor parameters into the

request<https://jira.codehaus.org/browse/GEOS-5332>

Issue Type: [Bug] Bug

Affects Versions: 2.2.x, 2.3-beta1
Assignee: Andrea

Aime<https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime>

Created: 03/Oct/12 11:31 AM
Description:

when using a request like the following:
http://localhost:8080/geoserver/ows?
service=WMS&request=getMap&version=1.1.1
&layers=sf:7416_eto01
&cql_filter=gaez_id=‘lr_soi_hwsd_domi’
&bbox=-180,-90,180,90
&width=256&height=256&transparent=true
&sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136
&srs=EPSG:4326
&format=application/vnd.google-earth.kml+xml

I obtain a kml without the sld into the wms request, this also happens
for some of the vendor parameters.

Fix Versions: 2.2.1

Project: GeoServer<https://jira.codehaus.org/browse/GEOS>
Priority: [Major] Major
Reporter: carlo
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri>

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA

administrators<https://jira.codehaus.org/secure/ContactAdministrators%21default.jspa>.

For more information on JIRA, see: http://www.atlassian.com/software/jira


Don’t let slow site performance ruin your business. Deploy New Relic
APM Deploy New Relic app performance management and know exactly what
is happening inside your Ruby, Python, PHP, Java, and .NET app Try New
Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________ Geoserver-devel mailing
list Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Don’t let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Hi Justin,

I'm looking at the code...

From a pure WMS request standpoint the format options are the correct
way. But the kml reflector is meant purely for convenience, so using
the parameters as kvp in the request makes sense. So i would say that
having the KML reflector (or some other reflector) support direct
options and translate them into the format_options parameter for the
reflecting request it is generated is ok. Does that make sense?

It may cause some confusion in users and add unnecessary logic on my point of View.

I see that most of the methods for the kvp parameters are deprecated into the WMSGetMapRequest saying:

@deprecated use <code>getFormatOptions().get( "legend" )</code>

All of those methods are unused except than getLegend() used into the KMLTransformer.encode() method.

Do you think that we have to continue supporting those options as kvp?

My intention was to:
- remove deprecated use of getLegend from KMLTransformer.encode() method using the format_options
- fix documentation porting deprecated (and not used getters) options under the format_options section.
- align the GEOS-5332 fix to the new changes.

If this is not the case and you think that we have to continue supporting those deprecated options,
the parameters specified in format_options may override those specified as kvp mode?

If is this the case, can these changes be backported to the 2.2.1 release ?

Sorry but I want to close this issue ASAP (in the best way).

Thank you,
Carlo

On Tue, Oct 16, 2012 at 7:00 AM, Carlo Cancellieri
<ccancellieri@anonymised.com<mailto:ccancellieri@anonymised.com>> wrote:

Hi all,
I'm going to complete this fix but I'm in doubt on how to use some
vendor parameters:

Looking here:
http://docs.geoserver.org/latest/en/user/services/wms/vendor.html

I see that KMSCORE and KMATTR may be specified as normal parameters
&Kmscore=100&kmattr=...

The kml reflector instead uses those parameters into format_options:

<href><![CDATA[http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false;KMPLACEMARK:false;KMSCORE:40;KMATTR:true;&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]<http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false%3BKMPLACEMARK:false%3BKMSCORE:40%3BKMATTR:true%3B&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]&gt;\]></href>

What's the correct way? Are there any other vendor parameters which
should be moved under format_options? (so I could fix documentation).

Thank you,
Carlo

________________________________
> Date: Wed, 3 Oct 2012 11:32:36 -0500
> From: jira@anonymised.com<mailto:jira@anonymised.com>
> To:
geoserver-devel@lists.sourceforge.net<mailto:geoserver-devel@anonymised.comforge.net>
> Subject: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not
> include sld and vendor parameters into the request
>
>
[https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr%2FTscmysv4%3D0&url=http%3A%2F%2Fwww.codehaus.org%2Fcodehaus-small.gif&lt;https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr/Tscmysv4%3D0&url=http://www.codehaus.org/codehaus-small.gif&gt;\]
> [https://jira.codehaus.org/secure/useravatar?avatarId=10232]
> carlo
>
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri&gt;
> created [Bug] GEOS-5332<https://jira.codehaus.org/browse/GEOS-5332&gt;
> KMLTransformer does not include sld and vendor parameters into the
> request<https://jira.codehaus.org/browse/GEOS-5332&gt;
>
>
>
> Issue Type: [Bug] Bug
> Affects Versions: 2.2.x, 2.3-beta1
> Assignee: Andrea
> Aime<https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime&gt;
> Created: 03/Oct/12 11:31 AM
> Description:
>
> when using a request like the following:
> http://localhost:8080/geoserver/ows?
> service=WMS&request=getMap&version=1.1.1
> &layers=sf:7416_eto01
> &cql_filter=gaez_id='lr_soi_hwsd_domi'
> &bbox=-180,-90,180,90
> &width=256&height=256&transparent=true
> &sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136
> &srs=EPSG:4326
> &format=application/vnd.google-earth.kml+xml
>
> I obtain a kml without the sld into the wms request, this also happens
> for some of the vendor parameters.
>
>
> Fix Versions: 2.2.1
> Project: GeoServer<https://jira.codehaus.org/browse/GEOS&gt;
> Priority: [Major] Major
> Reporter: carlo
>
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri&gt;
>
>
>
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
>
administrators<https://jira.codehaus.org/secure/ContactAdministrators!default.jspa&gt;\.
> For more information on JIRA, see: http://www.atlassian.com/software/jira

                 

Hi Carlo,

Sorry for the confusion. Allow me to reiterate.

I agree that against the normal wms service endpoint that these options should be specified as format options. So I agree that:

geoserver/wms?legend=true&…

Should be:

geoserver/wms?format_options=legend:true&…

And i agree the documentation should reflect that.

However, when going against the kml endpoint the options may be specified directly. So I see this as still valid:

/geoserver/wms/kml?legend=true

So, with regard to your proposed changes.

  • remove deprecated use of getLegend from KMLTransformer.encode() method using the format_options

Agreed.

  • fix documentation porting deprecated (and not used getters) options under the format_options section.

For the normal wms endpoint:

http://docs.geoserver.org/latest/en/user/services/wms/vendor.html)

Yes I agree the docs should updated. But for the kml specific reflector endpoint:

http://docs.geoserver.org/latest/en/user/googleearth/features/kmlreflector.html

I think the options are valid when specified directly and should be left as is.

  • align the GEOS-5332 fix to the new changes.

Sounds good.

Hope that clears it up.

-Justin

On Tue, Oct 16, 2012 at 8:17 AM, Carlo Cancellieri <ccancellieri@anonymised.com> wrote:

Hi Justin,

I’m looking at the code…

From a pure WMS request standpoint the format options are the correct
way. But the kml reflector is meant purely for convenience, so using
the parameters as kvp in the request makes sense. So i would say that
having the KML reflector (or some other reflector) support direct
options and translate them into the format_options parameter for the
reflecting request it is generated is ok. Does that make sense?

It may cause some confusion in users and add unnecessary logic on my point of View.

I see that most of the methods for the kvp parameters are deprecated into the WMSGetMapRequest saying:

@deprecated use getFormatOptions().get( “legend” )

All of those methods are unused except than getLegend() used into the KMLTransformer.encode() method.

Do you think that we have to continue supporting those options as kvp?

My intention was to:

  • remove deprecated use of getLegend from KMLTransformer.encode() method using the format_options
  • fix documentation porting deprecated (and not used getters) options under the format_options section.
  • align the GEOS-5332 fix to the new changes.

If this is not the case and you think that we have to continue supporting those deprecated options,
the parameters specified in format_options may override those specified as kvp mode?

If is this the case, can these changes be backported to the 2.2.1 release ?

Sorry but I want to close this issue ASAP (in the best way).

Thank you,
Carlo

On Tue, Oct 16, 2012 at 7:00 AM, Carlo Cancellieri

<ccancellieri@anonymised.commailto:[ccancellieri@anonymised.com](mailto:ccancellieri@anonymised.com)> wrote:

Hi all,
I’m going to complete this fix but I’m in doubt on how to use some
vendor parameters:

Looking here:
http://docs.geoserver.org/latest/en/user/services/wms/vendor.html

I see that KMSCORE and KMATTR may be specified as normal parameters
&Kmscore=100&kmattr=…

The kml reflector instead uses those parameters into format_options:

<![CDATA[http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false;KMPLACEMARK:false;KMSCORE:40;KMATTR:true;&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]<http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false%3bKMPLACEMARK:false%3bKMSCORE:40%3bKMATTR:true%3b&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1%5d>]>

What’s the correct way? Are there any other vendor parameters which
should be moved under format_options? (so I could fix documentation).

Thank you,
Carlo


Date: Wed, 3 Oct 2012 11:32:36 -0500

From: jira@anonymised.commailto:[jira@anonymised.com](mailto:jira@anonymised.com)
To:
geoserver-devel@lists.sourceforge.netmailto:[geoserver-devel@lists.sourceforge.net](mailto:geoserver-devel@anonymised.comsts.sourceforge.net)

Subject: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not
include sld and vendor parameters into the request

[https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr%2fTscmysv4%3d0&url=http%3a%2f%2fwww.codehaus.org%2fcodehaus-small.gif<https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr/Tscmysv4%3d0&url=http://www.codehaus.org/codehaus-small.gif>]

[https://jira.codehaus.org/secure/useravatar?avatarId=10232]
carlo

cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri>

created [Bug] GEOS-5332<https://jira.codehaus.org/browse/GEOS-5332>
KMLTransformer does not include sld and vendor parameters into the
request<https://jira.codehaus.org/browse/GEOS-5332>

Issue Type: [Bug] Bug
Affects Versions: 2.2.x, 2.3-beta1
Assignee: Andrea
Aime<https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime>
Created: 03/Oct/12 11:31 AM
Description:

when using a request like the following:
http://localhost:8080/geoserver/ows?
service=WMS&request=getMap&version=1.1.1
&layers=sf:7416_eto01
&cql_filter=gaez_id=‘lr_soi_hwsd_domi’
&bbox=-180,-90,180,90
&width=256&height=256&transparent=true
&sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136
&srs=EPSG:4326
&format=application/vnd.google-earth.kml+xml

I obtain a kml without the sld into the wms request, this also happens
for some of the vendor parameters.

Fix Versions: 2.2.1
Project: GeoServer<https://jira.codehaus.org/browse/GEOS>
Priority: [Major] Major
Reporter: carlo

cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri>

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA

administrators<https://jira.codehaus.org/secure/ContactAdministrators%21default.jspa>.

For more information on JIRA, see: http://www.atlassian.com/software/jira


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Thank you justin for your detailed answer.
I think that this implementation
https://github.com/geoserver/geoserver/pull/35
may solve the problem and add some feature to the KMLReflector as discussed.
Let me know if it is enough (I need it in 2.2.1).
Regards,
Carlo

________________________________

Date: Tue, 16 Oct 2012 20:05:39 -0600
Subject: Re: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does
not include sld and vendor parameters into the request
From: jdeolive@anonymised.com
To: ccancellieri@anonymised.com
CC: geoserver-devel@lists.sourceforge.net

Hi Carlo,

Sorry for the confusion. Allow me to reiterate.

I agree that against the normal wms service endpoint that these options
should be specified as format options. So I agree that:

geoserver/wms?legend=true&...

Should be:

geoserver/wms?format_options=legend:true&...

And i agree the documentation should reflect that.

However, when going against the kml endpoint the options may be
specified directly. So I see this as still valid:

/geoserver/wms/kml?legend=true

So, with regard to your proposed changes.

- remove deprecated use of getLegend from KMLTransformer.encode()
method using the format_options
Agreed.

- fix documentation porting deprecated (and not used getters) options
under the format_options section.
For the normal wms endpoint:

http://docs.geoserver.org/latest/en/user/services/wms/vendor.html)

Yes I agree the docs should updated. But for the kml specific reflector
endpoint:

http://docs.geoserver.org/latest/en/user/googleearth/features/kmlreflector.html

I think the options are valid when specified directly and should be
left as is.

- align the GEOS-5332 fix to the new changes.

Sounds good.

Hope that clears it up.

-Justin

On Tue, Oct 16, 2012 at 8:17 AM, Carlo Cancellieri
<ccancellieri@anonymised.com<mailto:ccancellieri@anonymised.com>> wrote:

Hi Justin,

I'm looking at the code...

> From a pure WMS request standpoint the format options are the correct
> way. But the kml reflector is meant purely for convenience, so using
> the parameters as kvp in the request makes sense. So i would say that
> having the KML reflector (or some other reflector) support direct
> options and translate them into the format_options parameter for the
> reflecting request it is generated is ok. Does that make sense?

It may cause some confusion in users and add unnecessary logic on my
point of View.

I see that most of the methods for the kvp parameters are deprecated
into the WMSGetMapRequest saying:

@deprecated use <code>getFormatOptions().get( "legend" )</code>

All of those methods are unused except than getLegend() used into
the KMLTransformer.encode() method.

Do you think that we have to continue supporting those options as kvp?

My intention was to:
- remove deprecated use of getLegend from KMLTransformer.encode()
method using the format_options
- fix documentation porting deprecated (and not used getters) options
under the format_options section.
- align the GEOS-5332 fix to the new changes.

If this is not the case and you think that we have to continue
supporting those deprecated options,
the parameters specified in format_options may override those specified
as kvp mode?

If is this the case, can these changes be backported to the 2.2.1 release ?

Sorry but I want to close this issue ASAP (in the best way).

Thank you,
Carlo

>
> On Tue, Oct 16, 2012 at 7:00 AM, Carlo Cancellieri
>
<ccancellieri@anonymised.com<mailto:ccancellieri@anonymised.com><mailto:ccancellieri@…21…<mailto:ccancellieri@anonymised.com>>>
wrote:
>
> Hi all,
> I'm going to complete this fix but I'm in doubt on how to use some
> vendor parameters:
>
> Looking here:
> http://docs.geoserver.org/latest/en/user/services/wms/vendor.html
>
> I see that KMSCORE and KMATTR may be specified as normal parameters
> &Kmscore=100&kmattr=...
>
> The kml reflector instead uses those parameters into format_options:
>
>
<href><![CDATA[http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false;KMPLACEMARK:false;KMSCORE:40;KMATTR:true;&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1&lt;http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false%3BKMPLACEMARK:false%3BKMSCORE:40%3BKMATTR:true%3B&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1&gt;\]<http://hqlprtcdrgeo2.hq.un.fao.org:8082/geoserver/wms?height=1024&width=1024&layers=AQUASTAT:globcover&request=GetMap&service=wms&styles=aquastat_globcover&format_options=SUPEROVERLAY:false%3BKMPLACEMARK:false%3BKMSCORE:40%3BKMATTR:true%3B&srs=EPSG:4326&format=application/vnd.google-earth.kmz&transparent=false&version=1.1.1]&gt;\]></href>
>
> What's the correct way? Are there any other vendor parameters which
> should be moved under format_options? (so I could fix documentation).
>
> Thank you,
> Carlo
>
> ________________________________
> > Date: Wed, 3 Oct 2012 11:32:36 -0500
> > From:
jira@anonymised.com<mailto:jira@anonymised.com><mailto:jira@anonymised.com..121...>>
> > To:
>
geoserver-devel@lists.sourceforge.net<mailto:geoserver-devel@anonymised.comforge.net><mailto:geoserver-devel@lists.sourceforge.net>
> > Subject: [Geoserver-devel] [jira] (GEOS-5332) KMLTransformer does not
> > include sld and vendor parameters into the request
> >
> >
>
[https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr%2FTscmysv4%3D0&url=http%3A%2F%2Fwww.codehaus.org%2Fcodehaus-small.gif&lt;https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr/Tscmysv4%3D0&url=http://www.codehaus.org/codehaus-small.gif&gt;&lt;https://dub108.mail.live.com/Handlers/ImageProxy.mvc?bicild=&canary=uHsGiqJpKLnc5WM1imT0qjuhVtjpAGexKr/Tscmysv4%3D0&url=http://www.codehaus.org/codehaus-small.gif&gt;\]
> > [https://jira.codehaus.org/secure/useravatar?avatarId=10232]
> > carlo
> >
>
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri&gt;
> > created [Bug] GEOS-5332<https://jira.codehaus.org/browse/GEOS-5332&gt;
> > KMLTransformer does not include sld and vendor parameters into the
> > request<https://jira.codehaus.org/browse/GEOS-5332&gt;
> >
> >
> >
> > Issue Type: [Bug] Bug
> > Affects Versions: 2.2.x, 2.3-beta1
> > Assignee: Andrea
> > Aime<https://jira.codehaus.org/secure/ViewProfile.jspa?name=aaime&gt;
> > Created: 03/Oct/12 11:31 AM
> > Description:
> >
> > when using a request like the following:
> > http://localhost:8080/geoserver/ows?
> > service=WMS&request=getMap&version=1.1.1
> > &layers=sf:7416_eto01
> > &cql_filter=gaez_id='lr_soi_hwsd_domi'
> > &bbox=-180,-90,180,90
> > &width=256&height=256&transparent=true
> > &sld=http://gaez.fao.org/getSLD?id=pixGAEZtiffhwsddomi036136
> > &srs=EPSG:4326
> > &format=application/vnd.google-earth.kml+xml
> >
> > I obtain a kml without the sld into the wms request, this also happens
> > for some of the vendor parameters.
> >
> >
> > Fix Versions: 2.2.1
> > Project: GeoServer<https://jira.codehaus.org/browse/GEOS&gt;
> > Priority: [Major] Major
> > Reporter: carlo
> >
>
cancellieri<https://jira.codehaus.org/secure/ViewProfile.jspa?name=ccancellieri&gt;
> >
> >
> >
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> >
>
administrators<https://jira.codehaus.org/secure/ContactAdministrators!default.jspa&gt;\.
> > For more information on JIRA, see: http://www.atlassian.com/software/jira
>

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.