[Geoserver-devel] Make utility methods in OWS Dispatcher accesible

GeoServer GeoServer Developer
1

I am tinkering with a custom DispatcherCallback, and ran into a bunch of what are essentially utility methods in the OWS Dispatcher.

I feel like these could be useful outside of Dispatcher (mainly for DispatcherCallback); does anyone have any objections to me making these methods public static?

While this is technically an API change, it only adds functionality.

PR with the methods I wish to change here: https://github.com/geoserver/geoserver/pull/2095

All methods have no notable side effects.

Torben

2

Changes make sense to me Torben, +1 fwiw.

On Tue, Feb 7, 2017 at 4:18 PM Torben Barsballe <tbarsballe@anonymised.com> wrote:

I am tinkering with a custom DispatcherCallback, and ran into a bunch of what are essentially utility methods in the OWS Dispatcher.

I feel like these could be useful outside of Dispatcher (mainly for DispatcherCallback); does anyone have any objections to me making these methods public static?

While this is technically an API change, it only adds functionality.

PR with the methods I wish to change here: https://github.com/geoserver/geoserver/pull/2095

All methods have no notable side effects.

Torben

Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

3

On Wed, Feb 8, 2017 at 4:34 AM, Justin Deoliveira <jdeolive@anonymised.com>
wrote:

Changes make sense to me Torben, +1 fwiw.

Agreed, see no problems either, +1

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------