[Geoserver-devel] PagingFeatureSource?

After updating trunk this morning and trying to build, I see a test failure in main/org.geoserver.feature.PagingFeatureSourceTest. It was my understanding that the paging featuresource wrapper would be removed once GeoTools supported paged requests; so why is this still here?

(PS: I talked to Andrea about the failure itself and he was unable to reproduce it, if anyone could provide some insight I've pasted the trace at http://pastebin.ca/1046011)

-David

It was my fault not to remove the wrapper, going to do so now

Thanks for pointing it out dave.

Gabriel
On Thursday 12 June 2008 04:26:07 pm David Winslow wrote:

After updating trunk this morning and trying to build, I see a test
failure in main/org.geoserver.feature.PagingFeatureSourceTest. It was
my understanding that the paging featuresource wrapper would be removed
once GeoTools supported paged requests; so why is this still here?

(PS: I talked to Andrea about the failure itself and he was unable to
reproduce it, if anyone could provide some insight I've pasted the trace
at http://pastebin.ca/1046011)

-David

!DSPAM:4045,4851320a324273327367457!

Go ahead and remove it. but I doubt that it was the cause of the problem.

Gabriel Roldán wrote:

It was my fault not to remove the wrapper, going to do so now

Thanks for pointing it out dave.

Gabriel
On Thursday 12 June 2008 04:26:07 pm David Winslow wrote:

After updating trunk this morning and trying to build, I see a test
failure in main/org.geoserver.feature.PagingFeatureSourceTest. It was
my understanding that the paging featuresource wrapper would be removed
once GeoTools supported paged requests; so why is this still here?

(PS: I talked to Andrea about the failure itself and he was unable to
reproduce it, if anyone could provide some insight I've pasted the trace
at http://pastebin.ca/1046011)

-David

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,4851334c3647082231907!

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com

On Thursday 12 June 2008 05:28:56 pm Justin Deoliveira wrote:

Go ahead and remove it. but I doubt that it was the cause of the problem.

Not really sure if it was or not. Yet I removed it and the build is back to
normal, didn't check if it was due to this or not really

Cheers,

Gabriel

Gabriel Roldán wrote:
> It was my fault not to remove the wrapper, going to do so now
>
> Thanks for pointing it out dave.
>
> Gabriel
>
> On Thursday 12 June 2008 04:26:07 pm David Winslow wrote:
>> After updating trunk this morning and trying to build, I see a test
>> failure in main/org.geoserver.feature.PagingFeatureSourceTest. It was
>> my understanding that the paging featuresource wrapper would be removed
>> once GeoTools supported paged requests; so why is this still here?
>>
>> (PS: I talked to Andrea about the failure itself and he was unable to
>> reproduce it, if anyone could provide some insight I've pasted the trace
>> at http://pastebin.ca/1046011)
>>
>> -David
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Since the last few lines of the error stack trace indicated some problems in geotools code, I tried reverting all changes made today in geotools (svn up -r{$(date --iso-8601)}) and rebuilding, the error went away for me as well.

I didn't mean to imply that I thought the wrapper was causing problems, just that I discovered it because problems existed.

-David

Gabriel Roldán wrote:

On Thursday 12 June 2008 05:28:56 pm Justin Deoliveira wrote:
  

Go ahead and remove it. but I doubt that it was the cause of the problem.
    

Not really sure if it was or not. Yet I removed it and the build is back to normal, didn't check if it was due to this or not really

Cheers,

Gabriel
  

Gabriel Roldán wrote:
    

It was my fault not to remove the wrapper, going to do so now

Thanks for pointing it out dave.

Gabriel

On Thursday 12 June 2008 04:26:07 pm David Winslow wrote:
      

After updating trunk this morning and trying to build, I see a test
failure in main/org.geoserver.feature.PagingFeatureSourceTest. It was
my understanding that the paging featuresource wrapper would be removed
once GeoTools supported paged requests; so why is this still here?

(PS: I talked to Andrea about the failure itself and he was unable to
reproduce it, if anyone could provide some insight I've pasted the trace
at http://pastebin.ca/1046011)

-David
        

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
      
!DSPAM:4040,48516308131445210051143!

On Thursday 12 June 2008 08:00:59 pm David Winslow wrote:

Since the last few lines of the error stack trace indicated some
problems in geotools code, I tried reverting all changes made today in
geotools (svn up -r{$(date --iso-8601)}) and rebuilding, the error went
away for me as well.

I didn't mean to imply that I thought the wrapper was causing problems,
just that I discovered it because problems existed.

no ofense whatsoever dave, thanks for pointing out it was still there again.

Gabriel

-David

Gabriel Roldán wrote:
> On Thursday 12 June 2008 05:28:56 pm Justin Deoliveira wrote:
>> Go ahead and remove it. but I doubt that it was the cause of the
>> problem.
>
> Not really sure if it was or not. Yet I removed it and the build is back
> to normal, didn't check if it was due to this or not really
>
> Cheers,
>
> Gabriel
>
>> Gabriel Roldán wrote:
>>> It was my fault not to remove the wrapper, going to do so now
>>>
>>> Thanks for pointing it out dave.
>>>
>>> Gabriel
>>>
>>> On Thursday 12 June 2008 04:26:07 pm David Winslow wrote:
>>>> After updating trunk this morning and trying to build, I see a test
>>>> failure in main/org.geoserver.feature.PagingFeatureSourceTest. It was
>>>> my understanding that the paging featuresource wrapper would be
>>>> removed once GeoTools supported paged requests; so why is this still
>>>> here?
>>>>
>>>> (PS: I talked to Andrea about the failure itself and he was unable to
>>>> reproduce it, if anyone could provide some insight I've pasted the
>>>> trace at http://pastebin.ca/1046011)
>>>>
>>>> -David
>>>
>>> -----------------------------------------------------------------------
>>>-- Check out the new SourceForge.net Marketplace.
>>> It's the best place to buy or sell services for
>>> just about anything Open Source.
>>> http://sourceforge.net/services/buy/index.php
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> Geoserver-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4045,48516467137701431913854!