As suggested by Andrea and Mauro, I’ve resubmitted the issues in seperate pull requests on Github.
···
Kind regards,
Alex van den Hoogen
Geodan
Buitenhaven 27-A
5211 TP 's-Hertogenbosch (NL)
2014-09-24 10:28 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:
Hi Alex,
as Mauro said, the norm in GeoServer is to have a single commit per jira ticket, with the commit message
referring to the ticket number/title.
Each fix need to have at least a test to go with it, and if you plan to provide several fixes (which is great!)
please do sign and send the OSGeo contribution agreement.
See also:
https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md
Cheers
Andrea
On Mon, Sep 22, 2014 at 11:22 AM, Alex van den Hoogen | Geodan <alex.van.den.hoogen@anonymised.com> wrote:
Hi all,
First let me introduce myself. I’m Alex van den Hoogen and I’m currently employed at Geodan in the Netherlands. Geodan is a GIS development company. We make quite a lot of use of GeoServer and other open- and closed-source GIS-products and we want to contribute to the open-source community.
That’s why we want to resolve various issues that we encountered in GeoServer. Since most of the main developers of GeoServer were at FOSS4G when my project regarding GeoServer started, I already did some work and issued pull requests on GitHub and created several issues on the GeoServer JIRA.
However, my goal is to get my pull requests accepted in the main GeoServer code and I hope this will be possible. That’s why I want to discuss any issues that anyone of you may have.
The page with the pull requests (which also backlinks to JIRA): https://github.com/geoserver/geoserver/pull/715
If there are any questions or ambiguities, please let them know so I can respond. Thank you for such a great product.
Kind regards,
Alex van den Hoogen
Geodan
Buitenhaven 27-A
5211 TP 's-Hertogenbosch (NL)
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.