[Geoserver-devel] Restored xslt to release profile

GeoServer GeoServer Developer
1

Andrea,

when you promoted the inspire module to extension, it looks like you inadvertently removed the xslt module from the release profile, on both master and 2.3.x. I took the liberty of restoring xslt to the release profile on master and 2.3.x; please let me know if I have misunderstood! It has release descriptors so release fails if it is not built. Do you intend for xslt to be in 2.3.2? Let me know if my guess is wrong.

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

2

On Thu, May 16, 2013 at 4:55 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:

Andrea,

when you promoted the inspire module to extension, it looks like you
inadvertently removed the xslt module from the release profile, on both
master and 2.3.x. I took the liberty of restoring xslt to the release
profile on master and 2.3.x; please let me know if I have misunderstood! It
has release descriptors so release fails if it is not built. Do you intend
for xslt to be in 2.3.2? Let me know if my guess is wrong.

Yes, I definitely intended to.
However the nightly builds does build xslt and has been doing so
successfully for a while,
and the artifacts get published, e.g.:
http://gridlock.opengeo.org/geoserver/2.3.x/ext-2013-05-15/

Makes me wonder if you are really building from a recent revision?

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

3

On 16/05/13 14:04, Andrea Aime wrote:

On Thu, May 16, 2013 at 4:55 AM, Ben Caradoc-Davies
<Ben.Caradoc-Davies@anonymised.com <mailto:Ben.Caradoc-Davies@anonymised.com>> wrote:
However the nightly builds does build xslt and has been doing so
successfully for a while,
and the artifacts get published, e.g.:
http://gridlock.opengeo.org/geoserver/2.3.x/ext-2013-05-15/
Makes me wonder if you are really building from a recent revision?

No, the nightlies just *looked* like they were working. But they were not. I think that, until I added it to the release profile, nightlies were just getting an old xslt jar from the repo, built as a side-effect of geoserver-2.3.x building with -PallExtensions and thus building xslt. geoserver-2.3.x-nightly builds with -Prelease,communityRelease and so did not include xslt until I fixed the pom.

http://hudson.opengeo.org/hudson/job/geoserver-2.3.x-nightly/107/consoleFull

The list of modules being built ends with (no mention of XSLT):

[INFO] GeoServer CAS Security Module
[INFO] GeoServer Security Extension Modules
[INFO] GeoServer INSPIRE Extensions
[INFO] GeoServer Release Module

While building the release module, we also see:

[INFO] snapshot org.geotools:gt-vpf:9-SNAPSHOT: checking for updates from osgeo
[INFO] snapshot org.geoserver:xslt:2.3-SNAPSHOT: checking for updates from opengeo
[INFO] snapshot org.geoserver:xslt:2.3-SNAPSHOT: checking for updates from osgeo
[INFO] snapshot org.geoserver:restconfig:2.3-SNAPSHOT: checking for updates from opengeo
[INFO] snapshot org.geoserver:restconfig:2.3-SNAPSHOT: checking for updates from osgeo

After my pom fix:

http://hudson.opengeo.org/hudson/job/geoserver-2.3.x-nightly/108/consoleText

The list of modules being built ends with (XSLT present):

[INFO] GeoServer CAS Security Module
[INFO] GeoServer Security Extension Modules
[INFO] XLST based WFS output format
[INFO] GeoServer INSPIRE Extensions
[INFO] GeoServer Release Module

And no xslt check in the release module. Looks fixed to me.

Kind regards,

--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre

4

On Fri, May 17, 2013 at 4:15 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:

On 16/05/13 14:04, Andrea Aime wrote:

On Thu, May 16, 2013 at 4:55 AM, Ben Caradoc-Davies
<Ben.Caradoc-Davies@anonymised.com <mailto:Ben.Caradoc-Davies@**csiro.au<Ben.Caradoc-Davies@anonymised.com>>>
wrote:
However the nightly builds does build xslt and has been doing so
successfully for a while,
and the artifacts get published, e.g.:
http://gridlock.opengeo.org/**geoserver/2.3.x/ext-2013-05-**15/&lt;http://gridlock.opengeo.org/geoserver/2.3.x/ext-2013-05-15/&gt;
Makes me wonder if you are really building from a recent revision?

No, the nightlies just *looked* like they were working. But they were not.
I think that, until I added it to the release profile, nightlies were just
getting an old xslt jar from the repo, built as a side-effect of
geoserver-2.3.x building with -PallExtensions and thus building xslt.
geoserver-2.3.x-nightly builds with -Prelease,communityRelease and so did
not include xslt until I fixed the pom.

Ah, I see. Thanks for fixing it :slight_smile:

Cheers
Andrea

--

GeoServer training in Milan, 6th & 7th June 2013! Visit
http://geoserver.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------