[Geoserver-devel] Review for two patches

GeoServer GeoServer Developer
1

Hello List,

step by step forward to a completely translated geoserver installation I stumbled over two little this I’d like to get into 2.1.x and trunk:

BUG : update fails in NewLayerPage (switch between data stores back and force) : http://jira.codehaus.org/browse/GEOS-4827

Improvement : “UNKNOWN” - in CRS text field : http://jira.codehaus.org/browse/GEOS-4809

I was wondering, whether someone can have a look at the minor changes.

Thanks
-Frank

2

Hey Frank,

The patches look ok to me. Seems like some of the formatting might be off though… is your idea / text editor using tabs rather than spaces?

On Wed, Oct 26, 2011 at 9:32 PM, Frank Gasdorf <fgdrf@anonymised.com> wrote:

Hello List,

step by step forward to a completely translated geoserver installation I stumbled over two little this I’d like to get into 2.1.x and trunk:

BUG : update fails in NewLayerPage (switch between data stores back and force) : http://jira.codehaus.org/browse/GEOS-4827

Improvement : “UNKNOWN” - in CRS text field : http://jira.codehaus.org/browse/GEOS-4809

I was wondering, whether someone can have a look at the minor changes.

Thanks
-Frank

The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@anonymised.com Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

3

Thanks for the review, I going to fix this and set up my IDE correctly :wink:

Cheers
-Frank

2011/10/27 Justin Deoliveira <jdeolive@anonymised.com>

tabs

4

On Thu, Oct 27, 2011 at 8:58 AM, Frank Gasdorf <fgdrf@anonymised.com> wrote:

Thanks for the review, I going to fix this and set up my IDE correctly :wink:

If you are using Eclipse we have the conventions ready to import here:
http://svn.osgeo.org/geotools/trunk/build/eclipse/formatter.xml

Cheers
Andrea

–

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf