After a bit of encouragement this week I am almost ready to submit the Managed File API proposal.
Before I do I wanted a to ask for the historical background on GeoServerResourceLoader “search locations”.
Reviewing the code we end up with the following:
base directory (determined using lookupGeoServerDataDirectory)
base directory / data (is this for backwards compatibility?)
application context / WEB-INF
application context /
absolute file references: the API supports the use of find( parent, location ) - which performs a check for absolute file references. I cannot find much evidence that this is used - code such as security or style pass in the appropriate data directory folder.
Search locations recorded as a Set so no order is assumed when searching (so using search locations to “override” data directory settings would not work)
After a bit of encouragement this week I am almost ready to submit the Managed File API proposal.
Before I do I wanted a to ask for the historical background on GeoServerResourceLoader “search locations”.
Reviewing the code we end up with the following:
base directory (determined using lookupGeoServerDataDirectory)
base directory / data (is this for backwards compatibility?)
application context / WEB-INF
application context /
absolute file references: the API supports the use of find( parent, location ) - which performs a check for absolute file references. I cannot find much evidence that this is used - code such as security or style pass in the appropriate data directory folder.
Search locations recorded as a Set so no order is assumed when searching (so using search locations to “override” data directory settings would not work)
Hi Jody,
I believe the search location business was created fully by Justin.
At least I have no clue why we are searching more locations than
just the data directory
After a bit of encouragement this week I am almost ready to submit the Managed File API proposal.
Before I do I wanted a to ask for the historical background on GeoServerResourceLoader “search locations”.
Reviewing the code we end up with the following:
base directory (determined using lookupGeoServerDataDirectory)
base directory / data (is this for backwards compatibility?)
application context / WEB-INF
application context /
absolute file references: the API supports the use of find( parent, location ) - which performs a check for absolute file references. I cannot find much evidence that this is used - code such as security or style pass in the appropriate data directory folder.
Search locations recorded as a Set so no order is assumed when searching (so using search locations to “override” data directory settings would not work)
I just did not want to hurt anyones feelings (or production stability) by removing useful functionality. So far the only deal breaker I can find is some security code that accesses WEB-INF/web.xml
Well we will see what Justin says, but I feel simplification (although rare for GeoServer) may be in order.
After a bit of encouragement this week I am almost ready to submit the Managed File API proposal.
Before I do I wanted a to ask for the historical background on GeoServerResourceLoader “search locations”.
Reviewing the code we end up with the following:
base directory (determined using lookupGeoServerDataDirectory)
base directory / data (is this for backwards compatibility?)
application context / WEB-INF
application context /
absolute file references: the API supports the use of find( parent, location ) - which performs a check for absolute file references. I cannot find much evidence that this is used - code such as security or style pass in the appropriate data directory folder.
Search locations recorded as a Set so no order is assumed when searching (so using search locations to “override” data directory settings would not work)
Yes I believe it’s obsolete now. I believe we might have been using a while back to load resources from WEB-INF but don’t think that is the case any longer. So yeah, thinking it is probably something that can be killed.
I just did not want to hurt anyones feelings (or production stability) by removing useful functionality. So far the only deal breaker I can find is some security code that accesses WEB-INF/web.xml
Well we will see what Justin says, but I feel simplification (although rare for GeoServer) may be in order.
Hi Jody,
I believe the search location business was created fully by Justin.
At least I have no clue why we are searching more locations than
just the data directory
After a bit of encouragement this week I am almost ready to submit the Managed File API proposal.
Before I do I wanted a to ask for the historical background on GeoServerResourceLoader “search locations”.
Reviewing the code we end up with the following:
base directory (determined using lookupGeoServerDataDirectory)
base directory / data (is this for backwards compatibility?)
application context / WEB-INF
application context /
absolute file references: the API supports the use of find( parent, location ) - which performs a check for absolute file references. I cannot find much evidence that this is used - code such as security or style pass in the appropriate data directory folder.
Search locations recorded as a Set so no order is assumed when searching (so using search locations to “override” data directory settings would not work)
Yes I believe it’s obsolete now. I believe we might have been using a while back to load resources from WEB-INF but don’t think that is the case any longer. So yeah, thinking it is probably something that can be killed.
I just did not want to hurt anyones feelings (or production stability) by removing useful functionality. So far the only deal breaker I can find is some security code that accesses WEB-INF/web.xml
Well we will see what Justin says, but I feel simplification (although rare for GeoServer) may be in order.
Hi Jody,
I believe the search location business was created fully by Justin.
At least I have no clue why we are searching more locations than
just the data directory
After a bit of encouragement this week I am almost ready to submit the Managed File API proposal.
Before I do I wanted a to ask for the historical background on GeoServerResourceLoader “search locations”.
Reviewing the code we end up with the following:
base directory (determined using lookupGeoServerDataDirectory)
base directory / data (is this for backwards compatibility?)
application context / WEB-INF
application context /
absolute file references: the API supports the use of find( parent, location ) - which performs a check for absolute file references. I cannot find much evidence that this is used - code such as security or style pass in the appropriate data directory folder.
Search locations recorded as a Set so no order is assumed when searching (so using search locations to “override” data directory settings would not work)