[Geoserver-devel] Some glitch in GetFeatureKVPRequestReader.querySet?

Hi,
working on fixing GEOS-1137 I tried out the following query
on an unmodified Geoserver trunk (to asses what was the functionality
level of trunk):

http://localhost:8080/geoserver/wfs?request=GetFeature&version=1.1.0&typeName=topp:states&propertyName=STATE_NAME,PERSONS&featureid=states.1,states.2

to my surprise the result returned all states, like as if not
filter was set. Tracking down I discovered that GetFeatureKvpRequestReader.queryset at
line 238 was duplicating some Query object but not setting
the filters (because we exit right away from that blog).

Now, I'm going to turn the filter creation into something that
returns a single filter, so the problem will go away, but I'm
wondering if there is any bug in that querySet code too.

Cheers
Andrea

Hmmm... so right now it is assumed that if multiple featureId's are specified there is one corresponding to each type given in typeName. So what happens if multiple typeName's are specified? Do you apply all featureId's to each type?

Andrea Aime wrote:

Hi,
working on fixing GEOS-1137 I tried out the following query
on an unmodified Geoserver trunk (to asses what was the functionality
level of trunk):

http://localhost:8080/geoserver/wfs?request=GetFeature&version=1.1.0&typeName=topp:states&propertyName=STATE_NAME,PERSONS&featureid=states.1,states.2

to my surprise the result returned all states, like as if not
filter was set. Tracking down I discovered that GetFeatureKvpRequestReader.queryset at
line 238 was duplicating some Query object but not setting
the filters (because we exit right away from that blog).

Now, I'm going to turn the filter creation into something that
returns a single filter, so the problem will go away, but I'm
wondering if there is any bug in that querySet code too.

Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,46a0d183219915219720167!

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

Justin Deoliveira ha scritto:

Hmmm... so right now it is assumed that if multiple featureId's are specified there is one corresponding to each type given in typeName. So what happens if multiple typeName's are specified? Do you apply all featureId's to each type?

Of course. And this is already handled by the code over there.
Besides an hilarious bug in shapefile handling of feature ids, it's working fine.
Cheers
Andrea