[Geoserver-devel] Starting an stable GeoServer release train early

jive · June 12, 2024, 11:20pm

Hello everyone,

I asked last meeting if I could create an additional stable release for GeoCat Customers (along side the maintenance release scheduled for June 18th).

If you have any changes to get in please let me know. I am going to be pretty focused and not hunting down open PRs like normal.

···

–
Jody Garnett

jive · June 14, 2024, 5:25am

The first release has left the station:

Anyone wishing to provide preflight testing the artifacts are here: https://build.geoserver.org/view/release/job/geoserver-release/ws/distribution/2.23.6/

Blog post is also ready for review as a pull-request: https://github.com/geoserver/geoserver.github.io/pull/199

Peter do you wish to make 2.24.4 next? Or is the coast clear for 2.25.2 …

···

–
Jody Garnett

Peter_Smythe · June 14, 2024, 12:20pm

Thank you Jody

Yes, I had intended to start with 2.24.4 early next week, but since there are no open PRs on the maintenance branch, I can start with it now.

···

Peter

GeoServer PSC
AWS Solutions Architect
https://github.com/petersmythe

–
Jody Garnett

jive · June 15, 2024, 4:00pm

GeoServer 2.25.2 is ready for preflight testing: https://build.geoserver.org/view/release/job/geoserver-release/144/artifact/distribution/2.25.2

There was a last moment fix if the new Demo Request page (missing wicket header contributions) but it was otherwise uneventful.

The previous https://github.com/geoserver/geoserver.github.io/pull/199 now covers both releases.

···

–
Jody Garnett

Peter

GeoServer PSC
AWS Solutions Architect
https://github.com/petersmythe

–
Jody Garnett

Jukka_Rahkonen · June 17, 2024, 12:26pm

Hi,

I made some basic tests on Windows with the bin-zip installation and did not notice any issues. I also clicked through all the demo requests and made some observations.

WFS_getFeatureBetween-1.1.xml fails, I do not understand why.

<ows:Exception exceptionCode=“NoApplicableCode”>

ows:ExceptionTextjava.lang.RuntimeException: Error encoding object to xml-element

Error encoding object to xml-element

Can handle 3 attributes only, index is 3</ows:ExceptionText>

</ows:Exception>

WMS_GetLegendGraphic-SLD.url does not pass validation.

org.geotools.data.ows.URLCheckerException: Evaluation Failure: ‘http://localhost:8080/geoserver/www/styles/green.sld’ was not accepted by external URL checks

Evaluation Failure: ‘http://localhost:8080/geoserver/www/styles/green.sld’ was not accepted by external URL checks

The WPS aggregate examples do not work, they return

Error 404 Not Found

-Jukka Rahkonen-

···

Lähettäjä: Jody Garnett <jody.garnett@…403…>
Lähetetty: lauantai 15. kesäkuuta 2024 19.01
Vastaanottaja: Peter Smythe <gs@…5004…>
Kopio: Geoserver-devel geoserver-devel@lists.sourceforge.net
Aihe: Re: [Geoserver-devel] Starting an stable GeoServer release train early

GeoServer 2.25.2 is ready for preflight testing: https://build.geoserver.org/view/release/job/geoserver-release/144/artifact/distribution/2.25.2

There was a last moment fix if the new Demo Request page (missing wicket header contributions) but it was otherwise uneventful.

The previous https://github.com/geoserver/geoserver.github.io/pull/199 now covers both releases.

–

Jody Garnett

On Jun 14, 2024 at 5:20:27 AM, Peter Smythe <gs@…5004…> wrote:

Thank you Jody

Yes, I had intended to start with 2.24.4 early next week, but since there are no open PRs on the maintenance branch, I can start with it now.

Peter

GeoServer PSC
AWS Solutions Architect
https://github.com/petersmythe

On Fri, 14 Jun 2024 at 07:25, Jody Garnett <jody.garnett@…403…> wrote:

The first release has left the station:

Anyone wishing to provide preflight testing the artifacts are here: https://build.geoserver.org/view/release/job/geoserver-release/ws/distribution/2.23.6/

Blog post is also ready for review as a pull-request: https://github.com/geoserver/geoserver.github.io/pull/199

Peter do you wish to make 2.24.4 next? Or is the coast clear for 2.25.2 …

–

Jody Garnett

On Jun 12, 2024 at 4:20:22 PM, Jody Garnett <jody.garnett@…403…> wrote:

Hello everyone,

I asked last meeting if I could create an additional stable release for GeoCat Customers (along side the maintenance release scheduled for June 18th).

If you have any changes to get in please let me know. I am going to be pretty focused and not hunting down open PRs like normal.

–

Jody Garnett

jive · June 17, 2024, 1:58pm

Thanks for testing!

Can we test an earlier version to see if this is a regression in the UI or the application? Without CITE tests in our build we always run a higher risk of regression.

···

–
Jody Garnett

jive · June 17, 2024, 4:01pm

Testing with 2.25.1:

WFS_getFeatureBBOX.url: result
WFS_getFeatureBetween-1.0.xml: states.1, states.7, states.9,states.13,…
WFS_getFeatureBetween-1.1.xml: Same error message Caused by: java.lang.ArrayIndexOutOfBoundsException: Can handle 3 attributes only, index is 3

This is the same error you found on 2.25.2: The result should only contain the attributes requested, or that are required to filter the content.

The query checks one attribute:

ogc:Filter
ogc:PropertyIsBetween
ogc:PropertyNametopp:LAND_KM</ogc:PropertyName>
ogc:LowerBoundary ogc:Literal100000</ogc:Literal></ogc:LowerBoundary>
ogc:UpperBoundary ogc:Literal150000</ogc:Literal></ogc:UpperBoundary>
</ogc:PropertyIsBetween>
</ogc:Filter>

The query lists three attributes to return:

wfs:PropertyNametopp:STATE_NAME</wfs:PropertyName>
wfs:PropertyNametopp:LAND_KM</wfs:PropertyName>
wfs:PropertyNametopp:the_geom</wfs:PropertyName>

But the results is coming back with 4 values (not sure why) and it fails when trying to store a the additional values in a feature…

From the logs:

Request: getFeature

service = WFS

version = 1.1.0

baseUrl = http://localhost:8080/geoserver/

query[0]:

propertyName[0] = topp:STATE_NAMEpropertyName[0] = topp:LAND_KMpropertyName[0] = topp:the_geom

filter = [ topp:LAND_KM BETWEEN 100000 AND 150000 ]

typeName[0] = {http://www.openplans.org/topp}states

outputFormat = text/xml; subtype=gml/3.1.1

resultType = results

…

17 Jun. 08:57:44 DEBUG [data.transform] - The original query for feature extraction Query:

feature type: states

filter: [ topp:LAND_KM BETWEEN 100000 AND 150000 ]

[properties: the_geom, STATE_NAME, LAND_KM] has been transformed to Query:

feature type: states

filter: [ topp:LAND_KM BETWEEN 100000 AND 150000 ]

[properties: STATE_NAME, LAND_KM, the_geom]

…

17 Jun. 08:57:44 ERROR [geoserver.ows] -

java.lang.RuntimeException: Error encoding object to xml-element

at org.geotools.xsd.Encoder.processChildren(Encoder.java:1028)

at org.geotools.xsd.Encoder.encode(Encoder.java:655)

at org.geotools.xsd.Encoder.encode(Encoder.java:553)

at org.geoserver.wfs.xml.GML3OutputFormat.encode(GML3OutputFormat.java:397)

at org.geoserver.wfs.xml.GML3OutputFormat.write(GML3OutputFormat.java:323)

at org.geoserver.wfs.WFSGetFeatureOutputFormat.write(WFSGetFeatureOutputFormat.java:199)

at org.geoserver.ows.Dispatcher.response(Dispatcher.java:1034)

at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:273)

…

Caused by: java.lang.ArrayIndexOutOfBoundsException: Can handle 3 attributes only, index is 3

at org.geotools.feature.simple.SimpleFeatureBuilder.set(SimpleFeatureBuilder.java:259)

at org.geotools.feature.simple.SimpleFeatureBuilder.add(SimpleFeatureBuilder.java:203)

at org.geotools.feature.simple.SimpleFeatureBuilder.addAll(SimpleFeatureBuilder.java:210)

at org.geotools.feature.simple.SimpleFeatureBuilder.addAll(SimpleFeatureBuilder.java:216)

at org.geotools.feature.simple.SimpleFeatureBuilder.build(SimpleFeatureBuilder.java:349)

at org.geotools.data.crs.ReprojectFeatureIterator.next(ReprojectFeatureIterator.java:125)

at org.geotools.data.crs.ReprojectFeatureIterator.next(ReprojectFeatureIterator.java:62)

at org.geoserver.security.decorators.SecuredSimpleFeatureIterator.next(SecuredSimpleFeatureIterator.java:40)

at org.geoserver.security.decorators.SecuredSimpleFeatureIterator.next(SecuredSimpleFeatureIterator.java:19)

at org.geotools.gml2.simple.FeatureCollectionEncoderDelegate.encode(FeatureCollectionEncoderDelegate.java:124)

at org.geotools.xsd.Encoder.processChildren(Encoder.java:1026)

So this needs a new bug report:

···

–
Jody Garnett

jive · June 17, 2024, 5:01pm

Same issue with 2.24.4 preflight artifacts so this does not appear to be a new problem

···

–
Jody Garnett

Jukka_Rahkonen · June 17, 2024, 5:10pm

Hi,

Version 2.23.5 does not have this issue.

-Jukka-

···

Lähettäjä: Jody Garnett <jody.garnett@…403…>
Lähetetty: maanantai 17. kesäkuuta 2024 20.01
Vastaanottaja: Rahkonen Jukka <jukka.rahkonen@…4189…>
Kopio: Geoserver-devel geoserver-devel@lists.sourceforge.net; Peter Smythe <gs@…5004…>
Aihe: Re: [Geoserver-devel] Starting an stable GeoServer release train early

Same issue with 2.24.4 preflight artifacts so this does not appear to be a new problem

–

Jody Garnett

On Jun 17, 2024 at 9:01:30 AM, Jody Garnett <jody.garnett@…403…> wrote:

Testing with 2.25.1:

WFS_getFeatureBBOX.url: result

WFS_getFeatureBetween-1.0.xml: states.1, states.7, states.9,states.13,…

WFS_getFeatureBetween-1.1.xml: Same error message Caused by: java.lang.ArrayIndexOutOfBoundsException: Can handle 3 attributes only, index is 3

This is the same error you found on 2.25.2: The result should only contain the attributes requested, or that are required to filter the content.

The query checks one attribute:

ogc:Filter

ogc:PropertyIsBetween

ogc:PropertyNametopp:LAND_KM</ogc:PropertyName>

ogc:LowerBoundary ogc:Literal100000</ogc:Literal></ogc:LowerBoundary>

ogc:UpperBoundary ogc:Literal150000</ogc:Literal></ogc:UpperBoundary>

</ogc:PropertyIsBetween>

</ogc:Filter>

The query lists three attributes to return:

wfs:PropertyNametopp:STATE_NAME</wfs:PropertyName>

wfs:PropertyNametopp:LAND_KM</wfs:PropertyName>

wfs:PropertyNametopp:the_geom</wfs:PropertyName>

But the results is coming back with 4 values (not sure why) and it fails when trying to store a the additional values in a feature…

From the logs:

Request: getFeature

service = WFS

version = 1.1.0

baseUrl = http://localhost:8080/geoserver/

query[0]:

propertyName[0] = topp:STATE_NAMEpropertyName[0] = topp:LAND_KMpropertyName[0] = topp:the_geom

filter = [ topp:LAND_KM BETWEEN 100000 AND 150000 ]

typeName[0] = {http://www.openplans.org/topp}states

outputFormat = text/xml; subtype=gml/3.1.1

resultType = results

…

17 Jun. 08:57:44 DEBUG [data.transform] - The original query for feature extraction Query:

feature type: states

filter: [ topp:LAND_KM BETWEEN 100000 AND 150000 ]

[properties: the_geom, STATE_NAME, LAND_KM] has been transformed to Query:

feature type: states

filter: [ topp:LAND_KM BETWEEN 100000 AND 150000 ]

[properties: STATE_NAME, LAND_KM, the_geom]

…

17 Jun. 08:57:44 ERROR [geoserver.ows] -

java.lang.RuntimeException: Error encoding object to xml-element

at org.geotools.xsd.Encoder.processChildren(Encoder.java:1028)

at org.geotools.xsd.Encoder.encode(Encoder.java:655)

at org.geotools.xsd.Encoder.encode(Encoder.java:553)

at org.geoserver.wfs.xml.GML3OutputFormat.encode(GML3OutputFormat.java:397)

at org.geoserver.wfs.xml.GML3OutputFormat.write(GML3OutputFormat.java:323)

at org.geoserver.wfs.WFSGetFeatureOutputFormat.write(WFSGetFeatureOutputFormat.java:199)

at org.geoserver.ows.Dispatcher.response(Dispatcher.java:1034)

at org.geoserver.ows.Dispatcher.handleRequestInternal(Dispatcher.java:273)

…

Caused by: java.lang.ArrayIndexOutOfBoundsException: Can handle 3 attributes only, index is 3

at org.geotools.feature.simple.SimpleFeatureBuilder.set(SimpleFeatureBuilder.java:259)

at org.geotools.feature.simple.SimpleFeatureBuilder.add(SimpleFeatureBuilder.java:203)

at org.geotools.feature.simple.SimpleFeatureBuilder.addAll(SimpleFeatureBuilder.java:210)

at org.geotools.feature.simple.SimpleFeatureBuilder.addAll(SimpleFeatureBuilder.java:216)

at org.geotools.feature.simple.SimpleFeatureBuilder.build(SimpleFeatureBuilder.java:349)

at org.geotools.data.crs.ReprojectFeatureIterator.next(ReprojectFeatureIterator.java:125)

at org.geotools.data.crs.ReprojectFeatureIterator.next(ReprojectFeatureIterator.java:62)

at org.geoserver.security.decorators.SecuredSimpleFeatureIterator.next(SecuredSimpleFeatureIterator.java:40)

at org.geoserver.security.decorators.SecuredSimpleFeatureIterator.next(SecuredSimpleFeatureIterator.java:19)

at org.geotools.gml2.simple.FeatureCollectionEncoderDelegate.encode(FeatureCollectionEncoderDelegate.java:124)

at org.geotools.xsd.Encoder.processChildren(Encoder.java:1026)

So this needs a new bug report:

–

Jody Garnett

On Jun 17, 2024 at 5:26:59 AM, Rahkonen Jukka <jukka.rahkonen@…4189…> wrote:

Hi,

I made some basic tests on Windows with the bin-zip installation and did not notice any issues. I also clicked through all the demo requests and made some observations.

WFS_getFeatureBetween-1.1.xml fails, I do not understand why.

<ows:Exception exceptionCode=“NoApplicableCode”>

ows:ExceptionTextjava.lang.RuntimeException: Error encoding object to xml-element

Error encoding object to xml-element

Can handle 3 attributes only, index is 3</ows:ExceptionText>

</ows:Exception>

WMS_GetLegendGraphic-SLD.url does not pass validation.

org.geotools.data.ows.URLCheckerException: Evaluation Failure: ‘http://localhost:8080/geoserver/www/styles/green.sld’ was not accepted by external URL checks

Evaluation Failure: ‘http://localhost:8080/geoserver/www/styles/green.sld’ was not accepted by external URL checks

The WPS aggregate examples do not work, they return

Error 404 Not Found

-Jukka Rahkonen-

Lähettäjä: Jody Garnett <jody.garnett@…403…>
Lähetetty: lauantai 15. kesäkuuta 2024 19.01
Vastaanottaja: Peter Smythe <gs@…5004…>
Kopio: Geoserver-devel <geoserver-devel@lists.sourceforge.net>
Aihe: Re: [Geoserver-devel] Starting an stable GeoServer release train early

GeoServer 2.25.2 is ready for preflight testing: https://build.geoserver.org/view/release/job/geoserver-release/144/artifact/distribution/2.25.2

There was a last moment fix if the new Demo Request page (missing wicket header contributions) but it was otherwise uneventful.

The previous https://github.com/geoserver/geoserver.github.io/pull/199 now covers both releases.

–

Jody Garnett

On Jun 14, 2024 at 5:20:27 AM, Peter Smythe <gs@…5004…> wrote:

Thank you Jody

Yes, I had intended to start with 2.24.4 early next week, but since there are no open PRs on the maintenance branch, I can start with it now.

Peter

GeoServer PSC
AWS Solutions Architect
https://github.com/petersmythe

On Fri, 14 Jun 2024 at 07:25, Jody Garnett <jody.garnett@…403…> wrote:

The first release has left the station:

Anyone wishing to provide preflight testing the artifacts are here: https://build.geoserver.org/view/release/job/geoserver-release/ws/distribution/2.23.6/

Blog post is also ready for review as a pull-request: https://github.com/geoserver/geoserver.github.io/pull/199

Peter do you wish to make 2.24.4 next? Or is the coast clear for 2.25.2 …

–

Jody Garnett

On Jun 12, 2024 at 4:20:22 PM, Jody Garnett <jody.garnett@…403…> wrote:

Hello everyone,

I asked last meeting if I could create an additional stable release for GeoCat Customers (along side the maintenance release scheduled for June 18th).

If you have any changes to get in please let me know. I am going to be pretty focused and not hunting down open PRs like normal.

–

Jody Garnett

jive · June 17, 2024, 7:06pm

So here is where we stand:

2.22.x WFS_getFeatureBetween-1-1.xml - no problem
2.23.6 WFS_getFeatureBetween-1-1.xml - no problem
2.24.2 WFS_getFeatureBetween-1-1.xml - failure
2.25.2 WFS_getFeatureBetween-1-1.xml - failure

Bug is reported here https://osgeo-org.atlassian.net/browse/GEOS-11435

···

–
Jody Garnett