[Geoserver-devel] TextSymbolizer with multi line Label and background Graphic

Hi,

Actually, the x position of the background graphic is based on the last line of the multi line label.
This works well when the AnchorPointX is 0, but when the AnchorPointX is 1 the graphic appears shifted from the label (see left side of image attached).

In attach is a very simple patch to correct the issue on file modules/library/render/src/main/java/org/geotools/renderer/label/LabelPainter.java

Sorry, I’m not a developer and can’t figure out how to develop a unit test case.
I tested manually changing the AnchorPointX to 0, 0.5 and 1.0 and seems to work fine in all situations.

Best regards,
Paulo

(attachments)

0001-Fix-graphic-element-for-TextSymbolizer-multiline-tex.patch (1.97 KB)
patch_multiline_graphic.png

Hi,
thanks for the patch.
We are closing the feature freeze for the 2.7.x series and developers are rather busy,
could you open a ticket at http://jira.codehaus.org/browse/GEOS and attach the patch
there, this will make sure it does not get forgotten.

We’ll apply the patch once someone develops a unit test (I hope to be able to help,
develop the test and merge the patch, but I cannot promise to do it quickly)

Cheers
Andrea

···

On Wed, Jan 7, 2015 at 12:57 PM, <as1613867@anonymised.com> wrote:

Hi,

Actually, the x position of the background graphic is based on the last line of the multi line label.
This works well when the AnchorPointX is 0, but when the AnchorPointX is 1 the graphic appears shifted from the label (see left side of image attached).

In attach is a very simple patch to correct the issue on file modules/library/render/src/main/java/org/geotools/renderer/label/LabelPainter.java

Sorry, I’m not a developer and can’t figure out how to develop a unit test case.
I tested manually changing the AnchorPointX to 0, 0.5 and 1.0 and seems to work fine in all situations.

Best regards,
Paulo


Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Hi,

Ticket created ( https://jira.codehaus.org/browse/GEOT-4977 ) with patch attached.

Thanks,
Paulo

Citando Andrea Aime <andrea.aime@anonymised.com>:

···

On Wed, Jan 7, 2015 at 12:57 PM, <as1613867@…4168…> wrote:

Hi,

Actually, the x position of the background graphic is based on the last line of the multi line label.
This works well when the AnchorPointX is 0, but when the AnchorPointX is 1 the graphic appears shifted from the label (see left side of image attached).

In attach is a very simple patch to correct the issue on file modules/library/render/src/main/java/org/geotools/renderer/label/LabelPainter.java

Sorry, I’m not a developer and can’t figure out how to develop a unit test case.
I tested manually changing the AnchorPointX to 0, 0.5 and 1.0 and seems to work fine in all situations.

Best regards,
Paulo


Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net


Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.