[Geoserver-devel] updatesequence support (GEOS-235)

hey all,

I really needed to fix GEOS-235
(http://jira.codehaus.org/browse/GEOS-235) with updateSequence support.
So now there are patches attached to the JIRA.

I suggest that this happen at the 1.6.1 timeframe (or at least the "post
1.6.0" timeframe) so as to not delay any further the RC process.

Can someone with a working gs trunk install give the trunk patch a test?

testing is pretty easy. The UI has your latest updatesequence number,
and doing a getcapabilities with "&updatesequence=YOURNUMBER" should
cause everything to get triggered.

Try testing it three ways:

1) Use a number LOWER than the current updatesquence. Normal response
should ensue.

2) Use a number EQUAL to the current updatesquence. ServiceException
with code "CurrentUpdateSequence" should come back

3) Use a number HIGHER than the current updatesquence.
ServiceException with code "InvalideUpdateSequence" should come back

I'd like a review of this patch before commiting it on trunk. Also,
andrea, this doesn't patch WCS 1.1.0, only WCS 1.0.0...so can you port
the (tiny) bit of this that's relevant to WCS 1.1.0 into the right
place, if it passes the review?

thanks much,
--saul

Hi Saul,

I just applied the patch in my local checkout to try it and a couple of
things:

* the exception messages from wfs and wcs mention "WMS"
* &updatesequence=x seems to have no effect on output... i still get
updateSequence=<latest>, i am not sure what the correct behavior is...
but following the code down the value is correctly parsed and the checks
are done and all of that.

-Justin

Saul Farber wrote:

hey all,

I really needed to fix GEOS-235
(http://jira.codehaus.org/browse/GEOS-235) with updateSequence support.
So now there are patches attached to the JIRA.

I suggest that this happen at the 1.6.1 timeframe (or at least the "post
1.6.0" timeframe) so as to not delay any further the RC process.

Can someone with a working gs trunk install give the trunk patch a test?

testing is pretty easy. The UI has your latest updatesequence number,
and doing a getcapabilities with "&updatesequence=YOURNUMBER" should
cause everything to get triggered.

Try testing it three ways:

1) Use a number LOWER than the current updatesquence. Normal response
should ensue.

2) Use a number EQUAL to the current updatesquence. ServiceException
with code "CurrentUpdateSequence" should come back

3) Use a number HIGHER than the current updatesquence.
ServiceException with code "InvalideUpdateSequence" should come back

I'd like a review of this patch before commiting it on trunk. Also,
andrea, this doesn't patch WCS 1.1.0, only WCS 1.0.0...so can you port
the (tiny) bit of this that's relevant to WCS 1.1.0 into the right
place, if it passes the review?

thanks much,
--saul

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4007,4782a6d2203353362379201!

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

Justin,

Thanks for poking at this.

I also tried it, and I got the expected results for WFS 1.1.0 and WMS
1.1.1 (I didn't try the others)

Good point about all three mentioning the "WMS" in the error message.
I'll try to centralize that bit in a central class somewhere so that the
exception is thrown with a proper service name.

--saul

On Tue, 2008-01-08 at 09:30 -0800, Justin Deoliveira wrote:

Hi Saul,

I just applied the patch in my local checkout to try it and a couple of
things:

* the exception messages from wfs and wcs mention "WMS"
* &updatesequence=x seems to have no effect on output... i still get
updateSequence=<latest>, i am not sure what the correct behavior is...
but following the code down the value is correctly parsed and the checks
are done and all of that.

-Justin

Saul Farber wrote:
> hey all,
>
> I really needed to fix GEOS-235
> (http://jira.codehaus.org/browse/GEOS-235) with updateSequence support.
> So now there are patches attached to the JIRA.
>
> I suggest that this happen at the 1.6.1 timeframe (or at least the "post
> 1.6.0" timeframe) so as to not delay any further the RC process.
>
> Can someone with a working gs trunk install give the trunk patch a test?
>
> testing is pretty easy. The UI has your latest updatesequence number,
> and doing a getcapabilities with "&updatesequence=YOURNUMBER" should
> cause everything to get triggered.
>
> Try testing it three ways:
>
> 1) Use a number LOWER than the current updatesquence. Normal response
> should ensue.
>
> 2) Use a number EQUAL to the current updatesquence. ServiceException
> with code "CurrentUpdateSequence" should come back
>
> 3) Use a number HIGHER than the current updatesquence.
> ServiceException with code "InvalideUpdateSequence" should come back
>
>
> I'd like a review of this patch before commiting it on trunk. Also,
> andrea, this doesn't patch WCS 1.1.0, only WCS 1.0.0...so can you port
> the (tiny) bit of this that's relevant to WCS 1.1.0 into the right
> place, if it passes the review?
>
> thanks much,
> --saul
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
> !DSPAM:4007,4782a6d2203353362379201!
>