[Geoserver-devel] wfsv and strict=true

I thought we ran up against this before but I just was debugging an issue with Tim and saw it again.

So the problem is that the wfsv reader "hijacks" regular wfs requests. The wfs xml readers do not seem to respect the strict flag which causes validation. A couple of questions:

1. There seem to be 4 wfs xml readers in the wfsv modul

org.geoserver.wfsv.xml.v1_0_0.WfsXmlReader
org.geoserver.wfsv.xml.v1_0_0.WfsvXmlReader
org.geoserver.wfsv.xml.v1_1_0.WfsXmlReader
org.geoserver.wfsv.xml.v1_1_0.WfsvXmlReader

Are they all registered? Are they all necessary?

2. Is there still plans to make wfsv an extension. Right now its half and half as its included the rest of the core modules, but only activated via profile.

-Justin

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Justin Deoliveira ha scritto:

I thought we ran up against this before but I just was debugging an issue with Tim and saw it again.

So the problem is that the wfsv reader "hijacks" regular wfs requests.

Yep, we fixed it that by adding an extra service parameter in the constructor (service id, the last parameter). At least, that's the
theory. I see that the service id seems to be used by the
dispatcher only in sorting, but not in filtering?

The wfs xml readers do not seem to respect the strict flag which causes validation.

It was added later than the wfsv protocol, can you open a jira?
I'll have a look at the wfs ones and see if I can fix this.

A couple of questions:

1. There seem to be 4 wfs xml readers in the wfsv modul

org.geoserver.wfsv.xml.v1_0_0.WfsXmlReader
org.geoserver.wfsv.xml.v1_0_0.WfsvXmlReader
org.geoserver.wfsv.xml.v1_1_0.WfsXmlReader
org.geoserver.wfsv.xml.v1_1_0.WfsvXmlReader

Are they all registered? Are they all necessary?

They are all registered. All necessary, I believe so but I'm not
sure. In WFSV the transaction element is the WFS one, but it can
contain an extra native element which is Rollback. The WfsXmlReader
ones are there to handle that extra element.
I can remove them, just suggest a way to handle the rollback
element without registering a custom reader.

2. Is there still plans to make wfsv an extension. Right now its half and half as its included the rest of the core modules, but only activated via profile.

Yeah, that is a good idea. Can you open a jira for this one as well?
(otherwise I'll open it tomorrow, now it's a bit late here)

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.