[GRASS-dev] [GRASS GIS] #1584: error in r.walk help page

#1584: error in r.walk help page
--------------------+-------------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Docs | Version: unspecified
Keywords: r.walk | Platform: All
      Cpu: All |
--------------------+-------------------------------------------------------
one from Agustin:

{{{
the documentation in r.walk is wrong. It says:
"The default values for a, b, c, d are those proposed by Langmuir
(0.72, 6.0, 1.9998, -1.9998)"
and it should say:
"The default values for a, b, c, d are those proposed by Langmuir
(0.72, 6.0, -1.9998, 1.9998)"

because the point is that you go faster on gentle slopes and more
slowly on steeper slopes and those values are in m/s
The worrying question is whether these values are also wrong in the
default values of r.walk.
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1584&gt;
GRASS GIS <http://grass.osgeo.org>

#1584: error in r.walk help page
--------------------+-------------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Docs | Version: unspecified
Keywords: r.walk | Platform: All
      Cpu: All |
--------------------+-------------------------------------------------------

Comment(by dkavanagh):

There is also a mistake in the Standard Directions figure in the Movement
Direction section. 90 should be immediately below x and the zero should be
removed.

Replying to [ticket:1584 hamish]:
> one from Agustin:
>
> {{{
> the documentation in r.walk is wrong. It says:
> "The default values for a, b, c, d are those proposed by Langmuir
> (0.72, 6.0, 1.9998, -1.9998)"
> and it should say:
> "The default values for a, b, c, d are those proposed by Langmuir
> (0.72, 6.0, -1.9998, 1.9998)"
>
> because the point is that you go faster on gentle slopes and more
> slowly on steeper slopes and those values are in m/s
> The worrying question is whether these values are also wrong in the
> default values of r.walk.
> }}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1584#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1584: error in r.walk help page
--------------------+-------------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Docs | Version: unspecified
Keywords: r.walk | Platform: All
      Cpu: All |
--------------------+-------------------------------------------------------

Comment(by dkavanagh):

My note applies to 6.5 and 7.0. The Langmuir correction applies to all
versions.

Replying to [comment:1 dkavanagh]:
> There is also a mistake in the Standard Directions figure in the
Movement Direction section. 90 should be immediately below x and the zero
should be removed.
>
> Replying to [ticket:1584 hamish]:
> > one from Agustin:
> >
> > {{{
> > the documentation in r.walk is wrong. It says:
> > "The default values for a, b, c, d are those proposed by Langmuir
> > (0.72, 6.0, 1.9998, -1.9998)"
> > and it should say:
> > "The default values for a, b, c, d are those proposed by Langmuir
> > (0.72, 6.0, -1.9998, 1.9998)"
> >
> > because the point is that you go faster on gentle slopes and more
> > slowly on steeper slopes and those values are in m/s
> > The worrying question is whether these values are also wrong in the
> > default values of r.walk.
> > }}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1584#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1584: error in r.walk help page
--------------------+-------------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Docs | Version: unspecified
Keywords: r.walk | Platform: All
      Cpu: All |
--------------------+-------------------------------------------------------

Comment(by dkavanagh):

Hamish - I believe the help is correct. c and d are multiplied by the
delta, which in a downward slope will be negative. Here is an example from
the code - fcost_dtm = (double)((double)(W_dtm - my_dtm) * c);

Replying to [ticket:1584 hamish]:
> one from Agustin:
>
> {{{
> the documentation in r.walk is wrong. It says:
> "The default values for a, b, c, d are those proposed by Langmuir
> (0.72, 6.0, 1.9998, -1.9998)"
> and it should say:
> "The default values for a, b, c, d are those proposed by Langmuir
> (0.72, 6.0, -1.9998, 1.9998)"
>
> because the point is that you go faster on gentle slopes and more
> slowly on steeper slopes and those values are in m/s
> The worrying question is whether these values are also wrong in the
> default values of r.walk.
> }}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1584#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#1584: error in r.walk help page
--------------------+-------------------------------------------------------
Reporter: hamish | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Docs | Version: svn-releasebranch64
Keywords: r.walk | Platform: All
      Cpu: All |
--------------------+-------------------------------------------------------
Changes (by neteler):

  * version: unspecified => svn-releasebranch64

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1584#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#1584: error in r.walk help page
---------------------+---------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: new
  Priority: major | Milestone: 7.1.0
Component: Docs | Version: svn-releasebranch64
Resolution: | Keywords: r.walk
       CPU: All | Platform: All
---------------------+---------------------------------
Changes (by neteler):

* milestone: 6.4.3 => 7.1.0

Comment:

Bumped for check to 7.1. In case backports down to G6.4 are needed.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1584#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#1584: error in r.walk help page
---------------------+---------------------------------
  Reporter: hamish | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 7.1.0
Component: Docs | Version: svn-releasebranch64
Resolution: fixed | Keywords: r.walk
       CPU: All | Platform: All
---------------------+---------------------------------
Changes (by annakrat):

* status: new => closed
* resolution: => fixed

Comment:

Replying to [comment:5 neteler]:
> Bumped for check to 7.1. In case backports down to G6.4 are needed.

I was looking into that recently in 7 and I think it's fine.
I backported some of the documentation in r65411.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1584#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>