[GRASS-dev] [GRASS GIS] #1637: r.pack and fully qualified input

#1637: r.pack and fully qualified input
-------------------------+--------------------------------------------------
Reporter: martinl | Owner: grass-dev@…
     Type: defect | Status: new
Priority: major | Milestone: 6.4.3
Component: Raster | Version: svn-releasebranch64
Keywords: r.pack | Platform: Linux
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Recently added `r.pack` doesn't support fully qualified input maps, e.g.

{{{
r.pack input=aspect@PERMANENT
ERROR: No map components found
}}}

When copying files the script expects that `GIS_OPT_INPUT` is not fully
qualified name
source:grass/branches/releasebranch_6_4/scripts/r.pack/r.pack#L92

{{{
91 for ELEMENT in cats cell cellhd colr fcell grid3 hist ; do
92 if [ -e "$BASEDIR/$ELEMENT/$GIS_OPT_INPUT" ] ; then
93 cp "$BASEDIR/$ELEMENT/$name" "$TMP_DIR/$ELEMENT"
94 fi
95 done
}}}

One thing related, I would expect that

{{{
g.findfile elem=cell file=aspect@PERMANENT
}}}

return

{{{
name='aspect'
mapset='PERMANENT'
fullname='aspect@PERMANENT'
...
}}}

and not

{{{
name='aspect@PERMANENT'
mapset='PERMANENT'
fullname='aspect@PERMANENT'
...
}}}

In the case that `g.findfile` would return not fully-qualified `name` we
could simply reuse it in the script. I think that changing `g.findfile` in
G6/G7 to report always non-qualified name should be harmless, in other
words, it should not break any scripts written for G6. What do you think?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1637&gt;
GRASS GIS <http://grass.osgeo.org>

#1637: r.pack and fully qualified input
-------------------------+--------------------------------------------------
Reporter: martinl | Owner: hamish
     Type: defect | Status: assigned
Priority: major | Milestone: 6.4.3
Component: Raster | Version: svn-releasebranch64
Keywords: r.pack | Platform: Linux
      Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by hamish):

* cc: grass-dev@… (added)
  * owner: grass-dev@… => hamish
  * status: new => assigned

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1637#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#1637: r.pack and fully qualified input
-------------------------+--------------------------------------------------
Reporter: martinl | Owner: hamish
     Type: defect | Status: assigned
Priority: major | Milestone: 6.4.3
Component: Raster | Version: svn-releasebranch64
Keywords: r.pack | Platform: Linux
      Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

I have added a patch to allow for fully qualified input names in G6.
Please validate.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/1637#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#1637: r.pack and fully qualified input
----------------------+-----------------------------------------------------
  Reporter: martinl | Owner: hamish
      Type: defect | Status: closed
  Priority: major | Milestone: 6.4.3
Component: Raster | Version: svn-releasebranch64
Resolution: fixed | Keywords: r.pack
  Platform: Linux | Cpu: Unspecified
----------------------+-----------------------------------------------------
Changes (by hamish):

  * status: assigned => closed
  * resolution: => fixed

Comment:

Hi,

thanks; it should be ok now with r55160,1.

Hamish

ps- fyi r.unpack was exposing a tarbug, since it uses `head` to cut short
the tar listing, and tar version 1.23 didn't like the pipe being closed
early. It's harmless & seems to be fixed in newer versions of tar.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1637#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>